Re: [PR] KAFKA-21158: Document retention impact of future timestamps allowed by message.timestamp.after.max.ms [kafka]

["muralibasani (via GitHub)" <gi...@apache.org>]

muralibasani commented on code in PR #23596:
URL: https://github.com/apache/kafka/pull/23596#discussion_r4199175065


##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -529,6 +529,50 @@ public static void validateBrokerLogConfigValues(Map<String, ?> props,
         }
     }
 
+    /**
+     * Returns a warning if log.message.timestamp.after.max.ms is above the default and applies (i.e. not LogAppendTime).
+     */
+    public static Optional<String> brokerMessageTimestampAfterMaxMsWarning(long afterMaxMs, TimestampType timestampType) {
+        return messageTimestampAfterMaxMsWarning(
+                ServerLogConfigs.LOG_MESSAGE_TIMESTAMP_AFTER_MAX_MS_CONFIG + " is set to " + afterMaxMs, afterMaxMs, timestampType);
+    }
+
+    /**
+     * Topic-level variant; only warns when the override or the effective timestamp type is new or changed,
+     * so unrelated alters don't repeat it.
+     */
+    public static Optional<String> topicMessageTimestampAfterMaxMsWarning(String topic,

Review Comment:
   Thanks @chia7712 agreed. 
   
   I have removed the warning logic and kept this PR to the doc change only.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org