You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zzzxl1993 (via GitHub)" <gi...@apache.org> on 2023/05/25 06:26:19 UTC

[GitHub] [doris-thirdparty] zzzxl1993 opened a new pull request, #74: [Feature] add postion and freq support for phrase query

zzzxl1993 opened a new pull request, #74:
URL: https://github.com/apache/doris-thirdparty/pull/74

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris-thirdparty] airborne12 commented on a diff in pull request #74: [Feature] add postion and freq support for phrase query

Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on code in PR #74:
URL: https://github.com/apache/doris-thirdparty/pull/74#discussion_r1206211389


##########
src/core/CLucene/store/FSDirectory.cpp:
##########
@@ -241,6 +242,12 @@ void FSDirectory::FSIndexInput::readInternal(uint8_t* b, const int32_t len) {
 	CND_PRECONDITION(handle->fhandle>=0,"file is not open");
 	SCOPED_LOCK_MUTEX(*handle->SHARED_LOCK)
 
+	// todo: The file pointer may be wrong
+	int64_t position = getFilePointer();
+	if (_pos != position) {
+		_pos = position;
+	}
+

Review Comment:
   need to sync this code to CompoundDirectory in Doris



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org


[GitHub] [doris-thirdparty] qidaye merged pull request #74: [Feature] add postion and freq support for phrase query

Posted by "qidaye (via GitHub)" <gi...@apache.org>.
qidaye merged PR #74:
URL: https://github.com/apache/doris-thirdparty/pull/74


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org