[GitHub] [hudi] nsivabalan commented on a change in pull request #5013: [HUDI-3593] Restore TypedProperties and flush checksum in table config

[GitBox <gi...@apache.org>]

nsivabalan commented on a change in pull request #5013:
URL: https://github.com/apache/hudi/pull/5013#discussion_r824008232



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
##########
@@ -233,6 +235,23 @@ public HoodieTableConfig(FileSystem fs, String metaPath, String payloadClassName
         "hoodie.properties file seems invalid. Please check for left over `.updated` files if any, manually copy it to hoodie.properties and retry");
   }
 
+  private static Properties getOrderedPropertiesWithTableChecksum(Properties props) {
+    LinkedHashMap<String, String> propsMap = getOrderedPropertiesMap(props);
+    propsMap.put(TABLE_CHECKSUM.key(), String.valueOf(generateChecksum(props)));
+    Properties orderedProps = new Properties();

Review comment:
       +1 internally this is just a hashtable right. so ordering is not guaranteed. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org