You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2014/03/27 14:39:16 UTC

svn commit: r1582298 - in /commons/proper/proxy/trunk/core/src/main/java/org/apache/commons/proxy2: invoker/recorder/InvocationRecorder.java stub/TrainingContext.java

Author: sebb
Date: Thu Mar 27 13:39:16 2014
New Revision: 1582298

URL: http://svn.apache.org/r1582298
Log:
Immutable private field might as well be final

Modified:
    commons/proper/proxy/trunk/core/src/main/java/org/apache/commons/proxy2/invoker/recorder/InvocationRecorder.java
    commons/proper/proxy/trunk/core/src/main/java/org/apache/commons/proxy2/stub/TrainingContext.java

Modified: commons/proper/proxy/trunk/core/src/main/java/org/apache/commons/proxy2/invoker/recorder/InvocationRecorder.java
URL: http://svn.apache.org/viewvc/commons/proper/proxy/trunk/core/src/main/java/org/apache/commons/proxy2/invoker/recorder/InvocationRecorder.java?rev=1582298&r1=1582297&r2=1582298&view=diff
==============================================================================
--- commons/proper/proxy/trunk/core/src/main/java/org/apache/commons/proxy2/invoker/recorder/InvocationRecorder.java (original)
+++ commons/proper/proxy/trunk/core/src/main/java/org/apache/commons/proxy2/invoker/recorder/InvocationRecorder.java Thu Mar 27 13:39:16 2014
@@ -36,7 +36,7 @@ import org.apache.commons.proxy2.invoker
 public class InvocationRecorder
 {
     private final ProxyFactory proxyFactory;
-    private List<RecordedInvocation> recordedInvocations = new LinkedList<RecordedInvocation>();
+    private final List<RecordedInvocation> recordedInvocations = new LinkedList<RecordedInvocation>();
 
     /**
      * Create a new InvocationRecorder instance.

Modified: commons/proper/proxy/trunk/core/src/main/java/org/apache/commons/proxy2/stub/TrainingContext.java
URL: http://svn.apache.org/viewvc/commons/proper/proxy/trunk/core/src/main/java/org/apache/commons/proxy2/stub/TrainingContext.java?rev=1582298&r1=1582297&r2=1582298&view=diff
==============================================================================
--- commons/proper/proxy/trunk/core/src/main/java/org/apache/commons/proxy2/stub/TrainingContext.java (original)
+++ commons/proper/proxy/trunk/core/src/main/java/org/apache/commons/proxy2/stub/TrainingContext.java Thu Mar 27 13:39:16 2014
@@ -46,7 +46,7 @@ class TrainingContext
 
     private final ProxyFactory proxyFactory;
 
-    private Deque<TrainingContextFrame<?>> frameDeque = new LinkedList<TrainingContextFrame<?>>();
+    private final Deque<TrainingContextFrame<?>> frameDeque = new LinkedList<TrainingContextFrame<?>>();
 
     private final TrainingContext resume;