You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/05/23 05:17:32 UTC
[GitHub] [thrift] taiyangc opened a new pull request #2154: THRIFT-5195: Handle Thrift union type sending for Swift
taiyangc opened a new pull request #2154:
URL: https://github.com/apache/thrift/pull/2154
<!-- Explain the changes in the pull request below: -->
Swift should handle union type (enum) correctly when packing into a
struct type for sending.
Note that union types are essentially structs with all optionals, so a specific check on the enum parent type is needed to expose the correct union choice/enum during Mirror reflection.
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G closed pull request #2154: THRIFT-5195: Handle Thrift union type sending for Swift
Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2154:
URL: https://github.com/apache/thrift/pull/2154
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org