You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ki...@apache.org on 2021/01/09 20:19:08 UTC
svn commit: r1885318 [1/3] - in
/poi/trunk/src/ooxml/testcases/org/apache/poi: extractor/ooxml/ ooxml/
ooxml/lite/ openxml4j/opc/ openxml4j/opc/compliance/
openxml4j/opc/internal/ openxml4j/opc/internal/marshallers/
poifs/crypt/dsig/ poifs/crypt/tests/...
Author: kiwiwings
Date: Sat Jan 9 20:19:07 2021
New Revision: 1885318
URL: http://svn.apache.org/viewvc?rev=1885318&view=rev
Log:
Sonar fixes
JUnit5 test classes and methods should have default package visibility
Modified:
poi/trunk/src/ooxml/testcases/org/apache/poi/extractor/ooxml/TestExtractorFactory.java
poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestPOIXMLDocument.java
poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestPOIXMLProperties.java
poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/lite/OOXMLLiteAgent.java
poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestListParts.java
poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackage.java
poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCCompliancePackageModel.java
poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/internal/TestContentTypeManager.java
poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/internal/marshallers/TestZipPackagePropertiesMarshaller.java
poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/dsig/TestSignatureInfo.java
poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestDecryptor.java
poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestEncryptor.java
poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestHxxFEncryption.java
poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestSecureTempZip.java
poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestFonts.java
poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestHeadersFooters.java
poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestOleShape.java
poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestSlide.java
poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestTable.java
poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/extractor/TestEmbeddedExtractor.java
poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/CountifsTests.java
poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestVlookup.java
poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/ConditionalFormattingEvalTest.java
poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/TestEmbedOLEPackage.java
poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/TestXSSFRangeCopier.java
poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/util/TestXSSFPropertyTemplate.java
poi/trunk/src/ooxml/testcases/org/apache/poi/util/tests/TestTempFileThreaded.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFChartExtensionList.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFChartRemoveSeries.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xdgf/extractor/TestXDGFVisioExtractor.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestXSLFBugs.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestXSLFSlideShow.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/extractor/TestXSLFPowerPointExtractor.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestPPTX2PNG.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXMLSlideShow.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFExamples.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFHyperlink.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFNotes.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFPictureShape.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFShapeContainer.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTable.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTableRow.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTextShape.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestSheetProtection.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestWorkbookProtection.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestXSSFCloneSheet.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/XSSFMemoryLeakTests.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/eventusermodel/TestXSSFBReader.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/extractor/TestXSSFEventBasedExcelExtractorUsingFactory.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/extractor/TestXSSFExcelExtractorUsingFactory.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/model/TestCommentsTable.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/model/TestExternalLinksTable.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/model/TestStylesTable.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/model/TestThemesTable.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/streaming/TestAutoSizeColumnTracker.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/streaming/TestDeferredSXSSFWorkbook.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/streaming/TestSXSSFCell.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/streaming/TestSXSSFEvaluationSheet.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/streaming/TestSXSSFHyperlink.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/streaming/TestSXSSFRow.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/streaming/TestSXSSFSheet.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/streaming/TestSXSSFSheetAutoSizeColumn.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/streaming/TestSXSSFWorkbook.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/streaming/TestSXSSFWorkbookWithCustomZipEntrySource.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/BaseTestXSSFPivotTable.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestFormulaEvaluatorOnXSSF.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestMatrixFormulasFromXMLSpreadsheet.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestMultiSheetFormulaEvaluatorOnXSSF.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestSXSSFBugs.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestUnfixedBugs.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFCell.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFCellStyle.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFComment.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFDataValidationConstraint.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFDrawing.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFEvenFooter.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFEvenHeader.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFirstFooter.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFirstHeader.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFormulaEvaluation.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFormulaParser.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFHeaderFooterProperties.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFOddFooter.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFOddHeader.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFPicture.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFPivotTableName.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFPivotTableRef.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheet.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheetShiftRows.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheetShiftRowsAndColumns.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFTable.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFVMLDrawing.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFWorkbook.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/charts/TestXDDFManualLayout.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/charts/TestXSSFChartAxis.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/extensions/TestXSSFHeaderFooter.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/extensions/XSSFCellBorderTest.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/TestDocumentProtection.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/TestXWPFBugs.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/extractor/TestXWPFWordExtractor.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/model/TestXWPFDecorators.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/model/TestXWPFHeaderFooterPolicy.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestChangeTracking.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFBugs.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFEndnote.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFFootnote.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFHeader.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/TestXWPFRun.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xwpf/usermodel/XWPFAbstractNumTest.java
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/extractor/ooxml/TestExtractorFactory.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/extractor/ooxml/TestExtractorFactory.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/extractor/ooxml/TestExtractorFactory.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/extractor/ooxml/TestExtractorFactory.java Sat Jan 9 20:19:07 2021
@@ -429,7 +429,7 @@ public class TestExtractorFactory {
* "No supported documents found in the OLE2 stream"
*/
@Test
- public void bug59074() throws Exception {
+ void bug59074() throws Exception {
try (POITextExtractor extractor = ex("59074.xls")) {
String text = extractor.getText();
assertContains(text, "Exotic warrant");
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestPOIXMLDocument.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestPOIXMLDocument.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestPOIXMLDocument.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestPOIXMLDocument.java Sat Jan 9 20:19:07 2021
@@ -74,7 +74,7 @@ public final class TestPOIXMLDocument {
throw new RuntimeException("not supported");
}
- public void parse(POIXMLFactory factory) throws IOException{
+ void parse(POIXMLFactory factory) throws IOException{
load(factory);
}
}
@@ -285,7 +285,7 @@ public final class TestPOIXMLDocument {
}
@Test
- public void dontParseEmbeddedDocuments() throws IOException {
+ void dontParseEmbeddedDocuments() throws IOException {
// bug #62513
POIDataSamples pds = POIDataSamples.getSlideShowInstance();
try (InputStream is = pds.openResourceAsStream("bug62513.pptx");
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestPOIXMLProperties.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestPOIXMLProperties.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestPOIXMLProperties.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestPOIXMLProperties.java Sat Jan 9 20:19:07 2021
@@ -55,7 +55,7 @@ public final class TestPOIXMLProperties
private CoreProperties _coreProperties;
@BeforeEach
- public void setUp() throws IOException {
+ void setUp() throws IOException {
sampleDoc = XWPFTestDataSamples.openSampleDocument("documentProperties.docx");
sampleNoThumb = XWPFTestDataSamples.openSampleDocument("SampleDoc.docx");
assertNotNull(sampleDoc);
@@ -66,7 +66,7 @@ public final class TestPOIXMLProperties
}
@AfterEach
- public void closeResources() throws Exception {
+ void closeResources() throws Exception {
sampleDoc.close();
sampleNoThumb.close();
}
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/lite/OOXMLLiteAgent.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/lite/OOXMLLiteAgent.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/lite/OOXMLLiteAgent.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/lite/OOXMLLiteAgent.java Sat Jan 9 20:19:07 2021
@@ -105,11 +105,11 @@ public class OOXMLLiteAgent {
Pattern includes;
final Set<Integer> hashes = new HashSet<>();
- public void setPattern(String regex) {
+ void setPattern(String regex) {
includes = Pattern.compile(regex);
}
- public void load(String path) throws IOException {
+ void load(String path) throws IOException {
this.logPath = Paths.get(path);
if (Files.exists(this.logPath)) {
try (Stream<String> stream = Files.lines(this.logPath)) {
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestListParts.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestListParts.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestListParts.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestListParts.java Sat Jan 9 20:19:07 2021
@@ -39,7 +39,7 @@ public final class TestListParts {
private TreeMap<PackagePartName, String> values;
@BeforeEach
- public void setUp() throws Exception {
+ void setUp() throws Exception {
values = new TreeMap<>();
// Expected values
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackage.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackage.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackage.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestPackage.java Sat Jan 9 20:19:07 2021
@@ -107,7 +107,7 @@ public final class TestPackage {
* Test that just opening and closing the file doesn't alter the document.
*/
@Test
- public void openSave() throws IOException, InvalidFormatException {
+ void openSave() throws IOException, InvalidFormatException {
String originalFile = getSampleFileName("TestPackageCommon.docx");
File targetFile = getOutputFile("TestPackageOpenSaveTMP.docx");
@@ -131,7 +131,7 @@ public final class TestPackage {
* the correct default content types
*/
@Test
- public void createGetsContentTypes()
+ void createGetsContentTypes()
throws IOException, InvalidFormatException, SecurityException, IllegalArgumentException {
File targetFile = getOutputFile("TestCreatePackageTMP.docx");
@@ -157,7 +157,7 @@ public final class TestPackage {
* Test package creation.
*/
@Test
- public void createPackageAddPart() throws IOException, InvalidFormatException {
+ void createPackageAddPart() throws IOException, InvalidFormatException {
File targetFile = getOutputFile("TestCreatePackageTMP.docx");
File expectedFile = getSampleFile("TestCreatePackageOUTPUT.docx");
@@ -202,7 +202,7 @@ public final class TestPackage {
* have everything setup as expected
*/
@Test
- public void createPackageWithCoreDocument() throws IOException, InvalidFormatException, URISyntaxException, SAXException {
+ void createPackageWithCoreDocument() throws IOException, InvalidFormatException, URISyntaxException, SAXException {
ByteArrayOutputStream baos = new ByteArrayOutputStream();
try (OPCPackage pkg = OPCPackage.create(baos)) {
@@ -296,7 +296,7 @@ public final class TestPackage {
* Test package opening.
*/
@Test
- public void openPackage() throws IOException, InvalidFormatException {
+ void openPackage() throws IOException, InvalidFormatException {
File targetFile = getOutputFile("TestOpenPackageTMP.docx");
File inputFile = getSampleFile("TestOpenPackageINPUT.docx");
@@ -351,7 +351,7 @@ public final class TestPackage {
* to a file
*/
@Test
- public void saveToOutputStream() throws IOException, InvalidFormatException {
+ void saveToOutputStream() throws IOException, InvalidFormatException {
String originalFile = getSampleFileName("TestPackageCommon.docx");
File targetFile = getOutputFile("TestPackageOpenSaveTMP.docx");
@@ -378,7 +378,7 @@ public final class TestPackage {
* reading from a file
*/
@Test
- public void openFromInputStream() throws IOException, InvalidFormatException {
+ void openFromInputStream() throws IOException, InvalidFormatException {
String originalFile = getSampleFileName("TestPackageCommon.docx");
try (FileInputStream finp = new FileInputStream(originalFile);
@@ -402,7 +402,7 @@ public final class TestPackage {
*/
@Test
@Disabled
- public void removePartRecursive() throws IOException, InvalidFormatException, URISyntaxException {
+ void removePartRecursive() throws IOException, InvalidFormatException, URISyntaxException {
String originalFile = getSampleFileName("TestPackageCommon.docx");
File targetFile = getOutputFile("TestPackageRemovePartRecursiveOUTPUT.docx");
File tempFile = getOutputFile("TestPackageRemovePartRecursiveTMP.docx");
@@ -420,7 +420,7 @@ public final class TestPackage {
}
@Test
- public void deletePart() throws InvalidFormatException, IOException {
+ void deletePart() throws InvalidFormatException, IOException {
final TreeMap<PackagePartName, String> expectedValues = new TreeMap<>();
final TreeMap<PackagePartName, String> values = new TreeMap<>();
@@ -460,7 +460,7 @@ public final class TestPackage {
}
@Test
- public void deletePartRecursive() throws InvalidFormatException, IOException {
+ void deletePartRecursive() throws InvalidFormatException, IOException {
final TreeMap<PackagePartName, String> expectedValues = new TreeMap<>();
final TreeMap<PackagePartName, String> values = new TreeMap<>();
@@ -498,7 +498,7 @@ public final class TestPackage {
* write changes to it.
*/
@Test
- public void openFileThenOverwrite() throws IOException, InvalidFormatException {
+ void openFileThenOverwrite() throws IOException, InvalidFormatException {
File tempFile = TempFile.createTempFile("poiTesting","tmp");
File origFile = getSampleFile("TestPackageCommon.docx");
FileHelper.copyFile(origFile, tempFile);
@@ -534,7 +534,7 @@ public final class TestPackage {
* to another file, then delete both
*/
@Test
- public void openFileThenSaveDelete() throws IOException, InvalidFormatException {
+ void openFileThenSaveDelete() throws IOException, InvalidFormatException {
File tempFile = TempFile.createTempFile("poiTesting","tmp");
File tempFile2 = TempFile.createTempFile("poiTesting","tmp");
File origFile = getSampleFile("TestPackageCommon.docx");
@@ -556,7 +556,7 @@ public final class TestPackage {
}
@Test
- public void getPartsByName() throws InvalidFormatException, IOException {
+ void getPartsByName() throws InvalidFormatException, IOException {
String filepath = getSampleFileName("sample.docx");
try (OPCPackage pkg = OPCPackage.open(filepath, PackageAccess.READ_WRITE)) {
@@ -582,7 +582,7 @@ public final class TestPackage {
}
@Test
- public void getPartSize() throws IOException, InvalidFormatException {
+ void getPartSize() throws IOException, InvalidFormatException {
String filepath = getSampleFileName("sample.docx");
try (OPCPackage pkg = OPCPackage.open(filepath, PackageAccess.READ)) {
int checked = 0;
@@ -612,7 +612,7 @@ public final class TestPackage {
}
@Test
- public void replaceContentType() throws IOException, InvalidFormatException {
+ void replaceContentType() throws IOException, InvalidFormatException {
try (InputStream is = openSampleStream("sample.xlsx");
OPCPackage p = OPCPackage.open(is)) {
try {
@@ -638,7 +638,7 @@ public final class TestPackage {
"SampleSS.ods, org.apache.poi.openxml4j.exceptions.ODFNotOfficeXmlFileException, The supplied data appears to be in ODF, Formats like these (eg ODS",
"SampleSS.txt, org.apache.poi.openxml4j.exceptions.NotOfficeXmlFileException, No valid entries or contents found, not a valid OOXML"
})
- public void NonOOXML_File(String file, String exClazzStr, String msg1, String msg2) throws Exception {
+ void NonOOXML_File(String file, String exClazzStr, String msg1, String msg2) throws Exception {
Class<? extends Exception> exClazz = (Class<? extends Exception>)Class.forName(exClazzStr);
try (InputStream stream = xlsSamples.openResourceAsStream(file)) {
@@ -659,7 +659,7 @@ public final class TestPackage {
* see bug #50090 / #56865
*/
@Test
- public void zipBombCreateAndHandle()
+ void zipBombCreateAndHandle()
throws IOException, EncryptedDocumentException {
ByteArrayOutputStream bos = new ByteArrayOutputStream(2500000);
@@ -777,7 +777,7 @@ public final class TestPackage {
}
@Test
- public void zipBombCheckSizesWithinLimits() throws IOException, EncryptedDocumentException {
+ void zipBombCheckSizesWithinLimits() throws IOException, EncryptedDocumentException {
getZipStatsAndConsume((max_size, min_ratio) -> {
// use values close to, but within the limits
ZipSecureFile.setMinInflateRatio(min_ratio - 0.002);
@@ -788,7 +788,7 @@ public final class TestPackage {
}
@Test
- public void zipBombCheckSizesRatioTooSmall() {
+ void zipBombCheckSizesRatioTooSmall() {
POIXMLException ex = assertThrows(
POIXMLException.class,
() -> getZipStatsAndConsume((max_size, min_ratio) -> {
@@ -800,7 +800,7 @@ public final class TestPackage {
}
@Test
- public void zipBombCheckSizesSizeTooBig() throws EncryptedDocumentException {
+ void zipBombCheckSizesSizeTooBig() throws EncryptedDocumentException {
POIXMLException ex = assertThrows(
POIXMLException.class,
() -> getZipStatsAndConsume((max_size, min_ratio) -> {
@@ -924,7 +924,7 @@ public final class TestPackage {
}
@Test
- public void unparseableCentralDirectory() throws IOException {
+ void unparseableCentralDirectory() throws IOException {
File f = getSampleFile("at.pzp.www_uploads_media_PP_Scheinecker-jdk6error.pptx");
try (SlideShow<?,?> ppt = SlideShowFactory.create(f, null, true)) {
assertNotNull(ppt);
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCCompliancePackageModel.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCCompliancePackageModel.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCCompliancePackageModel.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/compliance/TestOPCCompliancePackageModel.java Sat Jan 9 20:19:07 2021
@@ -54,7 +54,7 @@ public class TestOPCCompliancePackageMod
}
@BeforeEach
- public void tearDown() {
+ void tearDown() {
if (TESTFILE.exists()) {
assertTrue(TESTFILE.delete());
}
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/internal/TestContentTypeManager.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/internal/TestContentTypeManager.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/internal/TestContentTypeManager.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/internal/TestContentTypeManager.java Sat Jan 9 20:19:07 2021
@@ -142,7 +142,7 @@ public final class TestContentTypeManage
}
@Test
- public void bug62629CombinePictures() throws Exception {
+ void bug62629CombinePictures() throws Exception {
// this file has incorrect default content-types which caused problems in Apache POI
// we now handle this broken file more gracefully
XSSFWorkbook book = XSSFTestDataSamples.openSampleWorkbook("62629_target.xlsm");
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/internal/marshallers/TestZipPackagePropertiesMarshaller.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/internal/marshallers/TestZipPackagePropertiesMarshaller.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/internal/marshallers/TestZipPackagePropertiesMarshaller.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/internal/marshallers/TestZipPackagePropertiesMarshaller.java Sat Jan 9 20:19:07 2021
@@ -49,18 +49,18 @@ public class TestZipPackagePropertiesMar
@Test
- public void nonZipOutputStream() {
+ void nonZipOutputStream() {
OutputStream notAZipOutputStream = new ByteArrayOutputStream(0);
assertThrows(IllegalArgumentException.class, () -> marshall(notAZipOutputStream));
}
@Test
- public void withZipOutputStream() throws Exception {
+ void withZipOutputStream() throws Exception {
assertTrue(marshall());
}
@Test
- public void ioException() throws Exception {
+ void ioException() {
ZipArchiveOutputStream zos = new ZipArchiveOutputStream(new ByteArrayOutputStream()) {
@Override
public void putArchiveEntry(final ArchiveEntry archiveEntry) throws IOException {
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/dsig/TestSignatureInfo.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/dsig/TestSignatureInfo.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/dsig/TestSignatureInfo.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/dsig/TestSignatureInfo.java Sat Jan 9 20:19:07 2021
@@ -200,7 +200,7 @@ public class TestSignatureInfo {
@Disabled("This test is very sensitive, it breaks with every little change to the produced XML")
@Test
- public void bug61182() throws Exception {
+ void bug61182() throws Exception {
final String pfxInput =
"H4sIAAAAAAAAAFXTfzzTeRwH8P2uGRmG6hKSmJh9a2HsuPy60VnHCEU6v86sieZH2Jr2qFl+s+ZHJ5tfUcfKb4uho/OjiFq1qTv5ceFyp0PqEK"+
"fH4+66++Pz+Dwer9fj8f7r9cRzEd4QMBTPRWxDIM14ZN47NfAWsJgL34Bx4at4Lvwdngvd9b8KqgbjQpGbMXzzgRGovytVFTBEzIXU47kQCd4U"+
@@ -287,7 +287,7 @@ public class TestSignatureInfo {
}
@Test
- public void office2007prettyPrintedRels() throws Exception {
+ void office2007prettyPrintedRels() throws Exception {
try (OPCPackage pkg = OPCPackage.open(testdata.getFile("office2007prettyPrintedRels.docx"), PackageAccess.READ)) {
SignatureConfig sic = new SignatureConfig();
SignatureInfo si = new SignatureInfo();
@@ -299,7 +299,7 @@ public class TestSignatureInfo {
}
@Test
- public void getSignerUnsigned() throws Exception {
+ void getSignerUnsigned() throws Exception {
String[] testFiles = {
"hello-world-unsigned.docx",
"hello-world-unsigned.pptx",
@@ -327,7 +327,7 @@ public class TestSignatureInfo {
}
@Test
- public void getSigner() throws Exception {
+ void getSigner() throws Exception {
String[] testFiles = {
"hyperlink-example-signed.docx",
"hello-world-signed.docx",
@@ -367,7 +367,7 @@ public class TestSignatureInfo {
}
@Test
- public void getMultiSigners() throws Exception {
+ void getMultiSigners() throws Exception {
String testFile = "hello-world-signed-twice.docx";
try (OPCPackage pkg = OPCPackage.open(testdata.getFile(testFile), PackageAccess.READ)) {
SignatureConfig sic = new SignatureConfig();
@@ -739,7 +739,7 @@ public class TestSignatureInfo {
}
@Test
- public void bug58630() throws Exception {
+ void bug58630() throws Exception {
// test deletion of sheet 0 and signing
File tpl = copy(testdata.getFile("bug58630.xlsx"));
try (SXSSFWorkbook wb1 = new SXSSFWorkbook((XSSFWorkbook)WorkbookFactory.create(tpl), 10)) {
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestDecryptor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestDecryptor.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestDecryptor.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestDecryptor.java Sat Jan 9 20:19:07 2021
@@ -44,7 +44,7 @@ public class TestDecryptor {
private static final POIDataSamples samples = POIDataSamples.getPOIFSInstance();
@Test
- public void passwordVerification() throws IOException, GeneralSecurityException {
+ void passwordVerification() throws IOException, GeneralSecurityException {
try (InputStream is = samples.openResourceAsStream("protect.xlsx");
POIFSFileSystem fs = new POIFSFileSystem(is)) {
EncryptionInfo info = new EncryptionInfo(fs);
@@ -54,7 +54,7 @@ public class TestDecryptor {
}
@Test
- public void decrypt() throws IOException, GeneralSecurityException {
+ void decrypt() throws IOException, GeneralSecurityException {
try (InputStream is = samples.openResourceAsStream("protect.xlsx");
POIFSFileSystem fs = new POIFSFileSystem(is)) {
EncryptionInfo info = new EncryptionInfo(fs);
@@ -65,7 +65,7 @@ public class TestDecryptor {
}
@Test
- public void agile() throws IOException, GeneralSecurityException {
+ void agile() throws IOException, GeneralSecurityException {
try (InputStream is = samples.openResourceAsStream("protected_agile.docx");
POIFSFileSystem fs = new POIFSFileSystem(is)) {
EncryptionInfo info = new EncryptionInfo(fs);
@@ -98,7 +98,7 @@ public class TestDecryptor {
}
@Test
- public void dataLength() throws Exception {
+ void dataLength() throws Exception {
try (InputStream fsIs = samples.openResourceAsStream("protected_agile.docx");
POIFSFileSystem fs = new POIFSFileSystem(fsIs)) {
EncryptionInfo info = new EncryptionInfo(fs);
@@ -128,7 +128,7 @@ public class TestDecryptor {
}
@Test
- public void bug57080() throws Exception {
+ void bug57080() throws Exception {
// the test file contains a wrong ole entry size, produced by extenxls
// the fix limits the available size and tries to read all entries
File f = samples.getFile("extenxls_pwd123.xlsx");
@@ -163,7 +163,7 @@ public class TestDecryptor {
}
@Test
- public void bug60320() throws IOException, GeneralSecurityException {
+ void bug60320() throws IOException, GeneralSecurityException {
int maxKeyLen = Cipher.getMaxAllowedKeyLength("AES");
assumeTrue(maxKeyLen == 0x7FFFFFFF, "Please install JCE Unlimited Strength Jurisdiction Policy files for AES 256");
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestEncryptor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestEncryptor.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestEncryptor.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestEncryptor.java Sat Jan 9 20:19:07 2021
@@ -68,7 +68,7 @@ import org.junit.jupiter.api.Test;
public class TestEncryptor {
@Test
- public void binaryRC4Encryption() throws Exception {
+ void binaryRC4Encryption() throws Exception {
// please contribute a real sample file, which is binary rc4 encrypted
// ... at least the output can be opened in Excel Viewer
String password = "pass";
@@ -107,7 +107,7 @@ public class TestEncryptor {
}
@Test
- public void tempFileAgileEncryption() throws Exception {
+ void tempFileAgileEncryption() throws Exception {
String password = "pass";
final byte[] payloadExpected;
@@ -144,7 +144,7 @@ public class TestEncryptor {
}
@Test
- public void agileEncryption() throws Exception {
+ void agileEncryption() throws Exception {
int maxKeyLen = Cipher.getMaxAllowedKeyLength("AES");
assumeTrue(maxKeyLen == 0x7FFFFFFF, "Please install JCE Unlimited Strength Jurisdiction Policy files for AES 256");
@@ -243,7 +243,7 @@ public class TestEncryptor {
}
@Test
- public void standardEncryption() throws Exception {
+ void standardEncryption() throws Exception {
File file = POIDataSamples.getDocumentInstance().getFile("bug53475-password-is-solrcell.docx");
final String pass = "solrcell";
@@ -334,7 +334,7 @@ public class TestEncryptor {
* http://stackoverflow.com/questions/28593223
*/
@Test
- public void encryptPackageWithoutCoreProperties() throws Exception {
+ void encryptPackageWithoutCoreProperties() throws Exception {
// Open our file without core properties
final byte[] encBytes;
try (InputStream is = POIDataSamples.getOpenXML4JInstance().openResourceAsStream("OPCCompliance_NoCoreProperties.xlsx");
@@ -384,7 +384,7 @@ public class TestEncryptor {
@Test
@Disabled
- public void inPlaceRewrite() throws Exception {
+ void inPlaceRewrite() throws Exception {
File f = TempFile.createTempFile("protected_agile", ".docx");
try (FileOutputStream fos = new FileOutputStream(f);
@@ -460,7 +460,7 @@ public class TestEncryptor {
* the default way of defining the encryption settings is via the EncryptionInfo class
*/
@Test
- public void bug60320CustomEncrypt() throws Exception {
+ void bug60320CustomEncrypt() throws Exception {
int maxKeyLen = Cipher.getMaxAllowedKeyLength("AES");
assumeTrue(maxKeyLen == 0x7FFFFFFF, "Please install JCE Unlimited Strength Jurisdiction Policy files for AES 256");
@@ -594,7 +594,7 @@ public class TestEncryptor {
}
@Test
- public void smallFile() throws IOException, GeneralSecurityException {
+ void smallFile() throws IOException, GeneralSecurityException {
// see https://stackoverflow.com/questions/61463301
final int tinyFileSize = 80_000_000;
final String pass = "s3cr3t";
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestHxxFEncryption.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestHxxFEncryption.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestHxxFEncryption.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestHxxFEncryption.java Sat Jan 9 20:19:07 2021
@@ -73,7 +73,7 @@ public class TestHxxFEncryption {
@ParameterizedTest
@MethodSource("data")
- public void extract(POIDataSamples sampleDir, String file, String password, String expected) throws IOException {
+ void extract(POIDataSamples sampleDir, String file, String password, String expected) throws IOException {
File f = sampleDir.getFile(file);
Biff8EncryptionKey.setCurrentUserPassword(password);
try (POITextExtractor te = ExtractorFactory.createExtractor(f)) {
@@ -86,13 +86,13 @@ public class TestHxxFEncryption {
@ParameterizedTest
@MethodSource("data")
- public void changePassword(POIDataSamples sampleDir, String file, String password, String expected) throws IOException {
+ void changePassword(POIDataSamples sampleDir, String file, String password, String expected) throws IOException {
newPassword("test", sampleDir, file, password, expected);
}
@ParameterizedTest
@MethodSource("data")
- public void removePassword(POIDataSamples sampleDir, String file, String password, String expected) throws IOException {
+ void removePassword(POIDataSamples sampleDir, String file, String password, String expected) throws IOException {
newPassword(null, sampleDir, file, password, expected);
}
@@ -118,7 +118,7 @@ public class TestHxxFEncryption {
/** changing the encryption mode and key size in poor mans style - see comments below */
@ParameterizedTest
@MethodSource("data")
- public void changeEncryption(POIDataSamples sampleDir, String file, String password, String expected) throws IOException {
+ void changeEncryption(POIDataSamples sampleDir, String file, String password, String expected) throws IOException {
File f = sampleDir.getFile(file);
ByteArrayOutputStream bos = new ByteArrayOutputStream();
Biff8EncryptionKey.setCurrentUserPassword(password);
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestSecureTempZip.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestSecureTempZip.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestSecureTempZip.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/tests/TestSecureTempZip.java Sat Jan 9 20:19:07 2021
@@ -50,7 +50,7 @@ public class TestSecureTempZip {
* which are streamed into POI opposed to having everything in memory
*/
@Test
- public void protectedTempZip() throws IOException, GeneralSecurityException, XmlException, OpenXML4JException {
+ void protectedTempZip() throws IOException, GeneralSecurityException, XmlException, OpenXML4JException {
File tikaProt = XSSFTestDataSamples.getSampleFile("protected_passtika.xlsx");
FileInputStream fis = new FileInputStream(tikaProt);
POIFSFileSystem poifs = new POIFSFileSystem(fis);
@@ -91,7 +91,7 @@ public class TestSecureTempZip {
* Now try with xlsb.
*/
@Test
- public void protectedXLSBZip() throws IOException, GeneralSecurityException, XmlException, OpenXML4JException {
+ void protectedXLSBZip() throws IOException, GeneralSecurityException, XmlException, OpenXML4JException {
//The test file requires that JCE unlimited be installed.
//If it isn't installed, skip this test.
int maxKeyLen = Cipher.getMaxAllowedKeyLength("AES");
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestFonts.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestFonts.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestFonts.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestFonts.java Sat Jan 9 20:19:07 2021
@@ -79,7 +79,7 @@ public class TestFonts {
}
@Test
- public void resizeToFitTextHSLF() throws IOException {
+ void resizeToFitTextHSLF() throws IOException {
assumeFalse(xslfOnly());
SlideShow<?,?> ppt = SlideShowFactory.create(false);
resizeToFitText(ppt);
@@ -87,7 +87,7 @@ public class TestFonts {
}
@Test
- public void resizeToFitTextXSLF() throws IOException {
+ void resizeToFitTextXSLF() throws IOException {
SlideShow<?,?> ppt = new XMLSlideShow();
resizeToFitText(ppt);
ppt.close();
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestHeadersFooters.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestHeadersFooters.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestHeadersFooters.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestHeadersFooters.java Sat Jan 9 20:19:07 2021
@@ -35,7 +35,7 @@ import org.junit.jupiter.api.Test;
public class TestHeadersFooters {
@Test
- public void bug58144c() throws IOException {
+ void bug58144c() throws IOException {
SlideShow<?,?> ppt = openSampleSlideshow("bug58144-headers-footers-2007.pptx");
testSlideShow(ppt);
ppt.close();
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestOleShape.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestOleShape.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestOleShape.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestOleShape.java Sat Jan 9 20:19:07 2021
@@ -113,7 +113,7 @@ public class TestOleShape {
@ParameterizedTest
@MethodSource("data")
- public void embedData(Api api, ObjectMetaData.Application app) throws IOException, ReflectiveOperationException {
+ void embedData(Api api, ObjectMetaData.Application app) throws IOException, ReflectiveOperationException {
final ByteArrayInputStream pptBytes;
try (SlideShow<?,?> ppt = createSlideShow(api)) {
final PictureData picData = ppt.addPicture(pictureFile, PictureType.EMF);
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestSlide.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestSlide.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestSlide.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestSlide.java Sat Jan 9 20:19:07 2021
@@ -38,7 +38,7 @@ import org.junit.jupiter.api.Test;
public class TestSlide {
@Test
- public void hideHSLF() throws IOException {
+ void hideHSLF() throws IOException {
assumeFalse(xslfOnly());
try (SlideShow<?,?> ppt1 = SlideShowFactory.create(false)) {
hideSlide(ppt1);
@@ -46,7 +46,7 @@ public class TestSlide {
}
@Test
- public void hideXSLF() throws IOException {
+ void hideXSLF() throws IOException {
try (SlideShow<?,?> ppt1 = new XMLSlideShow()) {
hideSlide(ppt1);
}
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestTable.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestTable.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestTable.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/sl/tests/TestTable.java Sat Jan 9 20:19:07 2021
@@ -46,7 +46,7 @@ import org.junit.jupiter.api.Test;
public class TestTable {
@Test
- public void colWidthRowHeight() throws IOException {
+ void colWidthRowHeight() throws IOException {
assumeFalse(xslfOnly());
// Test of table dimensions of same slideshow saved as ppt/x
@@ -93,7 +93,7 @@ public class TestTable {
}
@Test
- public void directionHSLF() throws IOException {
+ void directionHSLF() throws IOException {
assumeFalse(xslfOnly());
SlideShow<?,?> ppt1 = SlideShowFactory.create(false);
testTextDirection(ppt1);
@@ -101,7 +101,7 @@ public class TestTable {
}
@Test
- public void directionXSLF() throws IOException {
+ void directionXSLF() throws IOException {
SlideShow<?,?> ppt1 = new XMLSlideShow();
testTextDirection(ppt1);
ppt1.close();
@@ -145,7 +145,7 @@ public class TestTable {
}
@Test
- public void tableSpan() throws IOException {
+ void tableSpan() throws IOException {
String[] files = (xslfOnly()) ? new String[]{"bug60993.pptx"} : new String[]{"bug60993.pptx", "bug60993.ppt"};
for (String f : files) {
SlideShow<?,?> ppt = openSampleSlideshow(f);
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/extractor/TestEmbeddedExtractor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/extractor/TestEmbeddedExtractor.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/extractor/TestEmbeddedExtractor.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/extractor/TestEmbeddedExtractor.java Sat Jan 9 20:19:07 2021
@@ -44,7 +44,7 @@ public class TestEmbeddedExtractor {
private static final POIDataSamples samples = POIDataSamples.getSpreadSheetInstance();
@Test
- public void extractPDFfromEMF() throws Exception {
+ void extractPDFfromEMF() throws Exception {
InputStream fis = samples.openResourceAsStream("Basic_Expense_Template_2011.xls");
Workbook wb = WorkbookFactory.create(fis);
fis.close();
@@ -72,7 +72,7 @@ public class TestEmbeddedExtractor {
}
@Test
- public void extractFromXSSF() throws IOException, EncryptedDocumentException, InvalidFormatException {
+ void extractFromXSSF() throws IOException, EncryptedDocumentException, InvalidFormatException {
InputStream fis = samples.openResourceAsStream("58325_db.xlsx");
Workbook wb = WorkbookFactory.create(fis);
fis.close();
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/CountifsTests.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/CountifsTests.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/CountifsTests.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/CountifsTests.java Sat Jan 9 20:19:07 2021
@@ -47,7 +47,7 @@ public class CountifsTests {
* initialize a workbook
*/
@BeforeEach
- public void before() {
+ void before() {
// not sure why we allow this, COUNTIFS() is only available
// in OOXML, it was introduced with Office 2007
workbook = new HSSFWorkbook();
@@ -57,7 +57,7 @@ public class CountifsTests {
* Close the workbook if needed
*/
@AfterEach
- public void after() {
+ void after() {
IOUtils.closeQuietly(workbook);
}
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestVlookup.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestVlookup.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestVlookup.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/formula/functions/TestVlookup.java Sat Jan 9 20:19:07 2021
@@ -52,7 +52,7 @@ public class TestVlookup {
}
@Test
- public void bug62275_true() throws IOException {
+ void bug62275_true() throws IOException {
try (Workbook wb = new XSSFWorkbook()) {
Sheet sheet = wb.createSheet();
Row row = sheet.createRow(0);
@@ -69,7 +69,7 @@ public class TestVlookup {
}
@Test
- public void bug62275_false() throws IOException {
+ void bug62275_false() throws IOException {
try (Workbook wb = new XSSFWorkbook()) {
Sheet sheet = wb.createSheet();
Row row = sheet.createRow(0);
@@ -86,7 +86,7 @@ public class TestVlookup {
}
@Test
- public void bug62275_empty_3args() throws IOException {
+ void bug62275_empty_3args() throws IOException {
try (Workbook wb = new XSSFWorkbook()) {
Sheet sheet = wb.createSheet();
Row row = sheet.createRow(0);
@@ -103,7 +103,7 @@ public class TestVlookup {
}
@Test
- public void bug62275_empty_2args() throws IOException {
+ void bug62275_empty_2args() throws IOException {
try (Workbook wb = new XSSFWorkbook()) {
Sheet sheet = wb.createSheet();
Row row = sheet.createRow(0);
@@ -120,7 +120,7 @@ public class TestVlookup {
}
@Test
- public void bug62275_empty_1arg() throws IOException {
+ void bug62275_empty_1arg() throws IOException {
try (Workbook wb = new XSSFWorkbook()) {
Sheet sheet = wb.createSheet();
Row row = sheet.createRow(0);
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/ConditionalFormattingEvalTest.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/ConditionalFormattingEvalTest.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/ConditionalFormattingEvalTest.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/ConditionalFormattingEvalTest.java Sat Jan 9 20:19:07 2021
@@ -50,14 +50,14 @@ public class ConditionalFormattingEvalTe
private List<EvaluationConditionalFormatRule> rules;
@BeforeEach
- public void openWB() {
+ void openWB() {
wb = XSSFTestDataSamples.openSampleWorkbook("ConditionalFormattingSamples.xlsx");
formulaEval = new XSSFFormulaEvaluator(wb);
cfe = new ConditionalFormattingEvaluator(wb, formulaEval);
}
@AfterEach
- public void closeWB() {
+ void closeWB() {
formulaEval = null;
cfe = null;
ref = null;
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/TestEmbedOLEPackage.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/TestEmbedOLEPackage.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/TestEmbedOLEPackage.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/TestEmbedOLEPackage.java Sat Jan 9 20:19:07 2021
@@ -78,7 +78,7 @@ public class TestEmbedOLEPackage {
}
@Test
- public void embedPDF() throws IOException {
+ void embedPDF() throws IOException {
try (InputStream is = ssamples.openResourceAsStream("bug64512_embed.xlsx");
XSSFWorkbook wb = new XSSFWorkbook(is)) {
List<XSSFObjectData> oleShapes = new ArrayList<>();
@@ -146,7 +146,7 @@ public class TestEmbedOLEPackage {
}
@Test
- public void embedXSSF() throws IOException {
+ void embedXSSF() throws IOException {
Workbook wb1 = new XSSFWorkbook();
addEmbeddedObjects(wb1);
@@ -158,7 +158,7 @@ public class TestEmbedOLEPackage {
}
@Test
- public void embedHSSF() throws IOException {
+ void embedHSSF() throws IOException {
assumeFalse(xslfOnly());
HSSFWorkbook wb1 = new HSSFWorkbook();
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/TestXSSFRangeCopier.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/TestXSSFRangeCopier.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/TestXSSFRangeCopier.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/usermodel/TestXSSFRangeCopier.java Sat Jan 9 20:19:07 2021
@@ -43,7 +43,7 @@ public class TestXSSFRangeCopier extends
}
@BeforeEach
- public void init() {
+ void init() {
workbook = XSSFTestDataSamples.openSampleWorkbook("tile-range-test.xlsx");
initSheets();
rangeCopier = new XSSFRangeCopier(sheet1, sheet1);
@@ -51,12 +51,12 @@ public class TestXSSFRangeCopier extends
}
@AfterEach
- public void shutdown() throws IOException {
+ void shutdown() throws IOException {
workbook.close();
}
@Test // XSSF only. HSSF version wouldn't be so simple. And also this test is contained in following, more complex tests, so it's not really important.
- public void copyRow() {
+ void copyRow() {
Row existingRow = sheet1.getRow(4);
XSSFRow newRow = (XSSFRow)sheet1.getRow(5);
CellCopyPolicy policy = new CellCopyPolicy();
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/util/TestXSSFPropertyTemplate.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/util/TestXSSFPropertyTemplate.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/util/TestXSSFPropertyTemplate.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/ss/tests/util/TestXSSFPropertyTemplate.java Sat Jan 9 20:19:07 2021
@@ -38,7 +38,7 @@ import org.junit.jupiter.api.Test;
public class TestXSSFPropertyTemplate {
@Test
- public void applyBorders() throws IOException {
+ void applyBorders() throws IOException {
CellRangeAddress a1c3 = new CellRangeAddress(0, 2, 0, 2);
CellRangeAddress b2 = new CellRangeAddress(1, 1, 1, 1);
PropertyTemplate pt = new PropertyTemplate();
@@ -99,7 +99,7 @@ public class TestXSSFPropertyTemplate {
}
@Test
- public void clonePropertyTemplate() throws IOException {
+ void clonePropertyTemplate() throws IOException {
CellRangeAddress a1c3 = new CellRangeAddress(0, 2, 0, 2);
PropertyTemplate pt = new PropertyTemplate();
pt.drawBorders(a1c3, BorderStyle.MEDIUM, IndexedColors.RED.getIndex(), BorderExtent.ALL);
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/util/tests/TestTempFileThreaded.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/util/tests/TestTempFileThreaded.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/util/tests/TestTempFileThreaded.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/util/tests/TestTempFileThreaded.java Sat Jan 9 20:19:07 2021
@@ -83,13 +83,13 @@ public class TestTempFileThreaded {
}
@BeforeEach
- public void setUp() {
+ void setUp() {
// Initialize array to allow to summarize afterwards
executions = new int[NUMBER_OF_THREADS];
}
@Test
- public void runTest() throws Throwable {
+ void runTest() throws Throwable {
List<Thread> threads = new LinkedList<>();
// start all threads
@@ -124,7 +124,7 @@ public class TestTempFileThreaded {
}
}
- public void doEnd(int threadNum) {
+ void doEnd(int threadNum) {
for (File file : files.get(threadNum)) {
if (!file.exists()) {
throw new IllegalStateException("File " + file + " does not exist");
@@ -135,7 +135,7 @@ public class TestTempFileThreaded {
}
}
- public void run(int threadNum, int iter) throws Exception {
+ void run(int threadNum, int iter) throws Exception {
try (SXSSFWorkbook wb = new SXSSFWorkbook()) {
SXSSFSheet sheet = wb.createSheet("test");
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFChartExtensionList.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFChartExtensionList.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFChartExtensionList.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFChartExtensionList.java Sat Jan 9 20:19:07 2021
@@ -24,7 +24,7 @@ import org.junit.jupiter.api.Test;
public class TestXDDFChartExtensionList {
@Test
- public void getXmlObject() {
+ void getXmlObject() {
// minimal test to include generated classes in poi-ooxml-lite
XDDFChartExtensionList list = new XDDFChartExtensionList();
assertNotNull(list.getXmlObject());
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFChartRemoveSeries.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFChartRemoveSeries.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFChartRemoveSeries.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xddf/usermodel/chart/TestXDDFChartRemoveSeries.java Sat Jan 9 20:19:07 2021
@@ -54,7 +54,7 @@ public class TestXDDFChartRemoveSeries {
* scatter chart.
*/
@BeforeEach
- public void setup() {
+ void setup() {
final boolean bDebug = false;
workbook = new XSSFWorkbook();
sheet = workbook.createSheet();
@@ -99,7 +99,7 @@ public class TestXDDFChartRemoveSeries {
* This method writes the workbook to resultDir/fileName.
*/
@AfterEach
- public void cleanup() {
+ void cleanup() {
if (workbook == null) {
System.out.println(String.format(Locale.ROOT, "%s: workbook==null", procName));
return;
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xdgf/extractor/TestXDGFVisioExtractor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xdgf/extractor/TestXDGFVisioExtractor.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xdgf/extractor/TestXDGFVisioExtractor.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xdgf/extractor/TestXDGFVisioExtractor.java Sat Jan 9 20:19:07 2021
@@ -36,13 +36,13 @@ public class TestXDGFVisioExtractor {
private XmlVisioDocument xml;
@BeforeEach
- public void setUp() throws Exception {
+ void setUp() throws Exception {
pkg = OPCPackage.open(SAMPLES.openResourceAsStream("test_text_extraction.vsdx"));
xml = new XmlVisioDocument(pkg);
}
@AfterEach
- public void closeResources() throws IOException {
+ void closeResources() throws IOException {
if(xml != null) {
xml.close();
}
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestXSLFBugs.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestXSLFBugs.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestXSLFBugs.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestXSLFBugs.java Sat Jan 9 20:19:07 2021
@@ -127,7 +127,7 @@ public class TestXSLFBugs {
}
@Test
- public void bug62929() throws Exception {
+ void bug62929() throws Exception {
try (XMLSlideShow ss1 = openSampleDocument("missing-blip-fill.pptx")) {
assertEquals(1, ss1.getSlides().size());
@@ -146,7 +146,7 @@ public class TestXSLFBugs {
}
@Test
- public void bug62736() throws Exception {
+ void bug62736() throws Exception {
XMLSlideShow ss1 = openSampleDocument("bug62736.pptx");
assertEquals(1, ss1.getSlides().size());
@@ -228,7 +228,7 @@ public class TestXSLFBugs {
}
@Test
- public void bug61589() throws IOException {
+ void bug61589() throws IOException {
ByteArrayOutputStream bos = new ByteArrayOutputStream();
try (XMLSlideShow src = new XMLSlideShow();
XMLSlideShow dest = new XMLSlideShow()) {
@@ -275,7 +275,7 @@ public class TestXSLFBugs {
}
@Test
- public void bug62587() throws IOException {
+ void bug62587() throws IOException {
ByteArrayOutputStream bos = new ByteArrayOutputStream();
try (XMLSlideShow ppt = new XMLSlideShow()) {
Slide<?, ?> slide = ppt.createSlide();
@@ -326,7 +326,7 @@ public class TestXSLFBugs {
@Test
- public void bug60499() throws IOException, InvalidFormatException {
+ void bug60499() throws IOException, InvalidFormatException {
InputStream is = slTests.openResourceAsStream("bug60499.pptx");
byte[] buf = IOUtils.toByteArray(is);
is.close();
@@ -370,7 +370,7 @@ public class TestXSLFBugs {
}
@Test
- public void bug51187() throws Exception {
+ void bug51187() throws Exception {
XMLSlideShow ss1 = openSampleDocument("51187.pptx");
assertEquals(1, ss1.getSlides().size());
@@ -411,7 +411,7 @@ public class TestXSLFBugs {
* Slide relations with anchors in them
*/
@Test
- public void tika705() throws Exception {
+ void tika705() throws Exception {
XMLSlideShow ss = openSampleDocument("with_japanese.pptx");
// Should have one slide
@@ -455,7 +455,7 @@ public class TestXSLFBugs {
* rID2 -> slide3.xml
*/
@Test
- public void bug54916() throws IOException {
+ void bug54916() throws IOException {
try (XMLSlideShow ss = openSampleDocument("OverlappingRelations.pptx")) {
XSLFSlide slide;
@@ -484,7 +484,7 @@ public class TestXSLFBugs {
* gives a NPE, see bug #56812
*/
@Test
- public void bug56812() throws Exception {
+ void bug56812() throws Exception {
XMLSlideShow ppt = openSampleDocument("56812.pptx");
int internalPictures = 0;
@@ -527,7 +527,7 @@ public class TestXSLFBugs {
}
@Test
- public void bug57250() throws Exception {
+ void bug57250() throws Exception {
XMLSlideShow ss = new XMLSlideShow();
for (String s : new String[]{"Slide1", "Slide2"}) {
ss.createSlide().createTextBox().setText(s);
@@ -677,7 +677,7 @@ public class TestXSLFBugs {
}
@Test
- public void bug58205() throws IOException {
+ void bug58205() throws IOException {
XMLSlideShow ss = openSampleDocument("themes.pptx");
int i = 1;
@@ -689,14 +689,14 @@ public class TestXSLFBugs {
}
@Test
- public void bug55791a() throws IOException {
+ void bug55791a() throws IOException {
XMLSlideShow ppt = openSampleDocument("45541_Footer.pptx");
removeAndCreateSlide(ppt);
ppt.close();
}
@Test
- public void bug55791b() throws IOException {
+ void bug55791b() throws IOException {
XMLSlideShow ppt = openSampleDocument("SampleShow.pptx");
removeAndCreateSlide(ppt);
ppt.close();
@@ -709,7 +709,7 @@ public class TestXSLFBugs {
}
@Test
- public void blibFillAlternateContent() throws IOException {
+ void blibFillAlternateContent() throws IOException {
XMLSlideShow ppt = openSampleDocument("2411-Performance_Up.pptx");
XSLFPictureShape ps = (XSLFPictureShape) ppt.getSlides().get(4).getShapes().get(0);
assertNotNull(ps.getPictureData());
@@ -717,7 +717,7 @@ public class TestXSLFBugs {
}
@Test
- public void bug59434() throws IOException {
+ void bug59434() throws IOException {
String url1 = "https://poi.apache.org/changes.html";
String url2 = "https://poi.apache.org/faq.html";
XMLSlideShow ppt1 = new XMLSlideShow();
@@ -744,7 +744,7 @@ public class TestXSLFBugs {
}
@Test
- public void bug58217() throws IOException {
+ void bug58217() throws IOException {
Color fillColor = new Color(1f, 1f, 0f, 0.1f);
Color lineColor = new Color(25.3f / 255f, 1f, 0f, 0.4f);
Color textColor = new Color(1f, 1f, 0f, 0.6f);
@@ -782,7 +782,7 @@ public class TestXSLFBugs {
}
@Test
- public void bug55714() throws IOException {
+ void bug55714() throws IOException {
XMLSlideShow srcPptx = openSampleDocument("pptx2svg.pptx");
XMLSlideShow newPptx = new XMLSlideShow();
XSLFSlide srcSlide = srcPptx.getSlides().get(0);
@@ -808,7 +808,7 @@ public class TestXSLFBugs {
}
@Test
- public void bug59273() throws IOException {
+ void bug59273() throws IOException {
XMLSlideShow ppt = openSampleDocument("bug59273.potx");
ppt.getPackage().replaceContentType(
XSLFRelation.PRESENTATIONML_TEMPLATE.getContentType(),
@@ -828,7 +828,7 @@ public class TestXSLFBugs {
@Test
- public void bug60373() throws IOException {
+ void bug60373() throws IOException {
XMLSlideShow ppt = new XMLSlideShow();
XSLFSlide sl = ppt.createSlide();
XSLFTable t = sl.createTable();
@@ -852,14 +852,14 @@ public class TestXSLFBugs {
}
@Test
- public void bug60715() throws IOException {
+ void bug60715() throws IOException {
try (XMLSlideShow ppt = openSampleDocument("bug60715.pptx")) {
assertDoesNotThrow((ThrowingSupplier<XSLFSlide>) ppt::createSlide);
}
}
@Test
- public void bug60662() throws IOException {
+ void bug60662() throws IOException {
XMLSlideShow src = new XMLSlideShow();
XSLFSlide sl = src.createSlide();
XSLFGroupShape gs = sl.createGroup();
@@ -938,7 +938,7 @@ public class TestXSLFBugs {
}
@Test
- public void bug62051() throws IOException {
+ void bug62051() throws IOException {
final Function<List<XSLFShape>, int[]> ids = (shapes) ->
shapes.stream().mapToInt(Shape::getShapeId).toArray();
@@ -966,7 +966,7 @@ public class TestXSLFBugs {
}
@Test
- public void bug63200() throws Exception {
+ void bug63200() throws Exception {
try (XMLSlideShow ss1 = openSampleDocument("63200.pptx")) {
assertEquals(1, ss1.getSlides().size());
@@ -983,7 +983,7 @@ public class TestXSLFBugs {
}
@Test
- public void alternateContent() throws Exception {
+ void alternateContent() throws Exception {
try (XMLSlideShow ppt = openSampleDocument("alterman_security.pptx")) {
XSLFSlideMaster slide = ppt.getSlideMasters().get(0);
XSLFObjectShape os = (XSLFObjectShape) slide.getShapes().get(0);
@@ -1005,7 +1005,7 @@ public class TestXSLFBugs {
@Test
- public void bug57796() throws IOException {
+ void bug57796() throws IOException {
assumeFalse(xslfOnly);
try (SlideShow<?, ?> ppt = SlideShowFactory.create(slTests.getFile("WithLinks.ppt"))) {
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestXSLFSlideShow.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestXSLFSlideShow.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestXSLFSlideShow.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/TestXSLFSlideShow.java Sat Jan 9 20:19:07 2021
@@ -47,12 +47,12 @@ public class TestXSLFSlideShow {
private OPCPackage pack;
@BeforeEach
- public void setUp() throws Exception {
+ void setUp() throws Exception {
pack = OPCPackage.open(slTests.openResourceAsStream("sample.pptx"));
}
@AfterEach
- public void tearDown() throws IOException {
+ void tearDown() throws IOException {
pack.close();
}
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/extractor/TestXSLFPowerPointExtractor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/extractor/TestXSLFPowerPointExtractor.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/extractor/TestXSLFPowerPointExtractor.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/extractor/TestXSLFPowerPointExtractor.java Sat Jan 9 20:19:07 2021
@@ -299,7 +299,7 @@ public class TestXSLFPowerPointExtractor
@Test
- public void bug54570() throws IOException {
+ void bug54570() throws IOException {
try (XMLSlideShow xml = openPPTX("bug54570.pptx");
SlideShowExtractor<XSLFShape, XSLFTextParagraph> extractor = new SlideShowExtractor<>(xml)) {
String text = extractor.getText();
@@ -314,7 +314,7 @@ public class TestXSLFPowerPointExtractor
}
@Test
- public void setSlTests() throws IOException {
+ void setSlTests() throws IOException {
try (XMLSlideShow xml = openPPTX("aascu.org_hbcu_leadershipsummit_cooper_.pptx")) {
SlideShowExtractor<XSLFShape, XSLFTextParagraph> extractor = new SlideShowExtractor<>(xml);
assertNotNull(extractor);
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestPPTX2PNG.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestPPTX2PNG.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestPPTX2PNG.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestPPTX2PNG.java Sat Jan 9 20:19:07 2021
@@ -78,7 +78,7 @@ public class TestPPTX2PNG {
// use filename instead of File object to omit full pathname in test name
@ParameterizedTest
@MethodSource("data")
- public void render(String pptFile) throws Exception {
+ void render(String pptFile) throws Exception {
assumeFalse(xslfOnly && pptFile.matches(".*\\.(ppt|emf|wmf)$"), "ignore HSLF (.ppt) / HEMF (.emf) / HWMF (.wmf) files in no-scratchpad run");
PPTX2PNG.main(getArgs(pptFile, "null"));
if (svgFiles.contains(pptFile)) {
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXMLSlideShow.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXMLSlideShow.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXMLSlideShow.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXMLSlideShow.java Sat Jan 9 20:19:07 2021
@@ -46,12 +46,12 @@ public class TestXMLSlideShow extends Ba
}
@BeforeEach
- public void setUp() throws Exception {
+ void setUp() throws Exception {
pack = OPCPackage.open(slTests.openResourceAsStream("sample.pptx"));
}
@AfterEach
- public void tearDown() {
+ void tearDown() {
pack.revert();
}
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFExamples.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFExamples.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFExamples.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFExamples.java Sat Jan 9 20:19:07 2021
@@ -57,7 +57,7 @@ import org.openxmlformats.schemas.presen
*/
public class TestXSLFExamples {
@Test
- public void LinkVideoToPptx() throws IOException, URISyntaxException {
+ void LinkVideoToPptx() throws IOException, URISyntaxException {
String videoFileName = "file_example_MP4_640_3MG.mp4";
File previewJpg = POIDataSamples.getDocumentInstance().getFile("abstract1.jpg");
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFHyperlink.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFHyperlink.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFHyperlink.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFHyperlink.java Sat Jan 9 20:19:07 2021
@@ -105,7 +105,7 @@ public class TestXSLFHyperlink {
@Test
- public void bug47291() throws IOException {
+ void bug47291() throws IOException {
Rectangle2D anchor = new Rectangle2D.Double(100,100,100,100);
XMLSlideShow ppt1 = new XMLSlideShow();
XSLFSlide slide1 = ppt1.createSlide();
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFNotes.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFNotes.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFNotes.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFNotes.java Sat Jan 9 20:19:07 2021
@@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test;
public class TestXSLFNotes {
@Test
- public void createNewNote() throws IOException {
+ void createNewNote() throws IOException {
XMLSlideShow ppt = new XMLSlideShow();
XSLFSlide slide1 = ppt.createSlide();
@@ -56,7 +56,7 @@ public class TestXSLFNotes {
}
@Test
- public void addNote() throws IOException {
+ void addNote() throws IOException {
XMLSlideShow ppt = XSLFTestDataSamples.openSampleDocument("sample.pptx");
@@ -79,7 +79,7 @@ public class TestXSLFNotes {
}
@Test
- public void replaceNotes() throws IOException {
+ void replaceNotes() throws IOException {
XMLSlideShow ppt = XSLFTestDataSamples.openSampleDocument("sample.pptx");
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFPictureShape.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFPictureShape.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFPictureShape.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFPictureShape.java Sat Jan 9 20:19:07 2021
@@ -222,7 +222,7 @@ public class TestXSLFPictureShape {
}
@Test
- public void bug58663() throws IOException {
+ void bug58663() throws IOException {
InputStream is = _slTests.openResourceAsStream("shapes.pptx");
XMLSlideShow ppt = new XMLSlideShow(is);
is.close();
@@ -256,7 +256,7 @@ public class TestXSLFPictureShape {
@Test
- public void renderSvgImage() throws Exception {
+ void renderSvgImage() throws Exception {
XMLSlideShow ppt = new XMLSlideShow();
XSLFSlide slide = ppt.createSlide();
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFShapeContainer.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFShapeContainer.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFShapeContainer.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFShapeContainer.java Sat Jan 9 20:19:07 2021
@@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test;
*/
public class TestXSLFShapeContainer {
- public void verifyContainer(XSLFShapeContainer container) {
+ void verifyContainer(XSLFShapeContainer container) {
container.clear();
assertEquals(0, container.getShapes().size());
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTable.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTable.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTable.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTable.java Sat Jan 9 20:19:07 2021
@@ -279,7 +279,7 @@ public class TestXSLFTable {
}
@Test
- public void removeTable() throws IOException {
+ void removeTable() throws IOException {
XMLSlideShow ss = XSLFTestDataSamples.openSampleDocument("shapes.pptx");
XSLFSlide sl = ss.getSlides().get(0);
XSLFTable tab = (XSLFTable)sl.getShapes().get(4);
@@ -297,7 +297,7 @@ public class TestXSLFTable {
}
@Test
- public void checkTextHeight() throws IOException {
+ void checkTextHeight() throws IOException {
// from bug 59686
XMLSlideShow ppt = new XMLSlideShow();
XSLFSlide sl = ppt.createSlide();
@@ -317,7 +317,7 @@ public class TestXSLFTable {
}
@Test
- public void checkNullPointerException() throws IOException {
+ void checkNullPointerException() throws IOException {
String file = "au.asn.aes.www_conferences_2011_presentations_Fri_20Room4Level4_20930_20Maloney.pptx";
try (XMLSlideShow ss = XSLFTestDataSamples.openSampleDocument(file)) {
Dimension pgsize = ss.getPageSize();
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTableRow.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTableRow.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTableRow.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTableRow.java Sat Jan 9 20:19:07 2021
@@ -36,7 +36,7 @@ public class TestXSLFTableRow {
/** Copied from {@link TestXSLFTable#testRead()} */
@BeforeEach
- public void setUp() throws IOException {
+ void setUp() throws IOException {
ppt = XSLFTestDataSamples.openSampleDocument("shapes.pptx");
XSLFSlide slide = ppt.getSlides().get(3);
@@ -47,14 +47,14 @@ public class TestXSLFTableRow {
}
@AfterEach
- public void tearDown() throws IOException {
+ void tearDown() throws IOException {
ppt.getPackage().revert();
ppt.close();
}
@Test
- public void constructor() {
+ void constructor() {
XSLFTableRow row2 = new XSLFTableRow(row.getXmlObject(), tbl);
assertSame(row.getXmlObject(), row2.getXmlObject());
assertEquals(row.getHeight(), row2.getHeight(), 1e-16);
@@ -69,7 +69,7 @@ public class TestXSLFTableRow {
/** copied from {@link TestXSLFTable#testCreate()} */
@Test
- public void getCells() {
+ void getCells() {
List<XSLFTableCell> cells = row.getCells();
assertNotNull(cells);
assertEquals(3, cells.size());
@@ -87,7 +87,7 @@ public class TestXSLFTableRow {
/** copied from {@link TestXSLFTable#testCreate()} */
@Test
- public void addCell() {
+ void addCell() {
XSLFTableCell cell = row.addCell();
assertNotNull(cell);
@@ -101,7 +101,7 @@ public class TestXSLFTableRow {
}
@Test
- public void mergeCells() {
+ void mergeCells() {
assertThrows(IllegalArgumentException.class, () -> row.mergeCells(0, 0),
"expected IllegalArgumentException when merging fewer than 2 columns");
@@ -114,14 +114,14 @@ public class TestXSLFTableRow {
}
@Test
- public void getXmlObject() {
+ void getXmlObject() {
CTTableRow ctrow = row.getXmlObject();
assertNotNull(ctrow);
}
@Test
- public void getShapeNameOfCells() throws Exception {
+ void getShapeNameOfCells() throws Exception {
try(XMLSlideShow ss1 = XSLFTestDataSamples.openSampleDocument("table_test.pptx")) {
for (XSLFSlide slide : ss1.getSlides()) {
for (XSLFShape shape : slide.getShapes()) {
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTextShape.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTextShape.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTextShape.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTextShape.java Sat Jan 9 20:19:07 2021
@@ -950,7 +950,7 @@ public class TestXSLFTextShape {
}
@Test
- public void metroBlob() throws IOException, ReflectiveOperationException {
+ void metroBlob() throws IOException, ReflectiveOperationException {
assumeFalse(xslfOnly);
File f = POIDataSamples.getSlideShowInstance().getFile("bug52297.ppt");
SlideShow<?,?> ppt = SlideShowFactory.create(f);
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestSheetProtection.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestSheetProtection.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestSheetProtection.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestSheetProtection.java Sat Jan 9 20:19:07 2021
@@ -32,13 +32,13 @@ public class TestSheetProtection {
private XSSFSheet sheet;
@BeforeEach
- public void setUp() {
+ void setUp() {
workbook = XSSFTestDataSamples.openSampleWorkbook("sheetProtection_not_protected.xlsx");
sheet = workbook.getSheetAt(0);
}
@AfterEach
- public void tearDown() throws IOException {
+ void tearDown() throws IOException {
workbook.close();
}
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestWorkbookProtection.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestWorkbookProtection.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestWorkbookProtection.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestWorkbookProtection.java Sat Jan 9 20:19:07 2021
@@ -47,7 +47,7 @@ import org.junit.jupiter.api.Test;
public class TestWorkbookProtection {
@Test
- public void workbookAndRevisionPassword() throws Exception {
+ void workbookAndRevisionPassword() throws Exception {
String password = "test";
// validate password with an actual office file (Excel 2010)
@@ -96,7 +96,7 @@ public class TestWorkbookProtection {
}
@Test
- public void shouldReadWorkbookProtection() throws Exception {
+ void shouldReadWorkbookProtection() throws Exception {
try (XSSFWorkbook workbook = openSampleWorkbook("workbookProtection_not_protected.xlsx")) {
assertFalse(workbook.isStructureLocked());
assertFalse(workbook.isWindowsLocked());
@@ -123,7 +123,7 @@ public class TestWorkbookProtection {
}
@Test
- public void shouldWriteStructureLock() throws Exception {
+ void shouldWriteStructureLock() throws Exception {
try (XSSFWorkbook workbook = openSampleWorkbook("workbookProtection_not_protected.xlsx")) {
assertFalse(workbook.isStructureLocked());
@@ -138,7 +138,7 @@ public class TestWorkbookProtection {
}
@Test
- public void shouldWriteWindowsLock() throws Exception {
+ void shouldWriteWindowsLock() throws Exception {
try (XSSFWorkbook workbook = openSampleWorkbook("workbookProtection_not_protected.xlsx")) {
assertFalse(workbook.isWindowsLocked());
@@ -153,7 +153,7 @@ public class TestWorkbookProtection {
}
@Test
- public void shouldWriteRevisionLock() throws Exception {
+ void shouldWriteRevisionLock() throws Exception {
try (XSSFWorkbook workbook = openSampleWorkbook("workbookProtection_not_protected.xlsx")) {
assertFalse(workbook.isRevisionLocked());
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestXSSFCloneSheet.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestXSSFCloneSheet.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestXSSFCloneSheet.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/TestXSSFCloneSheet.java Sat Jan 9 20:19:07 2021
@@ -43,7 +43,7 @@ public class TestXSSFCloneSheet extends
private XSSFWorkbook wb;
@BeforeEach
- public void setUp() {
+ void setUp() {
wb = new XSSFWorkbook();
wb.createSheet(VALID_SHEET_NAME);
}
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/XSSFMemoryLeakTests.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/XSSFMemoryLeakTests.java?rev=1885318&r1=1885317&r2=1885318&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/XSSFMemoryLeakTests.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/XSSFMemoryLeakTests.java Sat Jan 9 20:19:07 2021
@@ -55,7 +55,7 @@ public class XSSFMemoryLeakTests {
private final List<Object> references = new ArrayList<>();
@AfterEach
- public void tearDown() {
+ void tearDown() {
verifier.assertGarbageCollected();
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org