You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by Cameron McKenzie <ca...@apache.org> on 2015/04/28 04:47:43 UTC
Testing server restart
Jordan,
I've fixed all of the tests that are currently breaking due to the server
restart issue, but I think that I'll go through and check if there are any
others that are also using the server.close() then recreate a new instance
pattern as they will inevitably come back and bite us later.
I will raise a new JIRA ticket for it.
cheers
Re: Testing server restart
Posted by Mike Drob <ma...@cloudera.com>.
Thanks for getting this straightened out, Cameron!
On Tue, Apr 28, 2015 at 12:31 AM, Cameron McKenzie <mc...@gmail.com>
wrote:
> Build seems to be back to normal now too.
>
> On Tue, Apr 28, 2015 at 1:59 PM, Cameron McKenzie <mc...@gmail.com>
> wrote:
>
> > Changes are merged into master now.
> > cheers
> >
> > On Tue, Apr 28, 2015 at 1:45 PM, Cameron McKenzie <
> mckenzie.cam@gmail.com>
> > wrote:
> >
> >> Nope not yet, I've just gone through and fixed up a bunch of tests.
> >> Running a full regression now and if that's all good I will commit and
> >> merge into master.
> >> cheers
> >>
> >> On Tue, Apr 28, 2015 at 1:38 PM, Jordan Zimmerman <
> >> jordan@jordanzimmerman.com> wrote:
> >>
> >>> Did you merge your changes? I’m not seeing them.
> >>>
> >>>
> >>>
> >>> On April 27, 2015 at 9:47:46 PM, Cameron McKenzie (
> >>> cammckenzie@apache.org) wrote:
> >>>
> >>> Jordan,
> >>> I've fixed all of the tests that are currently breaking due to the
> >>> server restart issue, but I think that I'll go through and check if
> there
> >>> are any others that are also using the server.close() then recreate a
> new
> >>> instance pattern as they will inevitably come back and bite us later.
> >>>
> >>> I will raise a new JIRA ticket for it.
> >>> cheers
> >>>
> >>>
> >>
> >
>
Re: Testing server restart
Posted by Cameron McKenzie <mc...@gmail.com>.
Build seems to be back to normal now too.
On Tue, Apr 28, 2015 at 1:59 PM, Cameron McKenzie <mc...@gmail.com>
wrote:
> Changes are merged into master now.
> cheers
>
> On Tue, Apr 28, 2015 at 1:45 PM, Cameron McKenzie <mc...@gmail.com>
> wrote:
>
>> Nope not yet, I've just gone through and fixed up a bunch of tests.
>> Running a full regression now and if that's all good I will commit and
>> merge into master.
>> cheers
>>
>> On Tue, Apr 28, 2015 at 1:38 PM, Jordan Zimmerman <
>> jordan@jordanzimmerman.com> wrote:
>>
>>> Did you merge your changes? I’m not seeing them.
>>>
>>>
>>>
>>> On April 27, 2015 at 9:47:46 PM, Cameron McKenzie (
>>> cammckenzie@apache.org) wrote:
>>>
>>> Jordan,
>>> I've fixed all of the tests that are currently breaking due to the
>>> server restart issue, but I think that I'll go through and check if there
>>> are any others that are also using the server.close() then recreate a new
>>> instance pattern as they will inevitably come back and bite us later.
>>>
>>> I will raise a new JIRA ticket for it.
>>> cheers
>>>
>>>
>>
>
Re: Testing server restart
Posted by Cameron McKenzie <mc...@gmail.com>.
Changes are merged into master now.
cheers
On Tue, Apr 28, 2015 at 1:45 PM, Cameron McKenzie <mc...@gmail.com>
wrote:
> Nope not yet, I've just gone through and fixed up a bunch of tests.
> Running a full regression now and if that's all good I will commit and
> merge into master.
> cheers
>
> On Tue, Apr 28, 2015 at 1:38 PM, Jordan Zimmerman <
> jordan@jordanzimmerman.com> wrote:
>
>> Did you merge your changes? I’m not seeing them.
>>
>>
>>
>> On April 27, 2015 at 9:47:46 PM, Cameron McKenzie (cammckenzie@apache.org)
>> wrote:
>>
>> Jordan,
>> I've fixed all of the tests that are currently breaking due to the server
>> restart issue, but I think that I'll go through and check if there are any
>> others that are also using the server.close() then recreate a new instance
>> pattern as they will inevitably come back and bite us later.
>>
>> I will raise a new JIRA ticket for it.
>> cheers
>>
>>
>
Re: Testing server restart
Posted by Cameron McKenzie <mc...@gmail.com>.
Nope not yet, I've just gone through and fixed up a bunch of tests. Running
a full regression now and if that's all good I will commit and merge into
master.
cheers
On Tue, Apr 28, 2015 at 1:38 PM, Jordan Zimmerman <
jordan@jordanzimmerman.com> wrote:
> Did you merge your changes? I’m not seeing them.
>
>
>
> On April 27, 2015 at 9:47:46 PM, Cameron McKenzie (cammckenzie@apache.org)
> wrote:
>
> Jordan,
> I've fixed all of the tests that are currently breaking due to the server
> restart issue, but I think that I'll go through and check if there are any
> others that are also using the server.close() then recreate a new instance
> pattern as they will inevitably come back and bite us later.
>
> I will raise a new JIRA ticket for it.
> cheers
>
>
Re: Testing server restart
Posted by Jordan Zimmerman <jo...@jordanzimmerman.com>.
Did you merge your changes? I’m not seeing them.
On April 27, 2015 at 9:47:46 PM, Cameron McKenzie (cammckenzie@apache.org) wrote:
Jordan,
I've fixed all of the tests that are currently breaking due to the server restart issue, but I think that I'll go through and check if there are any others that are also using the server.close() then recreate a new instance pattern as they will inevitably come back and bite us later.
I will raise a new JIRA ticket for it.
cheers
Re: Testing server restart
Posted by Jordan Zimmerman <jo...@jordanzimmerman.com>.
Thanks!
On April 27, 2015 at 9:47:46 PM, Cameron McKenzie (cammckenzie@apache.org) wrote:
Jordan,
I've fixed all of the tests that are currently breaking due to the server restart issue, but I think that I'll go through and check if there are any others that are also using the server.close() then recreate a new instance pattern as they will inevitably come back and bite us later.
I will raise a new JIRA ticket for it.
cheers