[GitHub] [iceberg] kbendick commented on a diff in pull request #4906: Add additional options for catalog test implementations

[GitBox <gi...@apache.org>]

kbendick commented on code in PR #4906:
URL: https://github.com/apache/iceberg/pull/4906#discussion_r885039255


##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -155,6 +155,14 @@ protected boolean supportsServerSideRetry() {
     return false;
   }
 
+  protected boolean supportsServerManagedLocation() {
+    return false;
+  }
+
+  protected boolean supportsNamesWithSlashes() {

Review Comment:
   Is that for escaped slashes in the typical way or for the REST catalogs escaped slashes that use `%00` (Null byte)?
   
   I’m good with not requiring that server implementations require this (I’m almost certain it’s already not required) but would want to ensure the spec is up to date. But if the null-byte can open up security problems then I can understand people deciding tables / namespaces really don’t benefit from slashes in them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org