[GitHub] spark pull request: [SPARK-2179][SQL] Public API for DataTypes and...

[chutium <gi...@git.apache.org>]

Github user chutium commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1346#discussion_r15766362
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
    @@ -89,6 +88,44 @@ class SQLContext(@transient val sparkContext: SparkContext)
         new SchemaRDD(this, SparkLogicalPlan(ExistingRdd.fromProductRdd(rdd))(self))
     
       /**
    +   * :: DeveloperApi ::
    +   * Creates a [[SchemaRDD]] from an [[RDD]] containing [[Row]]s by applying a schema to this RDD.
    +   * It is important to make sure that the structure of every [[Row]] of the provided RDD matches
    +   * the provided schema. Otherwise, there will be runtime exception.
    +   * Example:
    +   * {{{
    +   *  import org.apache.spark.sql._
    +   *  val sqlContext = new org.apache.spark.sql.SQLContext(sc)
    +   *
    +   *  val schema =
    +   *    StructType(
    +   *      StructField("name", StringType, false) ::
    +   *      StructField("age", IntegerType, true) :: Nil)
    +   *
    --- End diff --
    
    Hi @yhuai , why we need to define schema as a StructType, but not directly as a Seq[StructField]? i tried to build a Seq[StructField] from JDBC metadata in #1612 https://github.com/apache/spark/pull/1612/files#diff-3 (it followed the code of your JsonRDD :)
    
    it seems we do not need this StructType anywhere.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org