[GitHub] [orc] wgtmac commented on a change in pull request #508: ORC-629: PPD: Floating point NaN is not transitive across comparisons

[GitBox <gi...@apache.org>]

wgtmac commented on a change in pull request #508:
URL: https://github.com/apache/orc/pull/508#discussion_r481879449



##########
File path: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java
##########
@@ -495,6 +495,14 @@ static TruthValue evaluatePredicateProto(OrcProto.ColumnStatistics statsProto,
                    " include ORC-517. Writer version: {}",
           predicate.getColumnName(), writerVersion);
       return TruthValue.YES_NO_NULL;
+    } else if (category == TypeDescription.Category.DOUBLE) {
+      DoubleColumnStatistics dstas = (DoubleColumnStatistics) cs;
+      if (!Double.isFinite(dstas.getMinimum()) || !Double.isFinite(dstas.getMaximum())

Review comment:
       I found the [fix for C++](https://github.com/apache/orc/commit/f6554377828b66d1198fe720ae8b9a734255a2df
   ) has been merged already. Need to ensure they are consistent.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org