[GitHub] [inlong] haifxu commented on a diff in pull request #6455: [INLONG-6451][Manager] Rewrite getSourcesMap for the Kafka source operator

[GitBox <gi...@apache.org>]

haifxu commented on code in PR #6455:
URL: https://github.com/apache/inlong/pull/6455#discussion_r1016101852


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/queue/kafka/KafkaResourceOperators.java:
##########
@@ -172,17 +172,17 @@ private void createKafkaTopic(InlongKafkaInfo kafkaInfo, String streamId) throws
             throw new WorkflowListenerException("topic=" + topicName + " not exists in " + bootStrapServers);
         }
 
-        // 2. create a subscription for the kafka topic
-        kafkaOperator.createSubscription(kafkaInfo, (KafkaClusterInfo) clusterInfo, topicName);
-        String groupId = kafkaInfo.getInlongGroupId();
-        log.info("success to create kafka subscription for groupId={}, topic={}, consumeGroup={}",
-                groupId, topicName, topicName);
+        // Kafka consumers do not need to register in advance
+//        kafkaOperator.createSubscription(kafkaInfo, (KafkaClusterInfo) clusterInfo, topicName);

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org