Re: [PR] Capture build scans on ge.apache.org to benefit from deep build insights [solr]

["dsmiley (via GitHub)" <gi...@apache.org>]

dsmiley commented on PR #2042:
URL: https://github.com/apache/solr/pull/2042#issuecomment-1789737255

   I see this enables [the build cache](https://docs.gradle.org/current/userguide/build_cache.html) by default, which hopefully is a big positive benefit, at the expense of some local disk and risks of a misconfigured build leading to accidental caching.  Note that this topic has been raised before: https://issues.apache.org/jira/browse/SOLR-15603 which defaults to false via commented out part of `gradle.properties`.  Solr's build (and Lucene) generates on first build from a [template](https://github.com/apache/solr/blob/main/gradle/template.gradle.properties) which mentions `org.gradle.caching`.  That should probably be removed entirely if we're going to enable build caching in this new `ge.gradle` file.
   
   Even if the Crave integration is lacking; I don't think that should hold this up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org