You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Lavkesh Lahngir <la...@gmail.com> on 2016/09/01 09:26:15 UTC
Re: Review Request 51494: Thread can choose to wait for event to
finish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51494/
-----------------------------------------------------------
(Updated Sept. 1, 2016, 9:26 a.m.)
Review request for lens.
Changes
-------
Created notifySync() method in the EventService
Bugs: LENS-1298
https://issues.apache.org/jira/browse/LENS-1298
Repository: lens
Description
-------
When a thread notifies event service to process any event, it should have a way to wait for it to be finished.
Also Alarmservice has an option to wait after notifying evenservice.
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 4536a18
lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java 0f2dabe
lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 369885d
lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 6487323
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 323e053
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 94011d2
Diff: https://reviews.apache.org/r/51494/diff/
Testing
-------
1. Added test in Eventservice test
Thanks,
Lavkesh Lahngir
Re: Review Request 51494: Thread can choose to wait for event to
finish
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51494/#review147628
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java (line 195)
<https://reviews.apache.org/r/51494/#comment214834>
Instead should we do new EventHandler().run() here ?
No wait and notify will be required.
- Amareshwari Sriramadasu
On Sept. 1, 2016, 9:26 a.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51494/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2016, 9:26 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1298
> https://issues.apache.org/jira/browse/LENS-1298
>
>
> Repository: lens
>
>
> Description
> -------
>
> When a thread notifies event service to process any event, it should have a way to wait for it to be finished.
>
> Also Alarmservice has an option to wait after notifying evenservice.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 4536a18
> lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java 0f2dabe
> lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 369885d
> lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 6487323
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 323e053
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 94011d2
>
> Diff: https://reviews.apache.org/r/51494/diff/
>
>
> Testing
> -------
>
> 1. Added test in Eventservice test
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 51494: Thread can choose to wait for event to
finish
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51494/#review147652
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On Sept. 2, 2016, 5:53 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51494/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2016, 5:53 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1298
> https://issues.apache.org/jira/browse/LENS-1298
>
>
> Repository: lens
>
>
> Description
> -------
>
> When a thread notifies event service to process any event, it should have a way to wait for it to be finished.
>
> Also Alarmservice has an option to wait after notifying evenservice.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 4536a18
> lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java 0f2dabe
> lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 369885d
> lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 6487323
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 323e053
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 94011d2
>
> Diff: https://reviews.apache.org/r/51494/diff/
>
>
> Testing
> -------
>
> 1. Added test in Eventservice test
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 51494: Thread can choose to wait for event to
finish
Posted by Lavkesh Lahngir <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51494/
-----------------------------------------------------------
(Updated Sept. 2, 2016, 12:23 p.m.)
Review request for lens.
Changes
-------
notifySync() is much simpler now having no thread switching overhead
Bugs: LENS-1298
https://issues.apache.org/jira/browse/LENS-1298
Repository: lens
Description
-------
When a thread notifies event service to process any event, it should have a way to wait for it to be finished.
Also Alarmservice has an option to wait after notifying evenservice.
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java 4536a18
lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java 0f2dabe
lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 369885d
lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 6487323
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 323e053
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 94011d2
Diff: https://reviews.apache.org/r/51494/diff/
Testing
-------
1. Added test in Eventservice test
Thanks,
Lavkesh Lahngir