[GitHub] [airflow] josh-fell commented on a diff in pull request #26759: Add docs re how to patch from main

[GitBox <gi...@apache.org>]

josh-fell commented on code in PR #26759:
URL: https://github.com/apache/airflow/pull/26759#discussion_r982714893


##########
docs/apache-airflow/production-deployment.rst:
##########
@@ -222,6 +222,29 @@ you can exchange the Google Cloud Platform identity to the Amazon Web Service id
 which effectively means access to Amazon Web Service platform.
 For more information, see: :ref:`howto/connection:aws:gcp-federation`
 
+
+Applying patches from ``main``
+==============================
+
+On occasion, a user may want to apply a patch from ``main`` which has not yet made it into a release.  Assuming you want to apply a specific PR to one of the official airflow images, you can apply roughly as follows.  It's also possible to apply a specific commit.
+
+.. code-block:: docker

Review Comment:
   WDYT about showing both examples explicitly (i.e. patching from PR and from a commit)? I believe the syntax is slightly different but important. 
   
   Have "It's also possible to apply a specific commit." on a new line and show an example of patching from a commit. Do you think seeing both examples would be helpful for beginners (albeit with some healthy of overlap)?



##########
docs/apache-airflow/production-deployment.rst:
##########
@@ -222,6 +222,29 @@ you can exchange the Google Cloud Platform identity to the Amazon Web Service id
 which effectively means access to Amazon Web Service platform.
 For more information, see: :ref:`howto/connection:aws:gcp-federation`
 
+
+Applying patches from ``main``
+==============================
+
+On occasion, a user may want to apply a patch from ``main`` which has not yet made it into a release.  Assuming you want to apply a specific PR to one of the official airflow images, you can apply roughly as follows.  It's also possible to apply a specific commit.

Review Comment:
   ```suggestion
   On occasion, you may want to apply a patch from ``main`` which has not yet made it into a release.  Assuming you want to apply a specific PR to one of the official airflow images, you can apply roughly as follows.  It's also possible to apply a specific commit.
   ```
   To keep the voice consistent; namely 2nd person.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org