[jira] [Comment Edited] (AMQ-6590) KahaDB index loses track of free pages on unclean shutdown

["Gary Tully (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-6590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653398#comment-16653398 ] 

Gary Tully edited comment on AMQ-6590 at 10/17/18 11:40 AM:
------------------------------------------------------------

[~cshannon] I have moved this fix to the shutdown phase b/c the recovery work can be significant on very large stores. The down side is temporary disk space usage by the index which is a better trade off IMHO. 

I also added an info log message to indicate that the some recovery is going on.


was (Author: gtully):
[~cshannon] I have move this fix to the shutdown phase b/c the recovery work can be significant on very large stores. The down side is temporary disk space usage by the index which is a better trade off IMHO. 

I also added an info log message to indicate that the some recovery is going on.

> KahaDB index loses track of free pages on unclean shutdown
> ----------------------------------------------------------
>
>                 Key: AMQ-6590
>                 URL: https://issues.apache.org/jira/browse/AMQ-6590
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.14.3
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>            Priority: Major
>             Fix For: 5.15.0, 5.14.4
>
>
> I have discovered an issue with the KahaDB index recovery after an unclean shutdown (OOM error, kill -9, etc) that leads to excessive disk space usage. 
> Normally on clean shutdown the index stores the known set of free pages to db.free and reads that in on start up to know which pages can be re-used.  On an unclean shutdown this is not written to disk so on start up the index is supposed to scan the page file to figure out all of the free pages.
> Unfortunately it turns out that this scan of the page file is being done before the total page count value has been set so when the iterator is created it always thinks there are 0 pages to scan.
> The end result is that every time an unclean shutdown occurs all known free pages are lost and no longer tracked.  This of course means new free pages have to be allocated and all of the existing space is now lost which will lead to excessive index file growth over time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)