[GitHub] [spark] cloud-fan commented on a diff in pull request #38347: [SPARK-40883][CONNECT] Support Range in Connect proto

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #38347:
URL: https://github.com/apache/spark/pull/38347#discussion_r1002849365


##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -207,3 +208,23 @@ message Sample {
     int64 seed = 1;
   }
 }
+
+// Relation of type [[Range]] that generates a sequence of integers.
+message Range {
+  // Optional. Default value = 0
+  int32 start = 1;
+  int32 end = 2;

Review Comment:
   end is not optional, but how do we know if the client forgets to set it? 0 is a valid end value as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org