You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/28 10:07:13 UTC
[GitHub] [flink] alpinegizmo opened a new pull request #11931: [FLINK-17432][docs-training] Rename Tutorials to Training for better SEO
alpinegizmo opened a new pull request #11931:
URL: https://github.com/apache/flink/pull/11931
## What is the purpose of the change
This pull request renames the new Tutorials section of the documentation.
## Brief change log
* Renamed the tutorials directory to training
* Changed all links
* Reworded a few sentences to talk about training
* Added a redirect from /tutorials to /training
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11931: [FLINK-17432][docs-training] Rename Tutorials to Training for better SEO
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11931:
URL: https://github.com/apache/flink/pull/11931#issuecomment-620525973
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "787bc83a15e54846500bc49900f97954880d65bd",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162401466",
"triggerID" : "787bc83a15e54846500bc49900f97954880d65bd",
"triggerType" : "PUSH"
}, {
"hash" : "787bc83a15e54846500bc49900f97954880d65bd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=367",
"triggerID" : "787bc83a15e54846500bc49900f97954880d65bd",
"triggerType" : "PUSH"
}, {
"hash" : "826e4af475affea37d8d079abf51a653233a1f08",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162423330",
"triggerID" : "826e4af475affea37d8d079abf51a653233a1f08",
"triggerType" : "PUSH"
}, {
"hash" : "826e4af475affea37d8d079abf51a653233a1f08",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=374",
"triggerID" : "826e4af475affea37d8d079abf51a653233a1f08",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 787bc83a15e54846500bc49900f97954880d65bd Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/162401466) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=367)
* 826e4af475affea37d8d079abf51a653233a1f08 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162423330) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=374)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11931: [FLINK-17432][docs-training] Rename Tutorials to Training for better SEO
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11931:
URL: https://github.com/apache/flink/pull/11931#issuecomment-620525973
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "787bc83a15e54846500bc49900f97954880d65bd",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162401466",
"triggerID" : "787bc83a15e54846500bc49900f97954880d65bd",
"triggerType" : "PUSH"
}, {
"hash" : "787bc83a15e54846500bc49900f97954880d65bd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=367",
"triggerID" : "787bc83a15e54846500bc49900f97954880d65bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 787bc83a15e54846500bc49900f97954880d65bd Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162401466) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=367)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11931: [FLINK-17432][docs-training] Rename Tutorials to Training for better SEO
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11931:
URL: https://github.com/apache/flink/pull/11931#issuecomment-620525973
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "787bc83a15e54846500bc49900f97954880d65bd",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162401466",
"triggerID" : "787bc83a15e54846500bc49900f97954880d65bd",
"triggerType" : "PUSH"
}, {
"hash" : "787bc83a15e54846500bc49900f97954880d65bd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=367",
"triggerID" : "787bc83a15e54846500bc49900f97954880d65bd",
"triggerType" : "PUSH"
}, {
"hash" : "826e4af475affea37d8d079abf51a653233a1f08",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162423330",
"triggerID" : "826e4af475affea37d8d079abf51a653233a1f08",
"triggerType" : "PUSH"
}, {
"hash" : "826e4af475affea37d8d079abf51a653233a1f08",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=374",
"triggerID" : "826e4af475affea37d8d079abf51a653233a1f08",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 826e4af475affea37d8d079abf51a653233a1f08 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162423330) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=374)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] NicoK commented on a change in pull request #11931: [FLINK-17432][docs-training] Rename Tutorials to Training for better SEO
Posted by GitBox <gi...@apache.org>.
NicoK commented on a change in pull request #11931:
URL: https://github.com/apache/flink/pull/11931#discussion_r416521844
##########
File path: docs/training/event_driven.md
##########
@@ -38,8 +38,8 @@ with Flink. It is very similar to a `RichFlatMapFunction`, but with the addition
### Example
If you've done the
-[hands-on exercise]({% link tutorials/streaming_analytics.md %}#hands-on)
-in the [Streaming Analytics tutorial]({% link tutorials/streaming_analytics.md %}),
+[hands-on exercise]({% link training/streaming_analytics.md %}#hands-on)
+in the [Streaming Analytics tutorial]({% link training/streaming_analytics.md %}),
Review comment:
```suggestion
in the [Streaming Analytics training]({% link training/streaming_analytics.md %}),
```
##########
File path: docs/training/event_driven.zh.md
##########
@@ -38,8 +38,8 @@ with Flink. It is very similar to a `RichFlatMapFunction`, but with the addition
### Example
If you've done the
-[hands-on exercise]({% link tutorials/streaming_analytics.zh.md %}#hands-on)
-in the [Streaming Analytics tutorial]({% link tutorials/streaming_analytics.zh.md %}),
+[hands-on exercise]({% link training/streaming_analytics.zh.md %}#hands-on)
+in the [Streaming Analytics tutorial]({% link training/streaming_analytics.zh.md %}),
Review comment:
```suggestion
in the [Streaming Analytics training]({% link training/streaming_analytics.zh.md %}),
```
##########
File path: docs/training/datastream_api.md
##########
@@ -3,8 +3,7 @@ title: Intro to the DataStream API
nav-id: datastream-api
nav-pos: 2
nav-title: Intro to the DataStream API
-nav-parent_id: tutorials
-permalink: /tutorials/datastream_api.html
+nav-parent_id: training
---
<!--
Licensed to the Apache Software Foundation (ASF) under one
Review comment:
line 28 still has "tutorial" instead of "training"
##########
File path: docs/training/etl.md
##########
@@ -3,7 +3,7 @@ title: Data Pipelines & ETL
nav-id: etl
nav-pos: 3
nav-title: Data Pipelines & ETL
-nav-parent_id: tutorials
+nav-parent_id: training
---
<!--
Licensed to the Apache Software Foundation (ASF) under one
Review comment:
This page (not in the diff) still has a few lines using "tutorial" instead of "training"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #11931: [FLINK-17432][docs-training] Rename Tutorials to Training for better SEO
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11931:
URL: https://github.com/apache/flink/pull/11931#issuecomment-620525973
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "787bc83a15e54846500bc49900f97954880d65bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "787bc83a15e54846500bc49900f97954880d65bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 787bc83a15e54846500bc49900f97954880d65bd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11931: [FLINK-17432][docs-training] Rename Tutorials to Training for better SEO
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11931:
URL: https://github.com/apache/flink/pull/11931#issuecomment-620525973
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "787bc83a15e54846500bc49900f97954880d65bd",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162401466",
"triggerID" : "787bc83a15e54846500bc49900f97954880d65bd",
"triggerType" : "PUSH"
}, {
"hash" : "787bc83a15e54846500bc49900f97954880d65bd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=367",
"triggerID" : "787bc83a15e54846500bc49900f97954880d65bd",
"triggerType" : "PUSH"
}, {
"hash" : "826e4af475affea37d8d079abf51a653233a1f08",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162423330",
"triggerID" : "826e4af475affea37d8d079abf51a653233a1f08",
"triggerType" : "PUSH"
}, {
"hash" : "826e4af475affea37d8d079abf51a653233a1f08",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=374",
"triggerID" : "826e4af475affea37d8d079abf51a653233a1f08",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 787bc83a15e54846500bc49900f97954880d65bd Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/162401466) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=367)
* 826e4af475affea37d8d079abf51a653233a1f08 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162423330) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=374)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11931: [FLINK-17432][docs-training] Rename Tutorials to Training for better SEO
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11931:
URL: https://github.com/apache/flink/pull/11931#issuecomment-620525973
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "787bc83a15e54846500bc49900f97954880d65bd",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162401466",
"triggerID" : "787bc83a15e54846500bc49900f97954880d65bd",
"triggerType" : "PUSH"
}, {
"hash" : "787bc83a15e54846500bc49900f97954880d65bd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=367",
"triggerID" : "787bc83a15e54846500bc49900f97954880d65bd",
"triggerType" : "PUSH"
}, {
"hash" : "826e4af475affea37d8d079abf51a653233a1f08",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162423330",
"triggerID" : "826e4af475affea37d8d079abf51a653233a1f08",
"triggerType" : "PUSH"
}, {
"hash" : "826e4af475affea37d8d079abf51a653233a1f08",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=374",
"triggerID" : "826e4af475affea37d8d079abf51a653233a1f08",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 826e4af475affea37d8d079abf51a653233a1f08 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162423330) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=374)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11931: [FLINK-17432][docs-training] Rename Tutorials to Training for better SEO
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11931:
URL: https://github.com/apache/flink/pull/11931#issuecomment-620525973
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "787bc83a15e54846500bc49900f97954880d65bd",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162401466",
"triggerID" : "787bc83a15e54846500bc49900f97954880d65bd",
"triggerType" : "PUSH"
}, {
"hash" : "787bc83a15e54846500bc49900f97954880d65bd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=367",
"triggerID" : "787bc83a15e54846500bc49900f97954880d65bd",
"triggerType" : "PUSH"
}, {
"hash" : "826e4af475affea37d8d079abf51a653233a1f08",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "826e4af475affea37d8d079abf51a653233a1f08",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 787bc83a15e54846500bc49900f97954880d65bd Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162401466) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=367)
* 826e4af475affea37d8d079abf51a653233a1f08 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] alpinegizmo commented on pull request #11931: [FLINK-17432][docs-training] Rename Tutorials to Training for better SEO
Posted by GitBox <gi...@apache.org>.
alpinegizmo commented on pull request #11931:
URL: https://github.com/apache/flink/pull/11931#issuecomment-620575028
I was thinking of this as a training comprised of a set of tutorials and exercises, but I've gone ahead and completely eliminated the usage "tutorial".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #11931: [FLINK-17432][docs-training] Rename Tutorials to Training for better SEO
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11931:
URL: https://github.com/apache/flink/pull/11931#issuecomment-620512103
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 787bc83a15e54846500bc49900f97954880d65bd (Tue Apr 28 10:11:48 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] alpinegizmo edited a comment on pull request #11931: [FLINK-17432][docs-training] Rename Tutorials to Training for better SEO
Posted by GitBox <gi...@apache.org>.
alpinegizmo edited a comment on pull request #11931:
URL: https://github.com/apache/flink/pull/11931#issuecomment-620575028
I was thinking of this as a training comprised of a set of tutorials and exercises, but I've gone ahead and completely eliminated the use of "tutorial".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] alpinegizmo commented on pull request #11931: [FLINK-17432][docs-training] Rename Tutorials to Training for better SEO
Posted by GitBox <gi...@apache.org>.
alpinegizmo commented on pull request #11931:
URL: https://github.com/apache/flink/pull/11931#issuecomment-620510501
@nicok @sjwiesman Perhaps one of you can review this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org