You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/01 13:59:55 UTC
[GitHub] [incubator-tvm] manupa-arm opened a new pull request #5202: [RELAY]
Partition graph codestyle fixes
manupa-arm opened a new pull request #5202: [RELAY] Partition graph codestyle fixes
URL: https://github.com/apache/incubator-tvm/pull/5202
Follow-up PR for codestyle changes for PR #5143
cc : @masahi @zhiics @comaniac
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] comaniac commented on issue #5202: [RELAY]
Partition graph codestyle fixes
Posted by GitBox <gi...@apache.org>.
comaniac commented on issue #5202: [RELAY] Partition graph codestyle fixes
URL: https://github.com/apache/incubator-tvm/pull/5202#issuecomment-607378598
I agree with @masahi. We did that for the doc warning weeks ago and added a checker to CI. We should do that for style too, although the workload of correcting C++ style in an entire code base is definitely in another scale.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi merged pull request #5202: [RELAY] Partition
graph codestyle fixes
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #5202: [RELAY] Partition graph codestyle fixes
URL: https://github.com/apache/incubator-tvm/pull/5202
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on issue #5202: [RELAY] Partition
graph codestyle fixes
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #5202: [RELAY] Partition graph codestyle fixes
URL: https://github.com/apache/incubator-tvm/pull/5202#issuecomment-607369351
Maybe we can set clang tidy up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] manupa-arm commented on issue #5202: [RELAY]
Partition graph codestyle fixes
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on issue #5202: [RELAY] Partition graph codestyle fixes
URL: https://github.com/apache/incubator-tvm/pull/5202#issuecomment-607367832
It would have been nicer to somehow capture this in lint ? Probably using clang-format itself. Are you aware of any prior discussion/PR on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on issue #5202: [RELAY] Partition
graph codestyle fixes
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #5202: [RELAY] Partition graph codestyle fixes
URL: https://github.com/apache/incubator-tvm/pull/5202#issuecomment-607373846
You can probably open a thread in the discussion forum.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] comaniac edited a comment on issue #5202: [RELAY]
Partition graph codestyle fixes
Posted by GitBox <gi...@apache.org>.
comaniac edited a comment on issue #5202: [RELAY] Partition graph codestyle fixes
URL: https://github.com/apache/incubator-tvm/pull/5202#issuecomment-607378598
I agree with @masahi. We did that for the doc warning weeks ago and added a checker to CI. We should do that for style too, although the workload of correcting C++ style for an entire code base is definitely in another scale.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #5202: [RELAY] Partition
graph codestyle fixes
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #5202: [RELAY] Partition graph codestyle fixes
URL: https://github.com/apache/incubator-tvm/pull/5202#issuecomment-607394248
Thanks @manupa-arm @mbaret
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #5202: [RELAY] Partition
graph codestyle fixes
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #5202: [RELAY] Partition graph codestyle fixes
URL: https://github.com/apache/incubator-tvm/pull/5202#issuecomment-607370203
I think it is too late to enforce the style clang-format would choose using lint. We have too many existing code that violates this style (.clang-format file itself was introduced much later in the development).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi edited a comment on issue #5202: [RELAY]
Partition graph codestyle fixes
Posted by GitBox <gi...@apache.org>.
masahi edited a comment on issue #5202: [RELAY] Partition graph codestyle fixes
URL: https://github.com/apache/incubator-tvm/pull/5202#issuecomment-607370203
I think it is too late to enforce the style clang-format would choose using lint. We have too many existing code that violates this style (.clang-format file itself was introduced much later in the development). Actually I don't know what rules `cpplint` is using.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #5202: [RELAY] Partition
graph codestyle fixes
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #5202: [RELAY] Partition graph codestyle fixes
URL: https://github.com/apache/incubator-tvm/pull/5202#issuecomment-607365624
For emacs and clangd users, you can simply do `M-x indent-region` and clangd would indent and format using clang-format + our .clang-format config automatically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on issue #5202: [RELAY] Partition
graph codestyle fixes
Posted by GitBox <gi...@apache.org>.
zhiics commented on issue #5202: [RELAY] Partition graph codestyle fixes
URL: https://github.com/apache/incubator-tvm/pull/5202#issuecomment-607371760
exactly. we will need a lot of fixes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #5202: [RELAY] Partition
graph codestyle fixes
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #5202: [RELAY] Partition graph codestyle fixes
URL: https://github.com/apache/incubator-tvm/pull/5202#issuecomment-607374667
I actually prefer doing the massive style change once and for all, and enforce this style during lint moving forward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] manupa-arm commented on issue #5202: [RELAY]
Partition graph codestyle fixes
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on issue #5202: [RELAY] Partition graph codestyle fixes
URL: https://github.com/apache/incubator-tvm/pull/5202#issuecomment-607372476
How about giving out warnings, initially?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services