You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/05/01 22:41:58 UTC
[GitHub] [nifi] ottobackwards opened a new pull request #4251: NIFI-7420 HandleHttpRequest puts form data content into attributes
ottobackwards opened a new pull request #4251:
URL: https://github.com/apache/nifi/pull/4251
This PR removes the http.param attribute. It contained both the query parameters already captured in http.query.param _and_ the multipart form data names and values, which are captured in the part data, and could be very very large.
Removing the attribute may be a big deal, but since _any_ form data can be large, putting in as an attribute is wrong and duplicitous with the other attribute.
When you filter the part data out, all that is left is the query params, which are also already captured, so I just got rid of the attribute.
I also added a WritesAttribute for http.query.param which was missing.
If it helps, http.param was NOT documented anyways.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [-] Have you written or updated unit tests to verify your changes?
- [-] Have you verified that the full build is successful on both JDK 8 and JDK 11?
- [-] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [-] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [-] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [-] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [-] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4251: NIFI-7420 HandleHttpRequest puts form data content into attributes
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4251:
URL: https://github.com/apache/nifi/pull/4251#issuecomment-624901360
awesome! thanks @markap14
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #4251: NIFI-7420 HandleHttpRequest puts form data content into attributes
Posted by GitBox <gi...@apache.org>.
markap14 commented on pull request #4251:
URL: https://github.com/apache/nifi/pull/4251#issuecomment-624212802
Thanks @ottobackwards I will take a look. I will need to also make sure to update the Migration Guidance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #4251: NIFI-7420 HandleHttpRequest puts form data content into attributes
Posted by GitBox <gi...@apache.org>.
markap14 commented on pull request #4251:
URL: https://github.com/apache/nifi/pull/4251#issuecomment-624900695
Thanks @ottobackwards. Change looks good. +1 merged to master and updated Migration Guidance to reflect the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #4251: NIFI-7420 HandleHttpRequest puts form data content into attributes
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #4251:
URL: https://github.com/apache/nifi/pull/4251#issuecomment-622597436
@markap14 this is your patch of ground from the looks of it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org