Re: [PR] Replace global shading with classloader-realm isolation for plugins [pinot]

["gortiz (via GitHub)" <gi...@apache.org>]

gortiz commented on PR #18459:
URL: https://github.com/apache/pinot/pull/18459#issuecomment-5498043548

   I'm splitting this PR into smaller pieces to make it easier to review:
   
   1. A packaging-only PR with no classloading changes: remove relocation shading (which currently relocates only 3 packages, and classpath ordering means plugins already run against the distribution's copies anyway) and replace the per-plugin fat-jars with thin jars plus a shared `plugins/libs/` directory. Same effective classpath, much cheaper `-Pbin-dist` builds, and dependency version conflicts become visible instead of hidden inside uber-jars.
   2. A follow-up PR rebased on top of it carrying the classloader-realm isolation work (plugin realms, realm-aware service discovery, plugin verifier).
   
   Converting this PR to a draft in the meantime.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org