You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Dineshkumar Yadav <di...@outlook.com> on 2025/05/17 06:29:20 UTC

Re: Review Request 75388: RANGER-5209 : User source is not getting updated on the Ranger Access Audit page

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75388/
-----------------------------------------------------------

(Updated May 17, 2025, 6:29 a.m.)


Review request for ranger, Kishor Gollapalliwar, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Vyom Tiwari.


Changes
-------

fixed first audit loading issue and added unit test


Bugs: RANGER-5209
    https://issues.apache.org/jira/browse/RANGER-5209


Repository: ranger


Description
-------

User source is not getting updated on the Ranger Access Audit page


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java 97f61b495 
  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java e415924fa 
  security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 520241268 
  security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 46ee557c1 
  security-admin/src/main/java/org/apache/ranger/view/VXAccessAudit.java 49a4f8d39 
  security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js 21a163531 
  security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx b5cae7a59 
  security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 699e4ce1f 
  security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java 04ef82613 


Diff: https://reviews.apache.org/r/75388/diff/2/

Changes: https://reviews.apache.org/r/75388/diff/1-2/


Testing
-------

Tested manually


Thanks,

Dineshkumar Yadav


Re: Review Request 75388: RANGER-5209 : User source is not getting updated on the Ranger Access Audit page

Posted by Ramesh Mani <rm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75388/#review227326
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java
Lines 2844 (patched)
<https://reviews.apache.org/r/75388/#comment315573>

    AssetREST.getAccessLogs() => XUserMgr.setAccessAuditsUserSource()


- Ramesh Mani


On May 17, 2025, 6:29 a.m., Dineshkumar Yadav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75388/
> -----------------------------------------------------------
> 
> (Updated May 17, 2025, 6:29 a.m.)
> 
> 
> Review request for ranger, Kishor Gollapalliwar, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Vyom Tiwari.
> 
> 
> Bugs: RANGER-5209
>     https://issues.apache.org/jira/browse/RANGER-5209
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> User source is not getting updated on the Ranger Access Audit page
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java 97f61b495 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java e415924fa 
>   security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 520241268 
>   security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 46ee557c1 
>   security-admin/src/main/java/org/apache/ranger/view/VXAccessAudit.java 49a4f8d39 
>   security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js 21a163531 
>   security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx b5cae7a59 
>   security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 699e4ce1f 
>   security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java 04ef82613 
> 
> 
> Diff: https://reviews.apache.org/r/75388/diff/2/
> 
> 
> Testing
> -------
> 
> Tested manually
> 
> 
> Thanks,
> 
> Dineshkumar Yadav
> 
>


Re: Review Request 75388: RANGER-5209 : User source is not getting updated on the Ranger Access Audit page

Posted by Ramesh Mani <rm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75388/#review227327
-----------------------------------------------------------



Fix it and ship it.

- Ramesh Mani


On May 17, 2025, 6:29 a.m., Dineshkumar Yadav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75388/
> -----------------------------------------------------------
> 
> (Updated May 17, 2025, 6:29 a.m.)
> 
> 
> Review request for ranger, Kishor Gollapalliwar, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Vyom Tiwari.
> 
> 
> Bugs: RANGER-5209
>     https://issues.apache.org/jira/browse/RANGER-5209
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> User source is not getting updated on the Ranger Access Audit page
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java 97f61b495 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java e415924fa 
>   security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 520241268 
>   security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 46ee557c1 
>   security-admin/src/main/java/org/apache/ranger/view/VXAccessAudit.java 49a4f8d39 
>   security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js 21a163531 
>   security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx b5cae7a59 
>   security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 699e4ce1f 
>   security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java 04ef82613 
> 
> 
> Diff: https://reviews.apache.org/r/75388/diff/2/
> 
> 
> Testing
> -------
> 
> Tested manually
> 
> 
> Thanks,
> 
> Dineshkumar Yadav
> 
>


Re: Review Request 75388: RANGER-5209 : User source is not getting updated on the Ranger Access Audit page

Posted by Ramesh Mani <rm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75388/#review227329
-----------------------------------------------------------


Ship it!




Ship It!

- Ramesh Mani


On May 26, 2025, 8:19 a.m., Dineshkumar Yadav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75388/
> -----------------------------------------------------------
> 
> (Updated May 26, 2025, 8:19 a.m.)
> 
> 
> Review request for ranger, Kishor Gollapalliwar, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Vyom Tiwari.
> 
> 
> Bugs: RANGER-5209
>     https://issues.apache.org/jira/browse/RANGER-5209
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> User source is not getting updated on the Ranger Access Audit page
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java 97f61b495 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java e415924fa 
>   security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 520241268 
>   security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 46ee557c1 
>   security-admin/src/main/java/org/apache/ranger/view/VXAccessAudit.java 49a4f8d39 
>   security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js 21a163531 
>   security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx b5cae7a59 
>   security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 699e4ce1f 
>   security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java 04ef82613 
> 
> 
> Diff: https://reviews.apache.org/r/75388/diff/3/
> 
> 
> Testing
> -------
> 
> Tested manually
> 
> 
> Thanks,
> 
> Dineshkumar Yadav
> 
>


Re: Review Request 75388: RANGER-5209 : User source is not getting updated on the Ranger Access Audit page

Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75388/#review227335
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java
Lines 2844 (patched)
<https://reviews.apache.org/r/75388/#comment315575>

    Can we log at error level? May be stacktrace in the debug


- Sailaja Polavarapu


On May 26, 2025, 8:19 a.m., Dineshkumar Yadav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75388/
> -----------------------------------------------------------
> 
> (Updated May 26, 2025, 8:19 a.m.)
> 
> 
> Review request for ranger, Kishor Gollapalliwar, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Vyom Tiwari.
> 
> 
> Bugs: RANGER-5209
>     https://issues.apache.org/jira/browse/RANGER-5209
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> User source is not getting updated on the Ranger Access Audit page
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java 97f61b495 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java e415924fa 
>   security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 520241268 
>   security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 46ee557c1 
>   security-admin/src/main/java/org/apache/ranger/view/VXAccessAudit.java 49a4f8d39 
>   security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js 21a163531 
>   security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx b5cae7a59 
>   security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 699e4ce1f 
>   security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java 04ef82613 
> 
> 
> Diff: https://reviews.apache.org/r/75388/diff/3/
> 
> 
> Testing
> -------
> 
> Tested manually
> 
> 
> Thanks,
> 
> Dineshkumar Yadav
> 
>


Re: Review Request 75388: RANGER-5209 : User source is not getting updated on the Ranger Access Audit page

Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75388/
-----------------------------------------------------------

(Updated June 13, 2025, 7:17 a.m.)


Review request for ranger, Kishor Gollapalliwar, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Vyom Tiwari.


Bugs: RANGER-5209
    https://issues.apache.org/jira/browse/RANGER-5209


Repository: ranger


Description
-------

User source is not getting updated on the Ranger Access Audit page


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java 97f61b495 
  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java e415924fa 
  security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 520241268 
  security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 46ee557c1 
  security-admin/src/main/java/org/apache/ranger/view/VXAccessAudit.java 49a4f8d39 
  security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js 21a163531 
  security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx b5cae7a59 
  security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 699e4ce1f 
  security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java 04ef82613 


Diff: https://reviews.apache.org/r/75388/diff/4/

Changes: https://reviews.apache.org/r/75388/diff/3-4/


Testing
-------

Tested manually


Thanks,

Dineshkumar Yadav


Re: Review Request 75388: RANGER-5209 : User source is not getting updated on the Ranger Access Audit page

Posted by Dineshkumar Yadav <di...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75388/
-----------------------------------------------------------

(Updated May 26, 2025, 8:19 a.m.)


Review request for ranger, Kishor Gollapalliwar, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Vyom Tiwari.


Bugs: RANGER-5209
    https://issues.apache.org/jira/browse/RANGER-5209


Repository: ranger


Description
-------

User source is not getting updated on the Ranger Access Audit page


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java 97f61b495 
  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java e415924fa 
  security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 520241268 
  security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 46ee557c1 
  security-admin/src/main/java/org/apache/ranger/view/VXAccessAudit.java 49a4f8d39 
  security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js 21a163531 
  security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx b5cae7a59 
  security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 699e4ce1f 
  security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java 04ef82613 


Diff: https://reviews.apache.org/r/75388/diff/3/

Changes: https://reviews.apache.org/r/75388/diff/2-3/


Testing
-------

Tested manually


Thanks,

Dineshkumar Yadav