You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/14 20:47:02 UTC
[GitHub] [beam] KevinGG commented on a change in pull request #17044: [BEAM-14071] Enabling Flink on Dataproc for Interactive Beam
KevinGG commented on a change in pull request #17044:
URL: https://github.com/apache/beam/pull/17044#discussion_r826361564
##########
File path: sdks/python/apache_beam/runners/interactive/cache_manager.py
##########
@@ -190,7 +190,14 @@ def __init__(self, cache_dir=None, cache_format='text'):
def size(self, *labels):
if self.exists(*labels):
- return sum(os.path.getsize(path) for path in self._match(*labels))
+ matched_path = self._match(*labels)
+ # if any matched path has a gs:// prefix, it must be cached on GCS
+ if 'gs://' in matched_path[0]:
Review comment:
can `matched_path` be empty? If so, `if matched_path and 'gs://' in matched_path[0]`.
##########
File path: sdks/python/apache_beam/runners/interactive/dataproc/dataproc_cluster_manager.py
##########
@@ -167,8 +166,7 @@ def create_flink_cluster(self) -> None:
},
'gce_cluster_config': {
'metadata': {
- 'flink-start-yarn-session': 'true',
- 'PIP_PACKAGES': 'apache-beam[gcp]=={}'.format(beam_version)
Review comment:
Are we sure that as long as we provide the environment_config, the installation of a Python SDK on the cluster node is not needed?
##########
File path: sdks/python/apache_beam/runners/interactive/dataproc/dataproc_cluster_manager.py
##########
@@ -167,8 +166,7 @@ def create_flink_cluster(self) -> None:
},
'gce_cluster_config': {
'metadata': {
- 'flink-start-yarn-session': 'true',
- 'PIP_PACKAGES': 'apache-beam[gcp]=={}'.format(beam_version)
Review comment:
So we sure that as long as we provide the environment_config, the installation of a Python SDK on the cluster node is not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org