You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "enkidulan (via GitHub)" <gi...@apache.org> on 2024/04/03 05:33:59 UTC
[I] Support creating tags [iceberg-python]
enkidulan opened a new issue, #573:
URL: https://github.com/apache/iceberg-python/issues/573
### Feature Request / Improvement
Historical tags in iceberg docs - https://iceberg.apache.org/docs/1.5.0/branching/#historical-tags
Not sure if it was intentional behavior, but pyiceberg `v0.6.0` allowed tagging by using public `set_ref_snapshot` method:
```py
with table.transaction() as transaction:
transaction.set_ref_snapshot(
snapshot_id=snapshot_id,
parent_snapshot_id=snapshot_id,
ref_name=revision,
type="tag",
)
```
The new dev version (the current main branch) has deprecated the `set_ref_snapshot` method, so I can't find a way to create a tag using public methods on the transaction object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Support creating tags [iceberg-python]
Posted by "enkidulan (via GitHub)" <gi...@apache.org>.
enkidulan commented on issue #573:
URL: https://github.com/apache/iceberg-python/issues/573#issuecomment-2043897402
> Are you interested in creating the API for this? :)
I am. I'll try to create a PR this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Support creating tags [iceberg-python]
Posted by "enkidulan (via GitHub)" <gi...@apache.org>.
enkidulan commented on issue #573:
URL: https://github.com/apache/iceberg-python/issues/573#issuecomment-2033571970
For the reference, I was able to make a tag only by using some private properties of the transaction object:
```py
from pyiceberg.table import SetSnapshotRefUpdate, update_table_metadata
with table.transaction() as txn:
update = SetSnapshotRefUpdate(
ref_name=tag,
type="tag",
snapshot_id=snapshot_id,
max_ref_age_ms=None,
max_snapshot_age_ms=None,
min_snapshots_to_keep=None,
)
txn._updates = [update]
txn.table_metadata = update_table_metadata(txn.table_metadata, [update])
```
This seems to work fine as a temporary workaround for development purposes, but it would great to have a public method for creating tags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Support creating tags [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on issue #573:
URL: https://github.com/apache/iceberg-python/issues/573#issuecomment-2039233700
@enkidulan Thanks for reaching out here. Are you interested in creating the API for this? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Support creating tags [iceberg-python]
Posted by "chinmay-bhat (via GitHub)" <gi...@apache.org>.
chinmay-bhat commented on issue #573:
URL: https://github.com/apache/iceberg-python/issues/573#issuecomment-2106300079
@Fokko I saw this issue has been inactive for over a month, so I created a PR that might close the issue. Please review when possible :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org