You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apisix.apache.org by YuanSheng Wang <me...@apache.org> on 2020/08/01 05:53:01 UTC
[DISCUSS] How about we disable the plugins `proxy-cache` and
`proxy-mirror` by default?
Hi:
if we disable plugin `proxy-cache` and `proxy-mirror` and remove them from
`conf/nginx.conf`,
It will increase APISIX performance by 10%.
proxy-cache conf [1]
proxy-mirror conf [2]
I think this is useful for most users.
[1] https://github.com/apache/apisix/blob/master/bin/apisix#L462
[2] https://github.com/apache/apisix/blob/master/bin/apisix#L490
--
*MembPhis*
My GitHub: https://github.com/membphis
Apache APISIX: https://github.com/apache/incubator-apisix
Re: [DISCUSS] How about we disable the plugins `proxy-cache` and
`proxy-mirror` by default?
Posted by Ming Wen <we...@apache.org>.
-1 binding.
my reason: performance is not the first goal of Apache APISIX.
We should give priority to satisfying user functions.
And do not submit a PR and merge before reaching a consensus on the mailing
list.
This is a violation of the apache way.
Thanks,
Ming Wen, Apache APISIX & Apache SkyWalking
Twitter: _WenMing
YuanSheng Wang <me...@apache.org> 于2020年8月4日周二 下午7:08写道：
> On Sat, Aug 1, 2020 at 8:01 PM agile6v <ag...@apache.org> wrote:
>
>> Hi YuanSheng
>>
>> AFAIK, If these plugins are not configured through the admin api, they
>> will not be enabled by default. Also How is the 10% performance loss
>> verified?
>>
>
> that is the benchmark result:
>
> enable all plugin: the QPS is about 20118 req/sec.
> remove the nginx.conf of plugin `proxy-cache` and `proxy-mirror`: the QPS
> is about 22448 req/sec.
>
> [image: image.png]
>
>
>>
>> Thanks.
>>
>> On 2020/08/01 05:53:01, YuanSheng Wang <me...@apache.org> wrote:
>> > Hi:
>> >
>> > if we disable plugin `proxy-cache` and `proxy-mirror` and remove them
>> from
>> > `conf/nginx.conf`,
>> > It will increase APISIX performance by 10%.
>> >
>> > proxy-cache conf [1]
>> > proxy-mirror conf [2]
>> >
>> > I think this is useful for most users.
>> >
>> > [1] https://github.com/apache/apisix/blob/master/bin/apisix#L462
>> > [2] https://github.com/apache/apisix/blob/master/bin/apisix#L490
>> >
>> > --
>> >
>> > *MembPhis*
>> > My GitHub: https://github.com/membphis
>> > Apache APISIX: https://github.com/apache/incubator-apisix
>> >
>>
>
>
> --
>
> *MembPhis*
> My GitHub: https://github.com/membphis
> Apache APISIX: https://github.com/apache/incubator-apisix
>
Re: [DISCUSS] How about we disable the plugins `proxy-cache` and
`proxy-mirror` by default?
Posted by YuanSheng Wang <me...@apache.org>.
On Sat, Aug 1, 2020 at 8:01 PM agile6v <ag...@apache.org> wrote:
> Hi YuanSheng
>
> AFAIK, If these plugins are not configured through the admin api, they
> will not be enabled by default. Also How is the 10% performance loss
> verified?
>
that is the benchmark result:
enable all plugin: the QPS is about 20118 req/sec.
remove the nginx.conf of plugin `proxy-cache` and `proxy-mirror`: the QPS
is about 22448 req/sec.
[image: image.png]
>
> Thanks.
>
> On 2020/08/01 05:53:01, YuanSheng Wang <me...@apache.org> wrote:
> > Hi:
> >
> > if we disable plugin `proxy-cache` and `proxy-mirror` and remove them
> from
> > `conf/nginx.conf`,
> > It will increase APISIX performance by 10%.
> >
> > proxy-cache conf [1]
> > proxy-mirror conf [2]
> >
> > I think this is useful for most users.
> >
> > [1] https://github.com/apache/apisix/blob/master/bin/apisix#L462
> > [2] https://github.com/apache/apisix/blob/master/bin/apisix#L490
> >
> > --
> >
> > *MembPhis*
> > My GitHub: https://github.com/membphis
> > Apache APISIX: https://github.com/apache/incubator-apisix
> >
>
--
*MembPhis*
My GitHub: https://github.com/membphis
Apache APISIX: https://github.com/apache/incubator-apisix
Re: [DISCUSS] How about we disable the plugins `proxy-cache` and
`proxy-mirror` by default?
Posted by Linsir Wu <li...@apache.org>.
+1, they will not be enabled by default if the user changes it by
config.yaml or admin api
agile6v <ag...@apache.org> 于2020年8月1日周六 下午8:01写道：
>
> Hi YuanSheng
>
> AFAIK, If these plugins are not configured through the admin api, they will not be enabled by default. Also How is the 10% performance loss verified?
>
> Thanks.
>
> On 2020/08/01 05:53:01, YuanSheng Wang <me...@apache.org> wrote:
> > Hi:
> >
> > if we disable plugin `proxy-cache` and `proxy-mirror` and remove them from
> > `conf/nginx.conf`,
> > It will increase APISIX performance by 10%.
> >
> > proxy-cache conf [1]
> > proxy-mirror conf [2]
> >
> > I think this is useful for most users.
> >
> > [1] https://github.com/apache/apisix/blob/master/bin/apisix#L462
> > [2] https://github.com/apache/apisix/blob/master/bin/apisix#L490
> >
> > --
> >
> > *MembPhis*
> > My GitHub: https://github.com/membphis
> > Apache APISIX: https://github.com/apache/incubator-apisix
> >
Re: [DISCUSS] How about we disable the plugins `proxy-cache` and
`proxy-mirror` by default?
Posted by YuanSheng Wang <me...@apache.org>.
I make a test right now, here is the result:
https://github.com/apache/apisix/pull/1968#issue-461617117
On Sun, Aug 2, 2020 at 9:33 AM YuanSheng Wang <me...@apache.org> wrote:
> The Apache APISIX just disabled the plugin proxy-cache and proxy-mirror
> in `conf/config.yaml` by default.
>
> And the user can enable them by update the conf/config.yaml in an
> easy way.
>
>
> On Sun, Aug 2, 2020 at 8:57 AM YuanSheng Wang <me...@apache.org> wrote:
>
>> Hi:
>>
>> If the user did not enable those plugin, we do not generate the
>> conf/nginx.conf content required by these plugins in bin/apisix.
>>
>> I make a test if we can remove the related nginx.conf for plugin proxy-cache
>> and proxy-mirror, the apisix will better performance.
>>
>> I think we can disable them in this way, and the user can enable them by
>> manual(require `apisix restart`).
>>
>> ```yaml
>> plugins: # plugin list
>> # - proxy-cache
>> # - proxy-mirror
>> - example-plugin
>> - limit-req
>> - limit-count
>> ```
>>
>> On Sat, Aug 1, 2020 at 8:01 PM agile6v <ag...@apache.org> wrote:
>>
>>> Hi YuanSheng
>>>
>>> AFAIK, If these plugins are not configured through the admin api, they
>>> will not be enabled by default. Also How is the 10% performance loss
>>> verified?
>>>
>>> Thanks.
>>>
>>> On 2020/08/01 05:53:01, YuanSheng Wang <me...@apache.org> wrote:
>>> > Hi:
>>> >
>>> > if we disable plugin `proxy-cache` and `proxy-mirror` and remove them
>>> from
>>> > `conf/nginx.conf`,
>>> > It will increase APISIX performance by 10%.
>>> >
>>> > proxy-cache conf [1]
>>> > proxy-mirror conf [2]
>>> >
>>> > I think this is useful for most users.
>>> >
>>> > [1] https://github.com/apache/apisix/blob/master/bin/apisix#L462
>>> > [2] https://github.com/apache/apisix/blob/master/bin/apisix#L490
>>> >
>>> > --
>>> >
>>> > *MembPhis*
>>> > My GitHub: https://github.com/membphis
>>> > Apache APISIX: https://github.com/apache/incubator-apisix
>>> >
>>>
>>
>>
>> --
>>
>> *MembPhis*
>> My GitHub: https://github.com/membphis
>> Apache APISIX: https://github.com/apache/incubator-apisix
>>
>
>
> --
>
> *MembPhis*
> My GitHub: https://github.com/membphis
> Apache APISIX: https://github.com/apache/incubator-apisix
>
--
*MembPhis*
My GitHub: https://github.com/membphis
Apache APISIX: https://github.com/apache/incubator-apisix
Re: [DISCUSS] How about we disable the plugins `proxy-cache` and
`proxy-mirror` by default?
Posted by YuanSheng Wang <me...@apache.org>.
The Apache APISIX just disabled the plugin proxy-cache and proxy-mirror in
`conf/config.yaml` by default.
And the user can enable them by update the conf/config.yaml in an easy way.
On Sun, Aug 2, 2020 at 8:57 AM YuanSheng Wang <me...@apache.org> wrote:
> Hi:
>
> If the user did not enable those plugin, we do not generate the
> conf/nginx.conf content required by these plugins in bin/apisix.
>
> I make a test if we can remove the related nginx.conf for plugin proxy-cache
> and proxy-mirror, the apisix will better performance.
>
> I think we can disable them in this way, and the user can enable them by
> manual(require `apisix restart`).
>
> ```yaml
> plugins: # plugin list
> # - proxy-cache
> # - proxy-mirror
> - example-plugin
> - limit-req
> - limit-count
> ```
>
> On Sat, Aug 1, 2020 at 8:01 PM agile6v <ag...@apache.org> wrote:
>
>> Hi YuanSheng
>>
>> AFAIK, If these plugins are not configured through the admin api, they
>> will not be enabled by default. Also How is the 10% performance loss
>> verified?
>>
>> Thanks.
>>
>> On 2020/08/01 05:53:01, YuanSheng Wang <me...@apache.org> wrote:
>> > Hi:
>> >
>> > if we disable plugin `proxy-cache` and `proxy-mirror` and remove them
>> from
>> > `conf/nginx.conf`,
>> > It will increase APISIX performance by 10%.
>> >
>> > proxy-cache conf [1]
>> > proxy-mirror conf [2]
>> >
>> > I think this is useful for most users.
>> >
>> > [1] https://github.com/apache/apisix/blob/master/bin/apisix#L462
>> > [2] https://github.com/apache/apisix/blob/master/bin/apisix#L490
>> >
>> > --
>> >
>> > *MembPhis*
>> > My GitHub: https://github.com/membphis
>> > Apache APISIX: https://github.com/apache/incubator-apisix
>> >
>>
>
>
> --
>
> *MembPhis*
> My GitHub: https://github.com/membphis
> Apache APISIX: https://github.com/apache/incubator-apisix
>
--
*MembPhis*
My GitHub: https://github.com/membphis
Apache APISIX: https://github.com/apache/incubator-apisix
Re: [DISCUSS] How about we disable the plugins `proxy-cache` and
`proxy-mirror` by default?
Posted by YuanSheng Wang <me...@apache.org>.
Hi:
If the user did not enable those plugin, we do not generate the
conf/nginx.conf content required by these plugins in bin/apisix.
I make a test if we can remove the related nginx.conf for plugin proxy-cache
and proxy-mirror, the apisix will better performance.
I think we can disable them in this way, and the user can enable them by
manual(require `apisix restart`).
```yaml
plugins: # plugin list
# - proxy-cache
# - proxy-mirror
- example-plugin
- limit-req
- limit-count
```
On Sat, Aug 1, 2020 at 8:01 PM agile6v <ag...@apache.org> wrote:
> Hi YuanSheng
>
> AFAIK, If these plugins are not configured through the admin api, they
> will not be enabled by default. Also How is the 10% performance loss
> verified?
>
> Thanks.
>
> On 2020/08/01 05:53:01, YuanSheng Wang <me...@apache.org> wrote:
> > Hi:
> >
> > if we disable plugin `proxy-cache` and `proxy-mirror` and remove them
> from
> > `conf/nginx.conf`,
> > It will increase APISIX performance by 10%.
> >
> > proxy-cache conf [1]
> > proxy-mirror conf [2]
> >
> > I think this is useful for most users.
> >
> > [1] https://github.com/apache/apisix/blob/master/bin/apisix#L462
> > [2] https://github.com/apache/apisix/blob/master/bin/apisix#L490
> >
> > --
> >
> > *MembPhis*
> > My GitHub: https://github.com/membphis
> > Apache APISIX: https://github.com/apache/incubator-apisix
> >
>
--
*MembPhis*
My GitHub: https://github.com/membphis
Apache APISIX: https://github.com/apache/incubator-apisix
Re: [DISCUSS] How about we disable the plugins `proxy-cache` and `proxy-mirror` by default?
Posted by agile6v <ag...@apache.org>.
Hi YuanSheng
AFAIK, If these plugins are not configured through the admin api, they will not be enabled by default. Also How is the 10% performance loss verified?
Thanks.
On 2020/08/01 05:53:01, YuanSheng Wang <me...@apache.org> wrote:
> Hi:
>
> if we disable plugin `proxy-cache` and `proxy-mirror` and remove them from
> `conf/nginx.conf`,
> It will increase APISIX performance by 10%.
>
> proxy-cache conf [1]
> proxy-mirror conf [2]
>
> I think this is useful for most users.
>
> [1] https://github.com/apache/apisix/blob/master/bin/apisix#L462
> [2] https://github.com/apache/apisix/blob/master/bin/apisix#L490
>
> --
>
> *MembPhis*
> My GitHub: https://github.com/membphis
> Apache APISIX: https://github.com/apache/incubator-apisix
>
Re: [DISCUSS] How about we disable the plugins `proxy-cache` and
`proxy-mirror` by default?
Posted by "Li Ling(Lien)" <li...@apache.org>.
I think we can make both proxy-cache and proxy-mirror configurable in
confyg.yaml,
YuanSheng Wang <me...@apache.org> 于2020年8月1日周六 下午1:53写道：
> Hi:
>
> if we disable plugin `proxy-cache` and `proxy-mirror` and remove them from
> `conf/nginx.conf`,
> It will increase APISIX performance by 10%.
>
> proxy-cache conf [1]
> proxy-mirror conf [2]
>
> I think this is useful for most users.
>
> [1] https://github.com/apache/apisix/blob/master/bin/apisix#L462
> [2] https://github.com/apache/apisix/blob/master/bin/apisix#L490
>
> --
>
> *MembPhis*
> My GitHub: https://github.com/membphis
> Apache APISIX: https://github.com/apache/incubator-apisix
>