[GitHub] akshayrai commented on a change in pull request #3450: [TE] Reset default lookback for merging anomalies

[GitBox <gi...@apache.org>]

akshayrai commented on a change in pull request #3450: [TE] Reset default lookback for merging anomalies
URL: https://github.com/apache/incubator-pinot/pull/3450#discussion_r232866031
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/anomaly/merge/AnomalyMergeConfig.java
 ##########
 @@ -39,7 +39,10 @@
 public class AnomalyMergeConfig {
   private AnomalyMergeStrategy mergeStrategy = AnomalyMergeStrategy.FUNCTION;
   private long sequentialAllowedGap = 30_000; // 30 seconds
-  private long maxMergeDurationLength = 12 * 60 * 60 * 1000; // 12 hours
+
+  // Look back for 2 days to accommodate merging of anomalies in daily metrics
+  private long maxMergeDurationLength = 48 * 60 * 60 * 1000; // 48 hours
 
 Review comment:
   Well there is no perfect number, but if we set it to something big, say 7 days, then we might end up merging anomalies and have an anomaly which spans for 7 days. This could end up swallowing critical alerts which we may want to avoid.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org