You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alinaliBQ (via GitHub)" <gi...@apache.org> on 2026/01/02 19:54:00 UTC

Re: [PR] MINOR: [C++][FlightRPC] Clarify IsAutoUnique equivalence between ODBC 2.0 and 3.0+ [arrow]

alinaliBQ commented on code in PR #48689:
URL: https://github.com/apache/arrow/pull/48689#discussion_r2658316125


##########
cpp/src/arrow/flight/sql/odbc/odbc_impl/flight_sql_result_set_metadata.cc:
##########
@@ -222,7 +222,9 @@ Updatability FlightSqlResultSetMetadata::GetUpdatable(int column_position) {
 bool FlightSqlResultSetMetadata::IsAutoUnique(int column_position) {
   ColumnMetadata metadata = GetMetadata(schema_->field(column_position - 1));
 
-  // TODO: Is AutoUnique equivalent to AutoIncrement?
+  // AUTO_UNIQUE_VALUE (ODBC 3.0+) is equivalent to
+  // AUTO_INCREMENT (ODBC 2.0). Both indicate columns
+  // that automatically generate unique values.

Review Comment:
   Yes the statement is correct. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org