You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/05/07 01:17:15 UTC

[GitHub] [hudi] nsivabalan commented on pull request #2915: [HUDI-251] Adds JDBC source support for DeltaStreamer

nsivabalan commented on pull request #2915:
URL: https://github.com/apache/hudi/pull/2915#issuecomment-833988217


   Can we add tests for these scenarios
   1. no matching rows with incremental fetch. lets say everything is caught up. 
   2. records in source table range from 0 to 100. you set checkpoint as 200. again, this should return empty set. 
   3. records in source table range from 100 to 200. checkpoint is set to 50 and source limit is 50. 
   4. Do we have tests when source table has more records than source limit. something like (3) above. 
   5. Write one long running test (10 iterations of incremental fetch). 
   
   Orthogonal point: 
   Did we consider option to renaming columns when inserting to hudi. not required in this diff. but in general. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org