You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/10/12 13:54:00 UTC

[jira] [Work logged] (HIVE-26627) Remove HiveRelBuilder.aggregateCall override and refactor callers to use existing public methods

     [ https://issues.apache.org/jira/browse/HIVE-26627?focusedWorklogId=816174&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-816174 ]

ASF GitHub Bot logged work on HIVE-26627:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Oct/22 13:53
            Start Date: 12/Oct/22 13:53
    Worklog Time Spent: 10m 
      Work Description: zabetak opened a new pull request, #3668:
URL: https://github.com/apache/hive/pull/3668

   ### Why are the changes needed?
   1. Reduce maintenance overhead
   2. Improve code readability
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   Existing tests




Issue Time Tracking
-------------------

            Worklog Id:     (was: 816174)
    Remaining Estimate: 0h
            Time Spent: 10m

> Remove HiveRelBuilder.aggregateCall override and refactor callers to use existing public methods
> ------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-26627
>                 URL: https://issues.apache.org/jira/browse/HIVE-26627
>             Project: Hive
>          Issue Type: Task
>          Components: CBO
>            Reporter: Stamatis Zampetakis
>            Assignee: Stamatis Zampetakis
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The HiveRelBuilder overrides [aggregateCall|https://github.com/apache/hive/blob/8c3567ea8e423b202cde370f4d3fb401bcc23e46/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelBuilder.java#L246] from its superclass simply to expose and use it in HiveRewriteToDataSketchesRules. 
> However, there is no real need to override this method since we can achieve the same outcome by using existing methods in RelBuilder which are easier to use and understand. Furthermore it is safer to depend on public APIs since are more stable in general.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)