You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/10/07 14:02:04 UTC
[GitHub] [maven-archetype] Serranya opened a new pull request #59: [ARCHETYPE-606] - There is no way to include .gitignore files for the jar goal
Serranya opened a new pull request #59:
URL: https://github.com/apache/maven-archetype/pull/59
It was impossible to include files which are by default excluded
by plexus-archiver like .gitignore. This patch enables plexus-archiver
to add these files.
I also tried to add an integration test. Sadly it seems like the invoker-plugin also ignores the .gitignore files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] rfscholte commented on a change in pull request #59: [ARCHETYPE-606] - There is no way to include .gitignore files for the jar goal
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #59:
URL: https://github.com/apache/maven-archetype/pull/59#discussion_r512194872
##########
File path: maven-archetype-plugin/src/it/projects/ARCHETYPE-606_include-gitignore/src/test/resources/projects/basic/verify.groovy
##########
@@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+println( 'Yeah Baby, it rocks!' )
Review comment:
pretty bad verification scripts... with this content the file should be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] Serranya commented on pull request #59: [ARCHETYPE-606] - There is no way to include .gitignore files for the jar goal
Posted by GitBox <gi...@apache.org>.
Serranya commented on pull request #59:
URL: https://github.com/apache/maven-archetype/pull/59#issuecomment-706988963
I addressed the comments on the code an got the IT working.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] Serranya commented on pull request #59: [ARCHETYPE-606] - There is no way to include .gitignore files for the jar goal
Posted by GitBox <gi...@apache.org>.
Serranya commented on pull request #59:
URL: https://github.com/apache/maven-archetype/pull/59#issuecomment-708648655
Is there anything that I can do get this merged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] rfscholte commented on pull request #59: [ARCHETYPE-606] - There is no way to include .gitignore files for the jar goal
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #59:
URL: https://github.com/apache/maven-archetype/pull/59#issuecomment-706123891
try using `setup.groovy` to generate the `.gitignore`. And I think that `fs.setUsingDefaultExcludes( false );` is too aggressive. It probably makes sense to have a parameter to adjust or overwrite the defaultExcludes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] Serranya commented on a change in pull request #59: [ARCHETYPE-606] - There is no way to include .gitignore files for the jar goal
Posted by GitBox <gi...@apache.org>.
Serranya commented on a change in pull request #59:
URL: https://github.com/apache/maven-archetype/pull/59#discussion_r512722797
##########
File path: maven-archetype-plugin/src/it/projects/ARCHETYPE-606_include-gitignore/setup.bsh
##########
@@ -0,0 +1,30 @@
+/*
Review comment:
I changed the script to groovy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] rfscholte commented on a change in pull request #59: [ARCHETYPE-606] - There is no way to include .gitignore files for the jar goal
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #59:
URL: https://github.com/apache/maven-archetype/pull/59#discussion_r512193003
##########
File path: maven-archetype-plugin/src/it/projects/ARCHETYPE-606_include-gitignore/invoker.properties
##########
@@ -0,0 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+invoker.goals = clean integration-test
Review comment:
`invoker.goals = verify` should be enough
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] Serranya commented on pull request #59: [ARCHETYPE-606] - There is no way to include .gitignore files for the jar goal
Posted by GitBox <gi...@apache.org>.
Serranya commented on pull request #59:
URL: https://github.com/apache/maven-archetype/pull/59#issuecomment-716633848
@rfscholte @elharo Hi, can you please let me know about the status of this PR? Is there something preventing it from being merged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] Serranya commented on pull request #59: [ARCHETYPE-606] - There is no way to include .gitignore files for the jar goal
Posted by GitBox <gi...@apache.org>.
Serranya commented on pull request #59:
URL: https://github.com/apache/maven-archetype/pull/59#issuecomment-717269741
@rfscholte Please take another look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] rfscholte commented on a change in pull request #59: [ARCHETYPE-606] - There is no way to include .gitignore files for the jar goal
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #59:
URL: https://github.com/apache/maven-archetype/pull/59#discussion_r512193702
##########
File path: maven-archetype-plugin/src/it/projects/ARCHETYPE-606_include-gitignore/setup.bsh
##########
@@ -0,0 +1,30 @@
+/*
Review comment:
nowadays we prefer groovy over bash
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] rfscholte commented on pull request #59: [ARCHETYPE-606] - There is no way to include .gitignore files for the jar goal
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #59:
URL: https://github.com/apache/maven-archetype/pull/59#issuecomment-706123891
try using `setup.groovy` to generate the `.gitignore`. And I think that `fs.setUsingDefaultExcludes( false );` is too aggressive. It probably makes sense to have a parameter to adjust or overwrite the defaultExcludes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] Serranya commented on pull request #59: [ARCHETYPE-606] - There is no way to include .gitignore files for the jar goal
Posted by GitBox <gi...@apache.org>.
Serranya commented on pull request #59:
URL: https://github.com/apache/maven-archetype/pull/59#issuecomment-706171167
I made the hehaviour configurable. I will try generating the .gitignore next. The test that I have commit does not work yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] Serranya commented on a change in pull request #59: [ARCHETYPE-606] - There is no way to include .gitignore files for the jar goal
Posted by GitBox <gi...@apache.org>.
Serranya commented on a change in pull request #59:
URL: https://github.com/apache/maven-archetype/pull/59#discussion_r512722953
##########
File path: maven-archetype-plugin/src/it/projects/ARCHETYPE-606_include-gitignore/src/test/resources/projects/basic/verify.groovy
##########
@@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+println( 'Yeah Baby, it rocks!' )
Review comment:
I removed the file. It is not needed for the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] elharo commented on a change in pull request #59: [ARCHETYPE-606] - There is no way to include .gitignore files for the jar goal
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #59:
URL: https://github.com/apache/maven-archetype/pull/59#discussion_r502462463
##########
File path: maven-archetype-plugin/src/main/java/org/apache/maven/archetype/mojos/JarMojo.java
##########
@@ -68,6 +70,12 @@
@Parameter( defaultValue = "${project.build.directory}", required = true )
private File outputDirectory;
+ /**
+ * Exclude some files from the archetype like .gitignore.
+ * */
Review comment:
remove first asterisk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] Serranya commented on pull request #59: [ARCHETYPE-606] - There is no way to include .gitignore files for the jar goal
Posted by GitBox <gi...@apache.org>.
Serranya commented on pull request #59:
URL: https://github.com/apache/maven-archetype/pull/59#issuecomment-706171167
I made the hehaviour configurable. I will try generating the .gitignore next. The test that I have commit does not work yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org