[GitHub] [airflow] anitakar commented on a change in pull request #6788: [AIRFLOW-5944] Rendering template_fields without accessing DAG files

[GitBox <gi...@apache.org>]

anitakar commented on a change in pull request #6788: [AIRFLOW-5944] Rendering template_fields without accessing DAG files
URL: https://github.com/apache/airflow/pull/6788#discussion_r389398639
 
 

 ##########
 File path: airflow/models/taskinstance.py
 ##########
 @@ -927,6 +929,10 @@ def signal_handler(signum, frame):
                 start_time = time.time()
 
                 self.render_templates(context=context)
+                if STORE_SERIALIZED_DAGS:
 
 Review comment:
   Quite generic question, maybe even an open discussion here.
   STORE_SERIALIZED_DAGS comes from settings.py and is loaded when application (like webserver or scheduler) starts.
   If we use such variables this property stops being dynamic.
   But with scheduler reloading dags every now and then, it could be.
   
   Do we want to enforce that changing core.store_serialized_dags only takes effect if you restart?
   It is not crucial that it is dynamic but if it can be dynamic why should not it be?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services