You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Aravindan Vijayan <av...@hortonworks.com> on 2015/11/20 02:06:55 UTC
Review Request 40517: AMBARI-13955 : AMS stack-advisor validates 3
configs in 1 message
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40517/
-----------------------------------------------------------
Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-13955
https://issues.apache.org/jira/browse/AMBARI-13955
Repository: ambari
Description
-------
AMS recommendation through stack advisor gives out 3 recommendations in the same message. Even when some of the recommendations are fixed, the message again shows up with all 3 recommendations again.
Fix
Split the recommendation into 3 recommendations and cleaned up the code..
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 935e88b
Diff: https://reviews.apache.org/r/40517/diff/
Testing
-------
Unit tests pass. Manual testing done.
Thanks,
Aravindan Vijayan
Re: Review Request 40517: AMBARI-13955 : AMS stack-advisor validates 3
configs in 1 message
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40517/#review107285
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Nov. 20, 2015, 1:06 a.m., Aravindan Vijayan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40517/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2015, 1:06 a.m.)
>
>
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-13955
> https://issues.apache.org/jira/browse/AMBARI-13955
>
>
> Repository: ambari
>
>
> Description
> -------
>
> AMS recommendation through stack advisor gives out 3 recommendations in the same message. Even when some of the recommendations are fixed, the message again shows up with all 3 recommendations again.
>
> Fix
> Split the recommendation into 3 recommendations and cleaned up the code..
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 935e88b
>
> Diff: https://reviews.apache.org/r/40517/diff/
>
>
> Testing
> -------
>
> Unit tests pass. Manual testing done.
>
>
> Thanks,
>
> Aravindan Vijayan
>
>