You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@santuario.apache.org by "Peter De Maeyer (Jira)" <ji...@apache.org> on 2020/04/11 18:37:00 UTC

[jira] [Commented] (SANTUARIO-535) Remove useless method AbstractOutputProcessor.processEvent

    [ https://issues.apache.org/jira/browse/SANTUARIO-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17081518#comment-17081518 ] 

Peter De Maeyer commented on SANTUARIO-535:
-------------------------------------------

Removed {{AbstractOutputProcessor.processEvent}} in favor of the interface method {{OutputProcessor.processNextEvent}}.
PR created + patch attached.

> Remove useless method AbstractOutputProcessor.processEvent
> ----------------------------------------------------------
>
>                 Key: SANTUARIO-535
>                 URL: https://issues.apache.org/jira/browse/SANTUARIO-535
>             Project: Santuario
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: Java 2.1.5
>            Reporter: Peter De Maeyer
>            Assignee: Colm O hEigeartaigh
>            Priority: Major
>         Attachments: SANTUARIO-535.patch
>
>
> {{AbstractOutputProcessor}} implements {{OutputProcessor}}.
> It needlessly redirects {{OutputProcess.processNextEvent}} to a new abstract method {{AbstractOutputProcessor.processEvent}} with the exact same purpose and signature.
> This is unnecessarily confusing.
> It would be simpler and better to remove that abstract method and let subclasses implement {{processNextEvent}} from the interface straight away.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)