[jira] [Commented] (PARQUET-1020) Add support for Dynamic Messages in parquet-protobuf

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561769#comment-17561769 ] 

ASF GitHub Bot commented on PARQUET-1020:
-----------------------------------------

shangxinli commented on PR #963:
URL: https://github.com/apache/parquet-mr/pull/963#issuecomment-1172925425

   Sorry for the late response and thank you @guillaume-fetter and @dossett for the contribution. Yeah, it seems low risk and LGTM. 




> Add support for Dynamic Messages in parquet-protobuf
> ----------------------------------------------------
>
>                 Key: PARQUET-1020
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1020
>             Project: Parquet
>          Issue Type: New Feature
>          Components: parquet-protobuf
>            Reporter: Alex Buck
>            Assignee: Alex Buck
>            Priority: Major
>
> Hello. We would like to pass in a DynamicMessage rather than using the generated protobuf classes to allow us to make our job very generic. 
> I think this could be achieved by setting the descriptor upfront, similarly to how there is a ProtoParquetOutputFormat today.
> In ProtoWriteSupport in the init method it could then generate the parquet schema created by ProtoSchemaConverter using the passed in descriptor, rather than taking it from the generated proto class.
> Would there be interest in incorporating this change? If so does the approach above sound sensible? I am happy to do a pull request
> initial PR here: https://github.com/apache/parquet-mr/pull/414



--
This message was sent by Atlassian Jira
(v8.20.10#820010)