[GitHub] [lucene] jpountz commented on pull request #698: LUCENE-10429: Change how DocIdSetBuilder compute the cost of the dense iterator

[GitBox <gi...@apache.org>]

jpountz commented on pull request #698:
URL: https://github.com/apache/lucene/pull/698#issuecomment-1047529128


   > This is inconsistent with the #grow method where the counter is increased as it expects grow to be called for documents and no values.
   
   Actually my expectation is that `grow()` is called with a number of values, not unique documents. Javadocs say "documents" today, which might be a source of confusion, but it is really an upper bound of the number of times `BulkAdder#add` may be called, ie. an upper bound of the number of matching *values*?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org