You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/04/22 17:48:19 UTC

[GitHub] [gobblin] jack-moseley opened a new pull request #3269: [GOBBLIN-1435] Update flow state gauge name and fix bug when rerunning flow

jack-moseley opened a new pull request #3269:
URL: https://github.com/apache/gobblin/pull/3269


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1435
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   Update the gauge name to be consistent with other gaas metrics, and also fix bug that the gauge wasn't set to running after the first time when the gauge is created.
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Tested locally
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] asfgit closed pull request #3269: [GOBBLIN-1435] Update flow state gauge name and fix bug when rerunning flow

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3269:
URL: https://github.com/apache/gobblin/pull/3269


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] aplex commented on pull request #3269: [GOBBLIN-1435] Update flow state gauge name and fix bug when rerunning flow

Posted by GitBox <gi...@apache.org>.
aplex commented on pull request #3269:
URL: https://github.com/apache/gobblin/pull/3269#issuecomment-825076842


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org