[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5264: sched: Define SMP_NCPUS to 1 in no SMP case

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #5264:
URL: https://github.com/apache/incubator-nuttx/pull/5264#discussion_r787070840



##########
File path: sched/Kconfig
##########
@@ -282,11 +282,10 @@ config SMP
 		CPU0 IRQ handler use thread0's stack, but thread0 may switch to CPU1, that
 		will caused IRQ handler stack corruption.
 
-if SMP
-
 config SMP_NCPUS

Review comment:
       Ok, let me do the rename in the next PR.

##########
File path: arch/xtensa/src/esp32/esp32_irq.c
##########
@@ -595,11 +580,7 @@ void up_enable_irq(int irq)
   int cpuint = IRQ_GETCPUINT(g_irqmap[irq]);
 
   DEBUGASSERT(cpuint >= 0 && cpuint <= ESP32_CPUINT_MAX);
-#ifdef CONFIG_SMP
   DEBUGASSERT(cpu >= 0 && cpu <= CONFIG_SMP_NCPUS);

Review comment:
       Done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org