[GitHub] [calcite] zoudan commented on a diff in pull request #3131: [CALCITE-5611] Show sql for failed tests for SqlOperatorTest

["zoudan (via GitHub)" <gi...@apache.org>]

zoudan commented on code in PR #3131:
URL: https://github.com/apache/calcite/pull/3131#discussion_r1148722911


##########
testkit/src/main/java/org/apache/calcite/sql/test/ResultCheckers.java:
##########
@@ -194,17 +195,17 @@ private static ColumnMetaData.Rep rep(int columnType) {
    * @param resultSet Result set

Review Comment:
   do it too



##########
testkit/src/main/java/org/apache/calcite/sql/test/ResultCheckers.java:
##########
@@ -221,7 +222,7 @@ static void compareResultSetWithPattern(ResultSet resultSet,
    *

Review Comment:
   do it too



##########
testkit/src/main/java/org/apache/calcite/sql/test/ResultCheckers.java:
##########
@@ -103,11 +103,12 @@ public static SqlTester.ResultChecker isNullValue() {
    * @param refSet    Expected results

Review Comment:
   add an annotation for param `sql`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org