You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/03/31 17:26:09 UTC

[GitHub] [netbeans] mcdonnell-john commented on a change in pull request #2056: Introducing new Plugin Portal 3.0 update center in Apache NetBeans 12.0

mcdonnell-john commented on a change in pull request #2056: Introducing new Plugin Portal 3.0 update center in Apache NetBeans 12.0
URL: https://github.com/apache/netbeans/pull/2056#discussion_r401086961
 
 

 ##########
 File path: nb/updatecenters/src/org/netbeans/modules/updatecenters/resources/Bundle.properties
 ##########
 @@ -25,13 +25,16 @@ OpenIDE-Module-Short-Description=Declares NetBeans autoupdate centers.
 
 Services/AutoupdateType/distribution-update-provider.instance=NetBeans Distribution
 Services/AutoupdateType/pluginportal-update-provider.instance=NetBeans Plugin Portal
+Services/AutoupdateType/legacy-pluginportal-update-provider.instance=Legacy NetBeans Plugin Portal
 Services/AutoupdateType/82pluginportal-update-provider.instance=NetBeans 8.2 Plugin Portal
 
 #NOI18N
 URL_Distribution=@@metabuild.DistributionURL@@
 #NOI18N
 URL_PluginPortal=@@metabuild.PluginPortalURL@@
 #NOI18N
+URL_LegacyPluginPortal=@@metabuild.LegacyPluginPortalURL@@
 
 Review comment:
   Does this need to be set somewhere?
   
   Just looking at the other metadata its also used:
   https://github.com/apache/netbeans/blob/312f983bf6627e91bdfb7526e67302975d3f7f80/nb/updatecenters/build.xml#L31
   and
   https://github.com/apache/netbeans/blob/6c3e8d1eee5c8ca49c11027065ca90c8abcbd920/nbbuild/antsrc/org/netbeans/nbbuild/ReleaseJsonProperties.java#L177

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists