You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@orc.apache.org by do...@apache.org on 2026/07/05 10:13:32 UTC
(orc) branch branch-2.3 updated: ORC-2189: Add `URL_HASH` to all third-party dependencies in `ThirdpartyToolchain.cmake`
This is an automated email from the ASF dual-hosted git repository.
dongjoon-hyun pushed a commit to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/orc.git
The following commit(s) were added to refs/heads/branch-2.3 by this push:
new 618a5e115 ORC-2189: Add `URL_HASH` to all third-party dependencies in `ThirdpartyToolchain.cmake`
618a5e115 is described below
commit 618a5e11538abd7aab35d8c6a5c409d9e1496a34
Author: Dongjoon Hyun <do...@apache.org>
AuthorDate: Sun Jul 5 03:13:25 2026 -0700
ORC-2189: Add `URL_HASH` to all third-party dependencies in `ThirdpartyToolchain.cmake`
### What changes were proposed in this pull request?
This PR aims to add `URL_HASH` (SHA256) to all third-party dependencies declared via `fetchcontent_declare` in `cmake_modules/ThirdpartyToolchain.cmake`.
### Why are the changes needed?
To verify the integrity of the downloaded archives and fail the build explicitly on any checksum mismatch.
### How was this patch tested?
Pass the CIs.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Fable 5
Closes #2664 from dongjoon-hyun/ORC-2189-2.3.
Authored-by: Dongjoon Hyun <do...@apache.org>
Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
cmake_modules/ThirdpartyToolchain.cmake | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/cmake_modules/ThirdpartyToolchain.cmake b/cmake_modules/ThirdpartyToolchain.cmake
index d3dfd9add..8bf68722e 100644
--- a/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cmake_modules/ThirdpartyToolchain.cmake
@@ -209,6 +209,7 @@ else ()
fetchcontent_declare(Protobuf
URL "https://github.com/google/protobuf/archive/v${PROTOBUF_VERSION}.tar.gz"
+ URL_HASH SHA256=826425182ee43990731217b917c5c3ea7190cfda141af4869e6d4ad9085a740f
SOURCE_SUBDIR "cmake"
FIND_PACKAGE_ARGS
NAMES Protobuf
@@ -287,6 +288,7 @@ else ()
fetchcontent_declare(Snappy
URL "https://github.com/google/snappy/archive/${SNAPPY_VERSION}.tar.gz"
+ URL_HASH SHA256=90f74bc1fbf78a6c56b3c4a082a05103b3a56bb17bca1a27e052ea11723292dc
FIND_PACKAGE_ARGS
NAMES Snappy
CONFIG
@@ -462,6 +464,7 @@ else ()
fetchcontent_declare(zstd
URL "https://github.com/facebook/zstd/archive/v${ZSTD_VERSION}.tar.gz"
+ URL_HASH SHA256=37d7284556b20954e56e1ca85b80226768902e2edabd3b649e9e72c0c9012ee3
SOURCE_SUBDIR "build/cmake"
FIND_PACKAGE_ARGS
NAMES zstd
@@ -541,6 +544,7 @@ else ()
fetchcontent_declare(lz4
URL "https://github.com/lz4/lz4/archive/v${LZ4_VERSION}.tar.gz"
+ URL_HASH SHA256=537512904744b35e232912055ccf8ec66d768639ff3abe5788d90d792ec5f48b
SOURCE_SUBDIR "build/cmake"
FIND_PACKAGE_ARGS
NAMES lz4
@@ -654,6 +658,7 @@ if (BUILD_CPP_TESTS)
prepare_fetchcontent()
fetchcontent_declare(GTest
URL "https://github.com/google/googletest/archive/refs/tags/v${GTEST_VERSION}.tar.gz"
+ URL_HASH SHA256=65fab701d9829d38cb77c14acdc431d2108bfdbf8979e40eb8ae567edf10b27c
FIND_PACKAGE_ARGS
NAMES GTest
CONFIG
@@ -690,6 +695,7 @@ if(BUILD_SPARSEHASH)
fetchcontent_declare(sparsehash
URL "https://github.com/sparsehash/sparsehash-c11/archive/refs/tags/v${SPARSEHASH_VERSION}.tar.gz"
+ URL_HASH SHA256=d4a43cad1e27646ff0ef3a8ce3e18540dbcb1fdec6cc1d1cb9b5095a9ca2a755
SOURCE_SUBDIR "sparsehash" # XXX: sparsehash bundles gtest which conflicts with our vendored one
)
fetchcontent_makeavailable(sparsehash)