You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/27 22:29:07 UTC
[GitHub] [spark] viirya commented on a change in pull request #35034: [SPARK-37755][CORE] Optimize RocksDB KVStore configurations
viirya commented on a change in pull request #35034:
URL: https://github.com/apache/spark/pull/35034#discussion_r775661665
##########
File path: common/kvstore/src/main/java/org/apache/spark/util/kvstore/RocksDB.java
##########
@@ -63,15 +59,38 @@
/** DB key where type aliases are stored. */
private static final byte[] TYPE_ALIASES_KEY = "__types__".getBytes(UTF_8);
+ /**
+ * Use full filter.
+ *
+ * https://github.com/facebook/rocksdb/wiki/RocksDB-Bloom-Filter#full-filters-new-format
+ */
+ private static final BloomFilter fullFilter =
+ new BloomFilter(10.0D /* BloomFilter.DEFAULT_BITS_PER_KEY */, false);
+
+ /** Disable compression in index data. */
private static final BlockBasedTableConfig tableFormatConfig = new BlockBasedTableConfig()
+ .setFilterPolicy(fullFilter)
+ .setEnableIndexCompression(false)
Review comment:
Does `index_block_restart_interval` help too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org