You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/05/28 16:20:53 UTC

[GitHub] [qpid-proton] jiridanek opened a new pull request #252: PROTON-2225: adjust valgrind.supp to cover both forms of the leak

jiridanek opened a new pull request #252:
URL: https://github.com/apache/qpid-proton/pull/252


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #252: PROTON-2225: adjust valgrind.supp to cover both forms of the leak

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #252:
URL: https://github.com/apache/qpid-proton/pull/252#issuecomment-635479840


   # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr&el=h1) Report
   > Merging [#252](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-proton/commit/db01c09748ff950d454c9d777de16cf442e37631&el=desc) will **decrease** coverage by `9.99%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-proton/pull/252/graphs/tree.svg?width=650&height=150&src=pr&token=UKKzV9XnFF)](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master     #252       +/-   ##
   ===========================================
   - Coverage   93.08%   83.09%   -10.00%     
   ===========================================
     Files          62      339      +277     
     Lines        4177    41362    +37185     
   ===========================================
   + Hits         3888    34368    +30480     
   - Misses        289     6994     +6705     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [cpp/src/test\_bits.hpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Y3BwL3NyYy90ZXN0X2JpdHMuaHBw) | `43.90% <0.00%> (ø)` | |
   | [c/tests/pn\_test\_proactor.hpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Yy90ZXN0cy9wbl90ZXN0X3Byb2FjdG9yLmhwcA==) | `100.00% <0.00%> (ø)` | |
   | [cpp/src/link.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Y3BwL3NyYy9saW5rLmNwcA==) | `82.75% <0.00%> (ø)` | |
   | [cpp/include/proton/sender.hpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3NlbmRlci5ocHA=) | `28.57% <0.00%> (ø)` | |
   | [c/tests/refcount\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Yy90ZXN0cy9yZWZjb3VudF90ZXN0LmNwcA==) | `100.00% <0.00%> (ø)` | |
   | [cpp/include/proton/value.hpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3ZhbHVlLmhwcA==) | `100.00% <0.00%> (ø)` | |
   | [cpp/src/receiver\_options.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Y3BwL3NyYy9yZWNlaXZlcl9vcHRpb25zLmNwcA==) | `82.45% <0.00%> (ø)` | |
   | [cpp/include/proton/codec/unordered\_map.hpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL2NvZGVjL3Vub3JkZXJlZF9tYXAuaHBw) | `100.00% <0.00%> (ø)` | |
   | [cpp/src/duration.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Y3BwL3NyYy9kdXJhdGlvbi5jcHA=) | `83.33% <0.00%> (ø)` | |
   | [cpp/examples/ssl\_client\_cert.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Y3BwL2V4YW1wbGVzL3NzbF9jbGllbnRfY2VydC5jcHA=) | `89.47% <0.00%> (ø)` | |
   | ... and [267 more](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr&el=footer). Last update [db01c09...a0fde56](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-proton] codecov-commenter commented on pull request #252: PROTON-2225: adjust valgrind.supp to cover both forms of the leak

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #252:
URL: https://github.com/apache/qpid-proton/pull/252#issuecomment-635479840


   # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr&el=h1) Report
   > Merging [#252](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-proton/commit/db01c09748ff950d454c9d777de16cf442e37631&el=desc) will **decrease** coverage by `9.99%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-proton/pull/252/graphs/tree.svg?width=650&height=150&src=pr&token=UKKzV9XnFF)](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master     #252       +/-   ##
   ===========================================
   - Coverage   93.08%   83.09%   -10.00%     
   ===========================================
     Files          62      339      +277     
     Lines        4177    41362    +37185     
   ===========================================
   + Hits         3888    34368    +30480     
   - Misses        289     6994     +6705     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [c/src/core/log.c](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Yy9zcmMvY29yZS9sb2cuYw==) | `21.73% <0.00%> (ø)` | |
   | [cpp/src/endpoint.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Y3BwL3NyYy9lbmRwb2ludC5jcHA=) | `72.72% <0.00%> (ø)` | |
   | [python/proton/utils.py](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-cHl0aG9uL3Byb3Rvbi91dGlscy5weQ==) | `100.00% <0.00%> (ø)` | |
   | [cpp/src/link.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Y3BwL3NyYy9saW5rLmNwcA==) | `82.75% <0.00%> (ø)` | |
   | [cpp/src/transfer.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Y3BwL3NyYy90cmFuc2Zlci5jcHA=) | `33.33% <0.00%> (ø)` | |
   | [.../test\_PROTON\_1709\_application\_event\_object\_leak.py](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-cHl0aG9uL3Rlc3RzL2ludGVncmF0aW9uL3Rlc3RfUFJPVE9OXzE3MDlfYXBwbGljYXRpb25fZXZlbnRfb2JqZWN0X2xlYWsucHk=) | `100.00% <0.00%> (ø)` | |
   | [python/proton/\_endpoints.py](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-cHl0aG9uL3Byb3Rvbi9fZW5kcG9pbnRzLnB5) | `91.89% <0.00%> (ø)` | |
   | [cpp/include/proton/binary.hpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL2JpbmFyeS5ocHA=) | `100.00% <0.00%> (ø)` | |
   | [c/src/handlers/handshaker.c](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Yy9zcmMvaGFuZGxlcnMvaGFuZHNoYWtlci5j) | `89.74% <0.00%> (ø)` | |
   | [cpp/src/delivery.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Y3BwL3NyYy9kZWxpdmVyeS5jcHA=) | `70.00% <0.00%> (ø)` | |
   | ... and [267 more](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr&el=footer). Last update [db01c09...a0fde56](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-proton] jiridanek merged pull request #252: PROTON-2225: adjust valgrind.supp to cover both forms of the leak

Posted by GitBox <gi...@apache.org>.
jiridanek merged pull request #252:
URL: https://github.com/apache/qpid-proton/pull/252


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-proton] codecov-commenter edited a comment on pull request #252: PROTON-2225: adjust valgrind.supp to cover both forms of the leak

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #252:
URL: https://github.com/apache/qpid-proton/pull/252#issuecomment-635479840


   # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr&el=h1) Report
   > Merging [#252](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-proton/commit/db01c09748ff950d454c9d777de16cf442e37631&el=desc) will **decrease** coverage by `9.99%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-proton/pull/252/graphs/tree.svg?width=650&height=150&src=pr&token=UKKzV9XnFF)](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master     #252       +/-   ##
   ===========================================
   - Coverage   93.08%   83.09%   -10.00%     
   ===========================================
     Files          62      339      +277     
     Lines        4177    41362    +37185     
   ===========================================
   + Hits         3888    34368    +30480     
   - Misses        289     6994     +6705     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [cpp/examples/client.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Y3BwL2V4YW1wbGVzL2NsaWVudC5jcHA=) | `86.84% <0.00%> (ø)` | |
   | [cpp/src/reconnect\_options.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Y3BwL3NyYy9yZWNvbm5lY3Rfb3B0aW9ucy5jcHA=) | `66.66% <0.00%> (ø)` | |
   | [c/tests/engine\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Yy90ZXN0cy9lbmdpbmVfdGVzdC5jcHA=) | `100.00% <0.00%> (ø)` | |
   | [python/proton/\_utils.py](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-cHl0aG9uL3Byb3Rvbi9fdXRpbHMucHk=) | `71.48% <0.00%> (ø)` | |
   | [c/src/core/framing.c](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Yy9zcmMvY29yZS9mcmFtaW5nLmM=) | `96.00% <0.00%> (ø)` | |
   | [c/tests/fuzz/fuzz-url.c](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Yy90ZXN0cy9mdXp6L2Z1enotdXJsLmM=) | `100.00% <0.00%> (ø)` | |
   | [c/src/proactor/proactor-internal.c](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Yy9zcmMvcHJvYWN0b3IvcHJvYWN0b3ItaW50ZXJuYWwuYw==) | `84.21% <0.00%> (ø)` | |
   | [cpp/src/link\_namer.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Y3BwL3NyYy9saW5rX25hbWVyLmNwcA==) | `100.00% <0.00%> (ø)` | |
   | [cpp/src/connection\_options.cpp](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Y3BwL3NyYy9jb25uZWN0aW9uX29wdGlvbnMuY3Bw) | `90.69% <0.00%> (ø)` | |
   | [c/src/core/codec.c](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree#diff-Yy9zcmMvY29yZS9jb2RlYy5j) | `82.30% <0.00%> (ø)` | |
   | ... and [267 more](https://codecov.io/gh/apache/qpid-proton/pull/252/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr&el=footer). Last update [db01c09...a0fde56](https://codecov.io/gh/apache/qpid-proton/pull/252?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org