You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by marmbrus <gi...@git.apache.org> on 2014/05/17 03:20:11 UTC
[GitHub] spark pull request: SPARK-1864 Look in spark conf instead of syste...
GitHub user marmbrus opened a pull request:
https://github.com/apache/spark/pull/808
SPARK-1864 Look in spark conf instead of system properties when propagating configuration to executors.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marmbrus/spark confClasspath
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/808.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #808
----
commit 4c31d57d37ac2766fcfa097f0700efbb9c2df0be
Author: Michael Armbrust <mi...@databricks.com>
Date: 2014-05-17T01:18:56Z
Look in spark conf instead of system properties when propagating configuration to executors.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1864 Look in spark conf instead of syste...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/808#issuecomment-43394753
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1864 Look in spark conf instead of syste...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/808#issuecomment-43393846
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1864 Look in spark conf instead of syste...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/808#issuecomment-43394754
All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15059/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1864 Look in spark conf instead of syste...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/808
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1864 Look in spark conf instead of syste...
Posted by mridulm <gi...@git.apache.org>.
Github user mridulm commented on the pull request:
https://github.com/apache/spark/pull/808#issuecomment-43401491
Though I don't think there is any issue with this change specifically,
would be better if there is atleast someone else reviews a PR and gives a
go before committing it - however trivial a change looks like .
Does not look like anyone took a look at this one before committing.
Regards,
Mridul
On 17-May-2014 8:55 am, "asfgit" <no...@github.com> wrote:
> Closed #808 <https://github.com/apache/spark/pull/808> via a80a6a1<https://github.com/apache/spark/commit/a80a6a139e729ee3f81ec4f0028e084d2d9f7e82>
> .
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/apache/spark/pull/808#event-122121832>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1864 Look in spark conf instead of syste...
Posted by mridulm <gi...@git.apache.org>.
Github user mridulm commented on the pull request:
https://github.com/apache/spark/pull/808#issuecomment-43401687
Ah ! Great :-)
Would have been more clear if at least asfgit had indicated who committed
it in the message.
On 17-May-2014 2:22 pm, "Aaron Davidson" <no...@github.com> wrote:
> I think @pwendell <https://github.com/pwendell> actually committed this
> (as indicated here: a80a6a1<https://github.com/apache/spark/commit/a80a6a139e729ee3f81ec4f0028e084d2d9f7e82>).
> I think he just forgot to comment that he did so :)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/apache/spark/pull/808#issuecomment-43401656>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1864 Look in spark conf instead of syste...
Posted by aarondav <gi...@git.apache.org>.
Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/808#issuecomment-43401656
I think @pwendell actually committed this (as indicated here: https://github.com/apache/spark/commit/a80a6a139e729ee3f81ec4f0028e084d2d9f7e82). I think he just forgot to comment that he did so :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1864 Look in spark conf instead of syste...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/808#issuecomment-43393840
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---