Re: [PR] Fix Y2038 worker heartbeat overflow by migrating timestamps to i64 (storm)

["reiabreu (via GitHub)" <gi...@apache.org>]

reiabreu commented on PR #8788:
URL: https://github.com/apache/storm/pull/8788#issuecomment-4702131110

   @dpol1 thanks for the submission.
   
   What do you think about offering the possibility of heartbeat producers still sending 32 bits and Nimbus would ajust?
   This could make the upgrade process smoother.
   
       struct ClusterWorkerHeartbeat {
           1: optional i32 time_secs        // ← demoted to optional, kept for legacy readers
           5: required i64 time_secs_long   // ← new field at a new field ID
           ...
       }
     
     Then in the reader code:
     
       long getTimeSecs() {
           if (isSet(TIME_SECS_LONG)) return time_secs_long;  // new writer
           return (long) time_secs;                            // legacy fallback, safe pre-2038
       }
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org