You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/11/18 05:38:34 UTC
[GitHub] [rocketmq] aaron-ai opened a new pull request, #5540: [ISSUE #5484] Replace logging module with the shaded logback
aaron-ai opened a new pull request, #5540:
URL: https://github.com/apache/rocketmq/pull/5540
fixes #5484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on a diff in pull request #5540: [ISSUE #5484] Replace logging module with the shaded logback
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on code in PR #5540:
URL: https://github.com/apache/rocketmq/pull/5540#discussion_r1028008771
##########
acl/pom.xml:
##########
@@ -43,6 +39,14 @@
<groupId>${project.groupId}</groupId>
<artifactId>rocketmq-srvutil</artifactId>
</dependency>
+ <dependency>
+ <groupId>io.github.aliyun-mq</groupId>
+ <artifactId>rocketmq-slf4j-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.github.aliyun-mq</groupId>
+ <artifactId>rocketmq-logback-classic</artifactId>
+ </dependency>
Review Comment:
IMO, It would be better to put it in a more neutral third-party repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] aaron-ai commented on a diff in pull request #5540: [ISSUE #5484] Replace logging module with the shaded logback
Posted by GitBox <gi...@apache.org>.
aaron-ai commented on code in PR #5540:
URL: https://github.com/apache/rocketmq/pull/5540#discussion_r1028724454
##########
acl/pom.xml:
##########
@@ -43,6 +39,14 @@
<groupId>${project.groupId}</groupId>
<artifactId>rocketmq-srvutil</artifactId>
</dependency>
+ <dependency>
+ <groupId>io.github.aliyun-mq</groupId>
+ <artifactId>rocketmq-slf4j-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.github.aliyun-mq</groupId>
+ <artifactId>rocketmq-logback-classic</artifactId>
+ </dependency>
Review Comment:
@RongtongJin Actually a more neutral repo(e.g. some other repos which belong to apache rocketmq) is considered, but we want to avoid the redundant polling procedure at present, because we'd better to keep up to date with the original version, current polling procedure is uncesscary.
On the other hand, I think current group id is ok because the License is more important, or we could refer to the dependency of fastjson.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] aaron-ai merged pull request #5540: [ISSUE #5484] Replace logging module with the shaded logback
Posted by GitBox <gi...@apache.org>.
aaron-ai merged PR #5540:
URL: https://github.com/apache/rocketmq/pull/5540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #5540: [ISSUE #5484] Replace logging module with the shaded logback
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #5540:
URL: https://github.com/apache/rocketmq/pull/5540#issuecomment-1319618076
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/5540?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#5540](https://codecov.io/gh/apache/rocketmq/pull/5540?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (044e1fc) into [develop](https://codecov.io/gh/apache/rocketmq/commit/0b24e875b7a8d424da0a618c892d6de79eb74343?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0b24e87) will **decrease** coverage by `0.29%`.
> The diff coverage is `69.11%`.
> :exclamation: Current head 044e1fc differs from pull request most recent head 5f2c8d7. Consider uploading reports for the commit 5f2c8d7 to get more accurate results
```diff
@@ Coverage Diff @@
## develop #5540 +/- ##
=============================================
- Coverage 42.72% 42.42% -0.30%
+ Complexity 8032 7941 -91
=============================================
Files 1031 1022 -9
Lines 72741 71249 -1492
Branches 9613 9398 -215
=============================================
- Hits 31079 30229 -850
+ Misses 37718 37186 -532
+ Partials 3944 3834 -110
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/5540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/rocketmq/broker/BrokerPreOnlineService.java](https://codecov.io/gh/apache/rocketmq/pull/5540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyUHJlT25saW5lU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...java/org/apache/rocketmq/broker/BrokerStartup.java](https://codecov.io/gh/apache/rocketmq/pull/5540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyU3RhcnR1cC5qYXZh) | `8.00% <0.00%> (+0.25%)` | :arrow_up: |
| [...ketmq/broker/dledger/DLedgerRoleChangeHandler.java](https://codecov.io/gh/apache/rocketmq/pull/5540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZGxlZGdlci9ETGVkZ2VyUm9sZUNoYW5nZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...he/rocketmq/broker/filtersrv/FilterServerUtil.java](https://codecov.io/gh/apache/rocketmq/pull/5540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZmlsdGVyc3J2L0ZpbHRlclNlcnZlclV0aWwuamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../broker/longpolling/LmqPullRequestHoldService.java](https://codecov.io/gh/apache/rocketmq/pull/5540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvbG9uZ3BvbGxpbmcvTG1xUHVsbFJlcXVlc3RIb2xkU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...etmq/broker/processor/ForwardRequestProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/5540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL0ZvcndhcmRSZXF1ZXN0UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...main/java/org/apache/rocketmq/client/MQHelper.java](https://codecov.io/gh/apache/rocketmq/pull/5540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvTVFIZWxwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...client/consumer/MQPullConsumerScheduleService.java](https://codecov.io/gh/apache/rocketmq/pull/5540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvTVFQdWxsQ29uc3VtZXJTY2hlZHVsZVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...sumer/rebalance/AllocateMessageQueueAveragely.java](https://codecov.io/gh/apache/rocketmq/pull/5540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvcmViYWxhbmNlL0FsbG9jYXRlTWVzc2FnZVF1ZXVlQXZlcmFnZWx5LmphdmE=) | `86.66% <ø> (+7.71%)` | :arrow_up: |
| [...balance/AllocateMessageQueueAveragelyByCircle.java](https://codecov.io/gh/apache/rocketmq/pull/5540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvcmViYWxhbmNlL0FsbG9jYXRlTWVzc2FnZVF1ZXVlQXZlcmFnZWx5QnlDaXJjbGUuamF2YQ==) | `90.00% <ø> (+11.42%)` | :arrow_up: |
| ... and [239 more](https://codecov.io/gh/apache/rocketmq/pull/5540/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on a diff in pull request #5540: [ISSUE #5484] Replace logging module with the shaded logback
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on code in PR #5540:
URL: https://github.com/apache/rocketmq/pull/5540#discussion_r1028008771
##########
acl/pom.xml:
##########
@@ -43,6 +39,14 @@
<groupId>${project.groupId}</groupId>
<artifactId>rocketmq-srvutil</artifactId>
</dependency>
+ <dependency>
+ <groupId>io.github.aliyun-mq</groupId>
+ <artifactId>rocketmq-slf4j-api</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.github.aliyun-mq</groupId>
+ <artifactId>rocketmq-logback-classic</artifactId>
+ </dependency>
Review Comment:
IMO, It would be better to put it in a more neutral repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org