[GitHub] [echarts] pissang commented on pull request #15404: Label text style support `lineOverflow` and `ellipsis`

[GitBox <gi...@apache.org>]

pissang commented on pull request #15404:
URL: https://github.com/apache/echarts/pull/15404#issuecomment-886509028


   I remember I didn't add ellipse and lineOverflow for some compatible considerations.
   
   Especially the ellipse, `treemap` already has ellipse in the 4.x versions but with different meanings, which is same with overflow: 'truncate'. I noticed in this PR it is changed from boolean to string. In fact, it still works for the old code and will be converted to overflow: 'truncate'. Introducing `ellipse` to the label option will break it.
   
   For `lineOverflow` it's mainly because I thought it is not implemented well yet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org