You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/21 20:15:57 UTC
[GitHub] [arrow-rs] alamb opened a new pull request, #2121: Fix logical merge conflict
alamb opened a new pull request, #2121:
URL: https://github.com/apache/arrow-rs/pull/2121
Fix build on master
I merged https://github.com/apache/arrow-rs/pull/2094 which had a logical conflict which results in a build failure on master such as https://github.com/apache/arrow-rs/runs/7455984487?check_suite_focus=true
```
Compiling arrow-integration-testing v18.0.0 (/__w/arrow-rs/arrow-rs/integration-testing)
error[E0308]: `match` arms have incompatible types
--> integration-testing/src/lib.rs:645:26
|
628 | / match is_valid {
629 | | 1 => {
630 | | let str = value.as_str().unwrap();
631 | | let integer = BigInt::parse_bytes(str.as_bytes(), 10).unwrap();
... |
643 | | b.append_value(&decimal)
| | ------------------------ this is found to be of type `std::result::Result<(), ArrowError>`
644 | | }
645 | | _ => b.append_null(),
| | ^^^^^^^^^^^^^^^ expected enum `std::result::Result`, found `()`
646 | | }?;
| |_________________- `match` arms have incompatible types
|
= note: expected enum `std::result::Result<(), ArrowError>`
found unit type `()`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #2121: Fix logical merge conflict: `match` arms have incompatible types
Posted by GitBox <gi...@apache.org>.
alamb merged PR #2121:
URL: https://github.com/apache/arrow-rs/pull/2121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2121: Fix logical merge conflict: `match` arms have incompatible types
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2121:
URL: https://github.com/apache/arrow-rs/pull/2121#issuecomment-1191913795
Benchmark runs are scheduled for baseline = 1805b30e620b05bd050a9f2dfcf5ef41e05977ea and contender = db91031c2cd07f516f8118abf5477c33e0249e0a. db91031c2cd07f516f8118abf5477c33e0249e0a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9bce63e69caa443498bb1899bb6b14d7...7583c6bc534c4c3db7c0e5908dc61438/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5a0ff4d9b46d4ba89256c68de6546021...0e15a524b5e943d382cacecac6136bd7/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3ffaa74ecb15434bba315ad8f6f6de56...fd6c3c2889554ceea0857f6ebe4bbb22/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/40bca7f448734d5786aad4140b1a74ce...94b914e3ac0149939c05ddc94e2e1b94/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #2121: Fix logical merge conflict: `match` arms have incompatible types
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2121:
URL: https://github.com/apache/arrow-rs/pull/2121#issuecomment-1191896574
I plan to merge this PR once the build step passes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org