You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Mladen Turk <mt...@apache.org> on 2014/04/10 13:50:58 UTC

[VOTE] Release Apache Tomcat Native 1.1.30

Version 1.1.30 is bug fixing release with added ECDH
if supported by OpenSSL library.
The proposed release artefacts can be found at [1],
and the build was done using tag [2].

The VOTE will remain open for at least 48 hours.

The Apache Tomcat Native 1.1.30 is
  [ ] Stable, go ahead and release
  [ ] Broken because of ...


  [1] http://people.apache.org/~mturk/native/1.1.30
  [2] https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_1_30


Regards
-- 
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat Native 1.1.30

Posted by Rainer Jung <ra...@kippdata.de>.
On 10.04.2014 13:50, Mladen Turk wrote:
> Version 1.1.30 is bug fixing release with added ECDH
> if supported by OpenSSL library.
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
> 
> The VOTE will remain open for at least 48 hours.
> 
> The Apache Tomcat Native 1.1.30 is
>  [X] Stable, go ahead and release
>  [ ] Broken because of ...

+1 to release

Detailed results below. No progress for items documented in TODO.txt, so
there is still room for improvement.

- Tested with APR 1.5.0 and OpenSSL 1.0.1g. Java version 1.7.0_51 for
pure tcnative tests/examples, Tomcat testsuite taken from TC 7 tested
with 1.6.0_45, native part configured against Java 1.5.0_22.
- Platforms Solaris 10 Sparc, SLES 11 64 Bits, RHEL 6 64 Bits
- MD5 OK
- signatures OK
- gz and zip for sources consistent
- source dist consistent with svn tag
- config-guess and config.sub from apr head of 1.4 or 1.5 or trunk
  (copied by buildconf) 1-3 months outdated, not too bad.
- VERSIONS says OpenSSL 1.0.1g (OK) and APR 1.4.8
  - not sure what policy we follow here,
    e.g. when we'll update to APR 1.5
- recreated release with jnirelease script, results are
  consistent with source dist, except for minor expected diffs in
  CHANGELOG.txt, build-outputs.mk and generated docs
  (whitespace and attribute ordering)
- make succeeds and builds lib (no warnings)
- "ant test" succeeds
- all unit tests contained in TC 7 head run successful with
  APR connector and this version of tcnative.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat Native 1.1.30

Posted by Tim Whittington <ti...@apache.org>.
On 10/04/2014, at 11:50 pm, Mladen Turk <mt...@apache.org> wrote:

> Version 1.1.30 is bug fixing release with added ECDH
> if supported by OpenSSL library.
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
> 
> The VOTE will remain open for at least 48 hours.
> 
> The Apache Tomcat Native 1.1.30 is
> [X] Stable, go ahead and release
> [ ] Broken because of ...


Tested on OS X Mavericks with Tomcat 7.0.x.
Builds cleanly against OpenSSL 1.0.1g and APR 1.50.
HTTP and HTTPS APR connectors tested.

Testing with Firefox, Chrome, Safari and openssl s_client shows TLSv1.2 and ECDHE cipher suites being used.
Testing with https://github.com/FiloSottile/Heartbleed shows SAFE from Heartbleed (as expected, linking against 1.0.1g).

There’s one problem using APR/HTTPS in Tomcat on OS X, where SSL_library_init needs to be called on the same thread that invokes SSLContext.make to make things work, but that’s not a tcnative issue.

cheers
tim
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat Native 1.1.30

Posted by Mladen Turk <mt...@apache.org>.
On 04/10/2014 01:50 PM, Mladen Turk wrote:
>
> The Apache Tomcat Native 1.1.30 is
>   [X] Stable, go ahead and release
>   [ ] Broken because of ...
>
>

My vote, FTR.

Regards
-- 
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat Native 1.1.30

Posted by Konstantin Kolinko <kn...@gmail.com>.
2014-04-10 15:50 GMT+04:00 Mladen Turk <mt...@apache.org>:
> Version 1.1.30 is bug fixing release with added ECDH
> if supported by OpenSSL library.
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The VOTE will remain open for at least 48 hours.
>
> The Apache Tomcat Native 1.1.30 is
>  [x] Stable, go ahead and release
>  [ ] Broken because of ...
>

I've run current 8.0.x (@r1586315) testsuite with JDK 7u51 32-bit on
Windows7 with non-OSCP and with OSCP binaries.  Both runs have
completed successfully.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


RE: [VOTE] Release Apache Tomcat Native 1.1.30

Posted by Robert Sanders <rs...@TrustedCS.com>.
I'll concur with Chris for release.  WRT BZ 56027 there is no regression.  The exposure of the fipsModeGet will be useful moving forward to have the main Tomcat code avoid a double call to initialize SSL, but some one with more understanding of the FIPS requirements that I do should look at how TCN is pre-generating keys lengths.

-R


> The Apache Tomcat Native 1.1.30 is
>  [X] Stable, go ahead and release
>  [ ] Broken because of ...

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat Native 1.1.30

Posted by Christopher Schultz <ch...@christopherschultz.net>.
Mladen,

On 4/10/14, 5:50 AM, Mladen Turk wrote:
> Version 1.1.30 is bug fixing release with added ECDH
> if supported by OpenSSL library.
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
> 
> The VOTE will remain open for at least 48 hours.
> 
> The Apache Tomcat Native 1.1.30 is
>  [X] Stable, go ahead and release
>  [ ] Broken because of ...

Thanks for this.

-chris


Re: [VOTE] Release Apache Tomcat Native 1.1.30

Posted by Rémy Maucherat <re...@apache.org>.
2014-04-10 13:50 GMT+02:00 Mladen Turk <mt...@apache.org>:

> The Apache Tomcat Native 1.1.30 is
>  [X] Stable, go ahead and release
>  [ ] Broken because of ...
>

Rémy

RE: [VOTE] Release Apache Tomcat Native 1.1.30

Posted by Robert Sanders <rs...@TrustedCS.com>.
Just tested against a CentOS 6 box configured to be in FIPS mode at boot as per RH's directions and TCN will not start, tossing the same error I saw before in catalina.out:

Apr 10, 2014 9:01:19 AM org.apache.catalina.core.AprLifecycleListener lifecycleEvent
SEVERE: Failed to initialize the SSLEngine.
java.lang.reflect.InvocationTargetException
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.apache.catalina.core.AprLifecycleListener.initializeSSL(AprLifecycleListener.java:269)
	at org.apache.catalina.core.AprLifecycleListener.lifecycleEvent(AprLifecycleListener.java:108)
	at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:142)
	at org.apache.catalina.core.StandardServer.initialize(StandardServer.java:813)
	at org.apache.catalina.startup.Catalina.load(Catalina.java:538)
	at org.apache.catalina.startup.Catalina.load(Catalina.java:562)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.apache.catalina.startup.Bootstrap.load(Bootstrap.java:261)

Commenting out line 77 (where the 512 bit RSA key is generated)  allows TCN to start and run normally.  I don't understand all of the FIPS requirements, but should execution be allowed to continue if we can generate *any* of the initial keys rather than requiring all of them?  The logic of the macros in lines 68 through 82 wind up causing the SSL_TMP_KEYS_INIT(r) call at line 692 to fire if any key init fails, rather than seeing if at least one passes.

I did see in the changelog that BZ 56027 is only partially addressed, in that the fipsModeGet() method is now available.  

-Rob

________________________________________
From: Robert Sanders [rsanders@TrustedCS.com]
Sent: Thursday, April 10, 2014 9:15 AM
To: Tomcat Developers List
Subject: RE: [VOTE] Release Apache Tomcat Native 1.1.30

Is the TCN portion of BZ 56027 address completely or partially with this release?  I see the exposure of the FIPS_mode setting, but it looks like the temporary 512 bit RSA key is still being done in the SSL_TMP_KEYS_INIT macro (line 77).  When I hacked my workaround eariier this year I had to make sure I didn't call FIPS_mode_set if it was already set and disable the 512 bit key to get TCN to spin up correctly.

-Rob

________________________________________
From: Mladen Turk [mturk@apache.org]
Sent: Thursday, April 10, 2014 9:01 AM
To: dev@tomcat.apache.org
Subject: Re: [VOTE] Release Apache Tomcat Native 1.1.30

On 04/10/2014 02:56 PM, Ognjen Blagojevic wrote:
>
> Tested with Tomcat 8.0.5, Oracle Java 1.7.0_51 on Windows 7 64-bit.
>
> - Filippo.io [1] reports it is not vulnerable to Heartbleed bug.
>
> - SSLLabs [2] reports it is not vulnerable to Heartbleed bug.
>
> - SSLLabs reports that Forward secrecy is enabled when proper cipher suites (including EECDH/ECDHE) are enabled.
>
> - Smoke tests of APR, with and without TLS, all passed.
>

Cool.

Thanks
--
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat Native 1.1.30

Posted by Mladen Turk <mt...@apache.org>.
On 04/11/2014 08:10 PM, Christopher Schultz wrote:
>>>
>>> The primary tcnative bit was in svn. Did you build 1.1/trunk, or did you
>>> just apply certain patches?
>>>
>>> There was a followup-comment about the 512-bit RSA key generation which
>>> is a separate problem IMO which has not yet been addressed.
>>>
>>
> r1559182 was the back-port to 1.1 branch.
>

Then it's there. If it doesn't work ... Well its your patch :)


Regards
-- 
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat Native 1.1.30

Posted by Christopher Schultz <ch...@christopherschultz.net>.
Mladen,

On 4/10/14, 10:06 AM, Mladen Turk wrote:
> On 04/10/2014 05:55 PM, Christopher Schultz wrote:
>> Mladen,
>>
>> On 4/10/14, 9:29 AM, Mladen Turk wrote:
>>> On 04/10/2014 03:15 PM, Robert Sanders wrote:
>>>> Is the TCN portion of BZ 56027 address completely or partially with
>>>> this release?
>>>
>>> Nope. This issue was not fixed with this release.
>>
>> The primary tcnative bit was in svn. Did you build 1.1/trunk, or did you
>> just apply certain patches?
>>
>> There was a followup-comment about the 512-bit RSA key generation which
>> is a separate problem IMO which has not yet been addressed.
>>
> 
> Ah, now I saw your commit.
> You will have to apply this to branches/1.1.x
> This is where the releases are coming from.
> Trunk is just a playground and probably expecting a major rewrite, so
> don't bother with it :)

r1559182 was the back-port to 1.1 branch.

-chris


Re: [VOTE] Release Apache Tomcat Native 1.1.30

Posted by Mladen Turk <mt...@apache.org>.
On 04/10/2014 05:55 PM, Christopher Schultz wrote:
> Mladen,
>
> On 4/10/14, 9:29 AM, Mladen Turk wrote:
>> On 04/10/2014 03:15 PM, Robert Sanders wrote:
>>> Is the TCN portion of BZ 56027 address completely or partially with
>>> this release?
>>
>> Nope. This issue was not fixed with this release.
>
> The primary tcnative bit was in svn. Did you build 1.1/trunk, or did you
> just apply certain patches?
>
> There was a followup-comment about the 512-bit RSA key generation which
> is a separate problem IMO which has not yet been addressed.
>

Ah, now I saw your commit.
You will have to apply this to branches/1.1.x
This is where the releases are coming from.
Trunk is just a playground and probably expecting a major rewrite, so
don't bother with it :)


Regards
-- 
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat Native 1.1.30

Posted by Mladen Turk <mt...@apache.org>.
On 04/10/2014 05:55 PM, Christopher Schultz wrote:
> Mladen,
>
> On 4/10/14, 9:29 AM, Mladen Turk wrote:
>> On 04/10/2014 03:15 PM, Robert Sanders wrote:
>>> Is the TCN portion of BZ 56027 address completely or partially with
>>> this release?
>>
>> Nope. This issue was not fixed with this release.
>
> The primary tcnative bit was in svn. Did you build 1.1/trunk, or did you
> just apply certain patches?
>
> There was a followup-comment about the 512-bit RSA key generation which
> is a separate problem IMO which has not yet been addressed.
>

See the top email. It contains the tag used for builds.


Regards
-- 
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat Native 1.1.30

Posted by Christopher Schultz <ch...@christopherschultz.net>.
Mladen,

On 4/10/14, 9:29 AM, Mladen Turk wrote:
> On 04/10/2014 03:15 PM, Robert Sanders wrote:
>> Is the TCN portion of BZ 56027 address completely or partially with
>> this release?
> 
> Nope. This issue was not fixed with this release.

The primary tcnative bit was in svn. Did you build 1.1/trunk, or did you
just apply certain patches?

There was a followup-comment about the 512-bit RSA key generation which
is a separate problem IMO which has not yet been addressed.

-chris


Re: [VOTE] Release Apache Tomcat Native 1.1.30

Posted by Mladen Turk <mt...@apache.org>.
On 04/10/2014 03:15 PM, Robert Sanders wrote:
> Is the TCN portion of BZ 56027 address completely or partially with this release?

Nope. This issue was not fixed with this release.


Regards
-- 
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


RE: [VOTE] Release Apache Tomcat Native 1.1.30

Posted by Robert Sanders <rs...@TrustedCS.com>.
Is the TCN portion of BZ 56027 address completely or partially with this release?  I see the exposure of the FIPS_mode setting, but it looks like the temporary 512 bit RSA key is still being done in the SSL_TMP_KEYS_INIT macro (line 77).  When I hacked my workaround eariier this year I had to make sure I didn't call FIPS_mode_set if it was already set and disable the 512 bit key to get TCN to spin up correctly.

-Rob
  
________________________________________
From: Mladen Turk [mturk@apache.org]
Sent: Thursday, April 10, 2014 9:01 AM
To: dev@tomcat.apache.org
Subject: Re: [VOTE] Release Apache Tomcat Native 1.1.30

On 04/10/2014 02:56 PM, Ognjen Blagojevic wrote:
>
> Tested with Tomcat 8.0.5, Oracle Java 1.7.0_51 on Windows 7 64-bit.
>
> - Filippo.io [1] reports it is not vulnerable to Heartbleed bug.
>
> - SSLLabs [2] reports it is not vulnerable to Heartbleed bug.
>
> - SSLLabs reports that Forward secrecy is enabled when proper cipher suites (including EECDH/ECDHE) are enabled.
>
> - Smoke tests of APR, with and without TLS, all passed.
>

Cool.

Thanks
--
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat Native 1.1.30

Posted by Mladen Turk <mt...@apache.org>.
On 04/10/2014 02:56 PM, Ognjen Blagojevic wrote:
>
> Tested with Tomcat 8.0.5, Oracle Java 1.7.0_51 on Windows 7 64-bit.
>
> - Filippo.io [1] reports it is not vulnerable to Heartbleed bug.
>
> - SSLLabs [2] reports it is not vulnerable to Heartbleed bug.
>
> - SSLLabs reports that Forward secrecy is enabled when proper cipher suites (including EECDH/ECDHE) are enabled.
>
> - Smoke tests of APR, with and without TLS, all passed.
>

Cool.

Thanks
-- 
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat Native 1.1.30

Posted by Ognjen Blagojevic <og...@gmail.com>.
Mladen,

On 10.4.2014 13:50, Mladen Turk wrote:
> The Apache Tomcat Native 1.1.30 is
>   [X] Stable, go ahead and release
>   [ ] Broken because of ...

(non-binding)

Tested with Tomcat 8.0.5, Oracle Java 1.7.0_51 on Windows 7 64-bit.

- Filippo.io [1] reports it is not vulnerable to Heartbleed bug.

- SSLLabs [2] reports it is not vulnerable to Heartbleed bug.

- SSLLabs reports that Forward secrecy is enabled when proper cipher 
suites (including EECDH/ECDHE) are enabled.

- Smoke tests of APR, with and without TLS, all passed.

-Ognjen

[1] http://filippo.io/Heartbleed/
[2] https://www.ssllabs.com/ssltes


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[RESULT] was: [VOTE] Release Apache Tomcat Native 1.1.30

Posted by Mladen Turk <mt...@apache.org>.
With 6 binding (Remy, Chris, Konstantin, Tim, Rainer and I) and one non-binding (Ognjen) votes
I declare this vote as passed. I'll copy the artefacts to dist site and create ANN message
after mirror sync

> Version 1.1.30 is bug fixing release with added ECDH
> if supported by OpenSSL library.
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
>
>   [1] http://people.apache.org/~mturk/native/1.1.30
>   [2] https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_1_30

Regards
-- 
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org