You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2016/06/08 07:26:40 UTC
[GitHub] incubator-zeppelin pull request #975: [ZEPPELIN-975] Move download data butt...
GitHub user corneadoug opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/975
[ZEPPELIN-975] Move download data button outside the paragraph settings
### What is this PR for?
Following the PR #714 and its comments, we are moving the download data outside the paragraph settings. Which would allow a possible drop down to choose backend data download in the future.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-975
### How should this be tested?
Show a %Table type of result (you can use below code in a paragraph for that).
You should see the icon, click on it to download the data.
```
print(s"""%table
name\tsize
sun\t127.6
moon\t0.6458
gerard\t45.234856803""")
```
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No, but maybe feature announcement during release
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin improve/downloadDataBtnVisibility
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/975.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #975
----
commit 2ca302818104a1cdd7f230a3c39e690270309f26
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-06-08T07:19:25Z
Move download data button outside the paragraph settings
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #975: [ZEPPELIN-975] Move download data butt...
Posted by corneadoug <gi...@git.apache.org>.
GitHub user corneadoug reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/975
[ZEPPELIN-975] Move download data button outside the paragraph settings
### What is this PR for?
Following the PR #714 and its comments, we are moving the download data outside the paragraph settings. Which would allow a possible drop down to choose backend data download in the future.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-975
### How should this be tested?
Show a %Table type of result (you can use below code in a paragraph for that).
You should see the icon, click on it to download the data.
```
print(s"""%table
name\tsize
sun\t127.6
moon\t0.6458
gerard\t45.234856803""")
```
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No, but maybe feature announcement during release
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin improve/downloadDataBtnVisibility
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/975.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #975
----
commit 2ca302818104a1cdd7f230a3c39e690270309f26
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-06-08T07:19:25Z
Move download data button outside the paragraph settings
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #975: [ZEPPELIN-975] Move download data butt...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/975
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #975: [ZEPPELIN-975] Move download data button outs...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/975
Merging if there is no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #975: [ZEPPELIN-975] Move download data button outs...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/975
CI fail not related:
```
Failed tests:
SparkParagraphIT.testSqlSpark:162 Paragraph from SparkParagraphIT of testSqlSpark status:
Expected: "FINISHED"
but: was "ERROR"
SparkParagraphIT.testSqlSpark:169 Paragraph from SparkParagraphIT of testSqlSpark result:
Expected: "age\njob\nmarital\neducation\nbalance\n30 unemployed married primary 1,787\nage\njob\nmarital\neducation\nbalance"
but: was "Table not found: bank; line 1 pos 14\nset zeppelin.spark.sql.stacktrace = true to see full stacktrace"
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---