You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "dedsec-terminal (via GitHub)" <gi...@apache.org> on 2026/09/11 19:51:44 UTC
[PR] [GLUTEN-12992][CORE] Drop the now-constant ">= 3.4" test gates [gluten]
dedsec-terminal opened a new pull request, #13000:
URL: https://github.com/apache/gluten/pull/13000
## What changes are proposed in this pull request?
Following the removal of Spark 3.2 and Spark 3.3 support (#12902, #12981), Spark 3.4 is the lowest supported profile. Therefore, `testWithMinSparkVersion(name, "3.4")` is constant-true across all supported Spark profiles (3.4, 3.5, 4.0, 4.1).
This PR:
1. Replaces all 57 occurrences of `testWithMinSparkVersion(..., "3.4")` across 14 test suite files with direct `test(...)` calls.
2. Removes uncalled helper methods `testWithRangeSparkVersion` and `ignoreWithSpecifiedSparkVersion` in `GlutenQueryTest`.
3. Keeps all live version gates on 3.5, 4.0, and 4.1 unchanged.
Fixes #12992.
## How was this patch tested?
- Verified all 57 call sites across the 14 suites were replaced with direct `test(...)` calls.
- Verified live gates on 3.5, 4.0, and 4.1 remain intact.
- Verified 0 remaining callers or declarations of `testWithRangeSparkVersion` and `ignoreWithSpecifiedSparkVersion`.
- Verified `git diff --check` and confirmed line lengths comply with Scalafmt/Scalastyle 100-character limit.
## Was this patch authored or co-authored using generative AI tooling?
Generated-by: Antigravity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-12992][CORE] Drop the now-constant ">= 3.4" test gates [gluten]
Posted by "dedsec-terminal (via GitHub)" <gi...@apache.org>.
dedsec-terminal commented on PR #13000:
URL: https://github.com/apache/gluten/pull/13000#issuecomment-5653750480
All four failed workflow groups stopped at the same Spotless violation in GlutenQueryTest.scala (one extra blank line), before their tests ran. Fixed in signed-off commit 1158d96. The fresh workflows are now awaiting maintainer approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-12992][CORE] Drop the now-constant ">= 3.4" test gates [gluten]
Posted by "dedsec-terminal (via GitHub)" <gi...@apache.org>.
dedsec-terminal closed pull request #13000: [GLUTEN-12992][CORE] Drop the now-constant ">= 3.4" test gates
URL: https://github.com/apache/gluten/pull/13000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-12992][CORE] Drop the now-constant ">= 3.4" test gates [gluten]
Posted by "dedsec-terminal (via GitHub)" <gi...@apache.org>.
dedsec-terminal commented on code in PR #13000:
URL: https://github.com/apache/gluten/pull/13000#discussion_r4002314376
##########
gluten-substrait/src/test/scala/org/apache/spark/sql/GlutenQueryTest.scala:
##########
@@ -97,28 +97,6 @@ abstract class GlutenQueryTest extends PlanTest with AdaptiveSparkPlanHelper {
shouldRun
}
- /** Ignore the test if the current spark version is between the minVersion and maxVersion */
- def ignoreWithSpecifiedSparkVersion(
Review Comment:
Agreed. PR #13004 retains both helpers, and I verified that it subsumes the accepted portion of this patch, so I’m consolidating there instead of pushing another revision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-12992][CORE] Drop the now-constant ">= 3.4" test gates [gluten]
Posted by "jackylee-ch (via GitHub)" <gi...@apache.org>.
jackylee-ch commented on code in PR #13000:
URL: https://github.com/apache/gluten/pull/13000#discussion_r4001921777
##########
gluten-substrait/src/test/scala/org/apache/spark/sql/GlutenQueryTest.scala:
##########
@@ -97,28 +97,6 @@ abstract class GlutenQueryTest extends PlanTest with AdaptiveSparkPlanHelper {
shouldRun
}
- /** Ignore the test if the current spark version is between the minVersion and maxVersion */
- def ignoreWithSpecifiedSparkVersion(
Review Comment:
These should not be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-12992][CORE] Drop the now-constant ">= 3.4" test gates [gluten]
Posted by "dedsec-terminal (via GitHub)" <gi...@apache.org>.
dedsec-terminal commented on PR #13000:
URL: https://github.com/apache/gluten/pull/13000#issuecomment-5659228673
Thanks for pointing this out. I compared the patches directly: #13004 includes all 57 constant Spark 3.4 guard replacements from this PR, keeps the two helper methods requested in review, and adds 38 Spark 3.2/3.3 replacements across nine Bolt files. Since no accepted change remains unique here, I’m closing #13000 in favor of the more complete #13004.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-12992][CORE] Drop the now-constant ">= 3.4" test gates [gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13000:
URL: https://github.com/apache/gluten/pull/13000#issuecomment-5639924289
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-12992][CORE] Drop the now-constant ">= 3.4" test gates [gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13000:
URL: https://github.com/apache/gluten/pull/13000#issuecomment-5653725107
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-12992][CORE] Drop the now-constant ">= 3.4" test gates [gluten]
Posted by "jackylee-ch (via GitHub)" <gi...@apache.org>.
jackylee-ch commented on PR #13000:
URL: https://github.com/apache/gluten/pull/13000#issuecomment-5658429483
There is another PR, #13004, that addresses the same issue and also considers the Bolt backend. Could you take a look and see if we can consolidate the two?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-12992][CORE] Drop the now-constant ">= 3.4" test gates [gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13000:
URL: https://github.com/apache/gluten/pull/13000#issuecomment-5639861928
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-12992][CORE] Drop the now-constant ">= 3.4" test gates [gluten]
Posted by "dedsec-terminal (via GitHub)" <gi...@apache.org>.
dedsec-terminal commented on PR #13000:
URL: https://github.com/apache/gluten/pull/13000#issuecomment-5651971570
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-12992][CORE] Drop the now-constant ">= 3.4" test gates [gluten]
Posted by "jackylee-ch (via GitHub)" <gi...@apache.org>.
jackylee-ch commented on PR #13000:
URL: https://github.com/apache/gluten/pull/13000#issuecomment-5659326371
Thanks for your work on this PR! I was hoping we could continue improving it, but I respect your decision to close it.
Really appreciate your contribution, and hope to see more contributions from you in the community!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org