[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #3864: Ignore site to site vpn status check on internallbvm

[GitBox <gi...@apache.org>]

andrijapanicsb commented on a change in pull request #3864: Ignore site to site vpn status check on internallbvm
URL: https://github.com/apache/cloudstack/pull/3864#discussion_r376369773
 
 

 ##########
 File path: server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
 ##########
 @@ -885,6 +885,10 @@ public void doInTransactionWithoutResult(final TransactionStatus status) {
     @DB
     protected void updateSite2SiteVpnConnectionState(final List<DomainRouterVO> routers) {
         for (final DomainRouterVO router : routers) {
+            if (router.getRole() != Role.VIRTUAL_ROUTER) {
 
 Review comment:
   not sure I can advise here... I say we go forward, as NetScaller should definitively NOT be marked as "VIRTUAL_ROUTER"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services